Title: [271066] trunk/Source/ThirdParty/ANGLE
Revision
271066
Author
[email protected]
Date
2020-12-22 15:45:29 -0800 (Tue, 22 Dec 2020)

Log Message

warning: enumerated and non-enumerated type in conditional _expression_ in Compiler.cpp
https://bugs.webkit.org/show_bug.cgi?id=220062

Patch by Michael Catanzaro <[email protected]> on 2020-12-22
Reviewed by Dean Jackson.

Building ANGLE with -Wextra is too aggressive. -Wextra is great for code that we control,
where the burden of squashing warnings is relatively low. But with ANGLE, we have to either
land fixes upstream, or carry them downstream forever. It doesn't make sense to bother with
this for minor build warning fixes when upstream is clearly not using the same warning flags
and/or same compiler that we do.

Since we add -Wextra in our global flags, we have to manually override it here. We can now
also stop explicitly disabling other warnings that are implied by -Wextra.

Finally, note that changes.diff is not modified because this is, confusingly, a downstream
WebKit build file.

* CMakeLists.txt:

Modified Paths

Diff

Modified: trunk/Source/ThirdParty/ANGLE/CMakeLists.txt (271065 => 271066)


--- trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2020-12-22 22:37:46 UTC (rev 271065)
+++ trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2020-12-22 23:45:29 UTC (rev 271066)
@@ -195,9 +195,8 @@
 
 if (COMPILER_IS_GCC_OR_CLANG)
     WEBKIT_ADD_TARGET_CXX_FLAGS(ANGLE -Wno-cast-align
-                                      -Wno-deprecated-copy
+                                      -Wno-extra
                                       -Wno-suggest-attribute=format
-                                      -Wno-type-limits
                                       -Wno-undef
                                       -Wno-unused-parameter)
 endif ()

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (271065 => 271066)


--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2020-12-22 22:37:46 UTC (rev 271065)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2020-12-22 23:45:29 UTC (rev 271066)
@@ -1,3 +1,24 @@
+2020-12-22  Michael Catanzaro  <[email protected]>
+
+        warning: enumerated and non-enumerated type in conditional _expression_ in Compiler.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=220062
+
+        Reviewed by Dean Jackson.
+
+        Building ANGLE with -Wextra is too aggressive. -Wextra is great for code that we control,
+        where the burden of squashing warnings is relatively low. But with ANGLE, we have to either
+        land fixes upstream, or carry them downstream forever. It doesn't make sense to bother with
+        this for minor build warning fixes when upstream is clearly not using the same warning flags
+        and/or same compiler that we do.
+
+        Since we add -Wextra in our global flags, we have to manually override it here. We can now
+        also stop explicitly disabling other warnings that are implied by -Wextra.
+
+        Finally, note that changes.diff is not modified because this is, confusingly, a downstream
+        WebKit build file.
+
+        * CMakeLists.txt:
+
 2020-12-22  Kenneth Russell  <[email protected]>
 
         [WebGL2] deqp/functional/gles3/texturespecification RGB4444 and RGB565 failures on Mac AMD
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to