Title: [271071] trunk/Tools
Revision
271071
Author
[email protected]
Date
2020-12-23 10:51:07 -0800 (Wed, 23 Dec 2020)

Log Message

Simulated Python crash during test runs
https://bugs.webkit.org/show_bug.cgi?id=220108
<rdar://problem/72605338>

Reviewed by Geoffrey Garen.

The ResourceLoadStatistics code can unlink a database during the test
run, which causes a simulated python crash. We already worked around this
by setting the SQLITE_EXEMPT_PATH_FROM_VNODE_GUARDS environment variable
on a temporary directory, but it needs to include /private/var/folders as well.
However, I didn't have any luck setting multiple directories, so I
used '/' instead.

* Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (271070 => 271071)


--- trunk/Tools/ChangeLog	2020-12-23 17:00:45 UTC (rev 271070)
+++ trunk/Tools/ChangeLog	2020-12-23 18:51:07 UTC (rev 271071)
@@ -1,3 +1,21 @@
+2020-12-23  Dean Jackson  <[email protected]>
+
+        Simulated Python crash during test runs
+        https://bugs.webkit.org/show_bug.cgi?id=220108
+        <rdar://problem/72605338>
+
+        Reviewed by Geoffrey Garen.
+
+        The ResourceLoadStatistics code can unlink a database during the test
+        run, which causes a simulated python crash. We already worked around this
+        by setting the SQLITE_EXEMPT_PATH_FROM_VNODE_GUARDS environment variable
+        on a temporary directory, but it needs to include /private/var/folders as well.
+        However, I didn't have any luck setting multiple directories, so I
+        used '/' instead.
+
+        * Scripts/webkitpy/port/driver.py:
+        (Driver._setup_environ_for_driver):
+
 2020-12-22  Ryan Haddad  <[email protected]>
 
         Unreviewed, fix the build with recent SDKs.

Modified: trunk/Tools/Scripts/webkitpy/port/driver.py (271070 => 271071)


--- trunk/Tools/Scripts/webkitpy/port/driver.py	2020-12-23 17:00:45 UTC (rev 271070)
+++ trunk/Tools/Scripts/webkitpy/port/driver.py	2020-12-23 18:51:07 UTC (rev 271071)
@@ -435,7 +435,7 @@
         environment['__XPC_ASAN_OPTIONS'] = environment['ASAN_OPTIONS']
 
         # Disable vnode-guard related simulated crashes for WKTR / DRT (rdar://problem/40674034).
-        environment['SQLITE_EXEMPT_PATH_FROM_VNODE_GUARDS'] = os.path.realpath(environment['DUMPRENDERTREE_TEMP'])
+        environment['SQLITE_EXEMPT_PATH_FROM_VNODE_GUARDS'] = '/'
         environment['__XPC_SQLITE_EXEMPT_PATH_FROM_VNODE_GUARDS'] = environment['SQLITE_EXEMPT_PATH_FROM_VNODE_GUARDS']
 
         environment['JSC_useKernTCSM'] = 'false'
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to