Title: [271076] trunk
Revision
271076
Author
[email protected]
Date
2020-12-23 12:55:32 -0800 (Wed, 23 Dec 2020)

Log Message

[Media in GPU Process][MSE] Media element does not fire "resize" event
https://bugs.webkit.org/show_bug.cgi?id=220119

Reviewed by Eric Carlson.

Source/WebKit:

Implement `RemoteMediaPlayerProxy::mediaPlayerSizeChanged()` to forward the video
resize callback from MSE media player to web process.

No new tests, covered by existing failing layout test.

* GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::mediaPlayerSizeChanged):
* GPUProcess/media/RemoteMediaPlayerProxy.h:

LayoutTests:

* gpu-process/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (271075 => 271076)


--- trunk/LayoutTests/ChangeLog	2020-12-23 20:06:00 UTC (rev 271075)
+++ trunk/LayoutTests/ChangeLog	2020-12-23 20:55:32 UTC (rev 271076)
@@ -1,3 +1,12 @@
+2020-12-23  Peng Liu  <[email protected]>
+
+        [Media in GPU Process][MSE] Media element does not fire "resize" event
+        https://bugs.webkit.org/show_bug.cgi?id=220119
+
+        Reviewed by Eric Carlson.
+
+        * gpu-process/TestExpectations:
+
 2020-12-23  Fujii Hironori  <[email protected]>
 
         [WinCairo] Enable WebGL 2

Modified: trunk/LayoutTests/gpu-process/TestExpectations (271075 => 271076)


--- trunk/LayoutTests/gpu-process/TestExpectations	2020-12-23 20:06:00 UTC (rev 271075)
+++ trunk/LayoutTests/gpu-process/TestExpectations	2020-12-23 20:55:32 UTC (rev 271076)
@@ -279,7 +279,6 @@
 
 media/controls [ Skip ]
 
-media/media-source/media-source-resize.html [ Timeout ]
 media/media-source/media-source-webm.html [ Timeout ]
 
 media/airplay-allows-buffering.html [ Skip ]

Modified: trunk/Source/WebKit/ChangeLog (271075 => 271076)


--- trunk/Source/WebKit/ChangeLog	2020-12-23 20:06:00 UTC (rev 271075)
+++ trunk/Source/WebKit/ChangeLog	2020-12-23 20:55:32 UTC (rev 271076)
@@ -1,3 +1,19 @@
+2020-12-23  Peng Liu  <[email protected]>
+
+        [Media in GPU Process][MSE] Media element does not fire "resize" event
+        https://bugs.webkit.org/show_bug.cgi?id=220119
+
+        Reviewed by Eric Carlson.
+
+        Implement `RemoteMediaPlayerProxy::mediaPlayerSizeChanged()` to forward the video
+        resize callback from MSE media player to web process.
+
+        No new tests, covered by existing failing layout test.
+
+        * GPUProcess/media/RemoteMediaPlayerProxy.cpp:
+        (WebKit::RemoteMediaPlayerProxy::mediaPlayerSizeChanged):
+        * GPUProcess/media/RemoteMediaPlayerProxy.h:
+
 2020-12-23  Simon Fraser  <[email protected]>
 
         Standardize on "allows scrolling" terminology instead of asking about scrollbars

Modified: trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp (271075 => 271076)


--- trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp	2020-12-23 20:06:00 UTC (rev 271075)
+++ trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp	2020-12-23 20:55:32 UTC (rev 271076)
@@ -561,7 +561,7 @@
 
 void RemoteMediaPlayerProxy::mediaPlayerSizeChanged()
 {
-    notImplemented();
+    m_webProcessConnection->send(Messages::MediaPlayerPrivateRemote::SizeChanged(m_player->naturalSize()), m_id);
 }
 
 void RemoteMediaPlayerProxy::mediaPlayerEngineUpdated()

Modified: trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h (271075 => 271076)


--- trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h	2020-12-23 20:06:00 UTC (rev 271075)
+++ trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h	2020-12-23 20:55:32 UTC (rev 271076)
@@ -204,6 +204,7 @@
     void mediaPlayerMuteChanged() final;
     void mediaPlayerTimeChanged() final;
     void mediaPlayerDurationChanged() final;
+    void mediaPlayerSizeChanged() final;
     void mediaPlayerRateChanged() final;
     void mediaPlayerPlaybackStateChanged() final;
     void mediaPlayerResourceNotSupported() final;
@@ -222,7 +223,6 @@
     void mediaPlayerDidRemoveTextTrack(WebCore::InbandTextTrackPrivate&) final;
 
     // Not implemented
-    void mediaPlayerSizeChanged() final;
     void mediaPlayerFirstVideoFrameAvailable() final;
 
 #if ENABLE(LEGACY_ENCRYPTED_MEDIA)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to