Title: [105319] trunk/Tools
- Revision
- 105319
- Author
- aba...@webkit.org
- Date
- 2012-01-18 14:13:41 -0800 (Wed, 18 Jan 2012)
Log Message
Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
https://bugs.webkit.org/show_bug.cgi?id=76567
Reviewed by Eric Seidel.
Current the AppleMac port has slightly more failures than we allow on
the EWS, causing the mac-ews to spin. This patch ups the limit a bit,
which should hopefully let the mac-ews run to completion. Once
AppleMac has fewer failures, we can lower the cap again.
* Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(LayoutTestResultsReaderTest.test_layout_test_results):
* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests):
* Scripts/webkitpy/tool/steps/steps_unittest.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (105318 => 105319)
--- trunk/Tools/ChangeLog 2012-01-18 22:07:58 UTC (rev 105318)
+++ trunk/Tools/ChangeLog 2012-01-18 22:13:41 UTC (rev 105319)
@@ -1,3 +1,21 @@
+2012-01-18 Adam Barth <aba...@webkit.org>
+
+ Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
+ https://bugs.webkit.org/show_bug.cgi?id=76567
+
+ Reviewed by Eric Seidel.
+
+ Current the AppleMac port has slightly more failures than we allow on
+ the EWS, causing the mac-ews to spin. This patch ups the limit a bit,
+ which should hopefully let the mac-ews run to completion. Once
+ AppleMac has fewer failures, we can lower the cap again.
+
+ * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
+ (LayoutTestResultsReaderTest.test_layout_test_results):
+ * Scripts/webkitpy/tool/steps/runtests.py:
+ (RunTests):
+ * Scripts/webkitpy/tool/steps/steps_unittest.py:
+
2012-01-18 Eric Carlson <eric.carl...@apple.com>
Provide access to user's list of preferred languages
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py (105318 => 105319)
--- trunk/Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py 2012-01-18 22:07:58 UTC (rev 105318)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py 2012-01-18 22:13:41 UTC (rev 105319)
@@ -55,7 +55,7 @@
reader._create_layout_test_results = lambda: LayoutTestResults([])
results = reader.results()
self.assertNotEquals(results, None)
- self.assertEquals(results.failure_limit_count(), 20) # This value matches RunTests.NON_INTERACTIVE_FAILURE_LIMIT_COUNT
+ self.assertEquals(results.failure_limit_count(), 30) # This value matches RunTests.NON_INTERACTIVE_FAILURE_LIMIT_COUNT
def test_archive_last_layout_test_results(self):
tool = MockTool()
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py (105318 => 105319)
--- trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py 2012-01-18 22:07:58 UTC (rev 105318)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py 2012-01-18 22:13:41 UTC (rev 105319)
@@ -32,7 +32,7 @@
class RunTests(AbstractStep):
# FIXME: This knowledge really belongs in the commit-queue.
- NON_INTERACTIVE_FAILURE_LIMIT_COUNT = 20
+ NON_INTERACTIVE_FAILURE_LIMIT_COUNT = 30
@classmethod
def options(cls):
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py (105318 => 105319)
--- trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py 2012-01-18 22:07:58 UTC (rev 105318)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py 2012-01-18 22:13:41 UTC (rev 105319)
@@ -111,6 +111,6 @@
Running _javascript_Core tests
MOCK run_and_throw_if_fail: ['Tools/Scripts/run-_javascript_core-tests'], cwd=/mock-checkout
Running run-webkit-tests
-MOCK run_and_throw_if_fail: ['Tools/Scripts/run-webkit-tests', '--no-new-test-results', '--no-launch-safari', '--exit-after-n-failures=20', '--quiet'], cwd=/mock-checkout
+MOCK run_and_throw_if_fail: ['Tools/Scripts/run-webkit-tests', '--no-new-test-results', '--no-launch-safari', '--exit-after-n-failures=30', '--quiet'], cwd=/mock-checkout
"""
OutputCapture().assert_outputs(self, step.run, [{}], expected_stderr=expected_stderr)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
