Title: [271163] trunk/Source/WebCore
- Revision
- 271163
- Author
- [email protected]
- Date
- 2021-01-05 11:17:50 -0800 (Tue, 05 Jan 2021)
Log Message
[GStreamer] Use Ref<> in AudioTrackPrivateGStreamer::create()
https://bugs.webkit.org/show_bug.cgi?id=220324
Reviewed by Philippe Normand.
create() should return Ref<> when the return value can't be null.
This is a cleanup with no functional changes.
* platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (271162 => 271163)
--- trunk/Source/WebCore/ChangeLog 2021-01-05 18:44:30 UTC (rev 271162)
+++ trunk/Source/WebCore/ChangeLog 2021-01-05 19:17:50 UTC (rev 271163)
@@ -1,3 +1,18 @@
+2021-01-05 Alicia Boya García <[email protected]>
+
+ [GStreamer] Use Ref<> in AudioTrackPrivateGStreamer::create()
+ https://bugs.webkit.org/show_bug.cgi?id=220324
+
+ Reviewed by Philippe Normand.
+
+ create() should return Ref<> when the return value can't be null.
+
+ This is a cleanup with no functional changes.
+
+ * platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
+
2021-01-05 Sihui Liu <[email protected]>
Fail speech recognition when page is muted for audio capture
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h (271162 => 271163)
--- trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h 2021-01-05 18:44:30 UTC (rev 271162)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h 2021-01-05 19:17:50 UTC (rev 271163)
@@ -38,12 +38,12 @@
class AudioTrackPrivateGStreamer final : public AudioTrackPrivate, public TrackPrivateBaseGStreamer {
public:
- static RefPtr<AudioTrackPrivateGStreamer> create(WeakPtr<MediaPlayerPrivateGStreamer> player, gint index, GRefPtr<GstPad> pad)
+ static Ref<AudioTrackPrivateGStreamer> create(WeakPtr<MediaPlayerPrivateGStreamer> player, gint index, GRefPtr<GstPad> pad)
{
return adoptRef(*new AudioTrackPrivateGStreamer(player, index, pad));
}
- static RefPtr<AudioTrackPrivateGStreamer> create(WeakPtr<MediaPlayerPrivateGStreamer> player, gint index, GRefPtr<GstStream> stream)
+ static Ref<AudioTrackPrivateGStreamer> create(WeakPtr<MediaPlayerPrivateGStreamer> player, gint index, GRefPtr<GstStream> stream)
{
return adoptRef(*new AudioTrackPrivateGStreamer(player, index, stream));
}
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (271162 => 271163)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2021-01-05 18:44:30 UTC (rev 271162)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2021-01-05 19:17:50 UTC (rev 271163)
@@ -1172,8 +1172,8 @@
if (!track->trackIndex())
track->setActive(true);
ASSERT(streamId == track->id());
- m_audioTracks.add(streamId, track);
- m_player->addAudioTrack(*track);
+ m_audioTracks.add(streamId, track.copyRef());
+ m_player->addAudioTrack(track.get());
}
purgeInvalidAudioTracks(validAudioStreams);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
