Title: [271213] trunk/Source/WebKit
- Revision
- 271213
- Author
- [email protected]
- Date
- 2021-01-06 13:08:16 -0800 (Wed, 06 Jan 2021)
Log Message
[GPUProcess] RemoteAudioSourceProviderManager should be a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=220371
Reviewed by Youenn Fablet.
RemoteAudioSourceProviderManager should be a WorkQueueMessageReceiver (not a ThreadMessageReceiver),
since it uses a WorkQueue (not a WTF::Thread). This simplifies the code a bit.
* WebProcess/GPU/media/RemoteAudioSourceProviderManager.cpp:
(WebKit::RemoteAudioSourceProviderManager::setConnection):
(WebKit::RemoteAudioSourceProviderManager::addProvider):
(WebKit::RemoteAudioSourceProviderManager::removeProvider):
* WebProcess/GPU/media/RemoteAudioSourceProviderManager.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (271212 => 271213)
--- trunk/Source/WebKit/ChangeLog 2021-01-06 20:35:27 UTC (rev 271212)
+++ trunk/Source/WebKit/ChangeLog 2021-01-06 21:08:16 UTC (rev 271213)
@@ -1,3 +1,19 @@
+2021-01-06 Chris Dumez <[email protected]>
+
+ [GPUProcess] RemoteAudioSourceProviderManager should be a WorkQueueMessageReceiver
+ https://bugs.webkit.org/show_bug.cgi?id=220371
+
+ Reviewed by Youenn Fablet.
+
+ RemoteAudioSourceProviderManager should be a WorkQueueMessageReceiver (not a ThreadMessageReceiver),
+ since it uses a WorkQueue (not a WTF::Thread). This simplifies the code a bit.
+
+ * WebProcess/GPU/media/RemoteAudioSourceProviderManager.cpp:
+ (WebKit::RemoteAudioSourceProviderManager::setConnection):
+ (WebKit::RemoteAudioSourceProviderManager::addProvider):
+ (WebKit::RemoteAudioSourceProviderManager::removeProvider):
+ * WebProcess/GPU/media/RemoteAudioSourceProviderManager.h:
+
2021-01-06 Wenson Hsieh <[email protected]>
[Concurrent Display Lists] GPU process should not immediately sleep after reading all available display list items
Modified: trunk/Source/WebKit/WebProcess/GPU/media/RemoteAudioSourceProviderManager.cpp (271212 => 271213)
--- trunk/Source/WebKit/WebProcess/GPU/media/RemoteAudioSourceProviderManager.cpp 2021-01-06 20:35:27 UTC (rev 271212)
+++ trunk/Source/WebKit/WebProcess/GPU/media/RemoteAudioSourceProviderManager.cpp 2021-01-06 21:08:16 UTC (rev 271213)
@@ -54,12 +54,12 @@
return;
if (m_connection)
- m_connection->removeThreadMessageReceiver(Messages::RemoteAudioSourceProviderManager::messageReceiverName());
+ m_connection->removeWorkQueueMessageReceiver(Messages::RemoteAudioSourceProviderManager::messageReceiverName());
m_connection = WTFMove(connection);
if (m_connection)
- m_connection->addThreadMessageReceiver(Messages::RemoteAudioSourceProviderManager::messageReceiverName(), this);
+ m_connection->addWorkQueueMessageReceiver(Messages::RemoteAudioSourceProviderManager::messageReceiverName(), m_queue, this);
}
void RemoteAudioSourceProviderManager::addProvider(Ref<RemoteAudioSourceProvider>&& provider)
@@ -67,7 +67,7 @@
ASSERT(WTF::isMainRunLoop());
setConnection(&WebProcess::singleton().ensureGPUProcessConnection().connection());
- dispatchToThread([this, provider = WTFMove(provider)]() mutable {
+ m_queue->dispatch([this, provider = WTFMove(provider)]() mutable {
auto identifier = provider->identifier();
ASSERT(!m_providers.contains(identifier));
@@ -79,17 +79,12 @@
{
ASSERT(WTF::isMainRunLoop());
- dispatchToThread([this, identifier] {
+ m_queue->dispatch([this, identifier] {
ASSERT(m_providers.contains(identifier));
m_providers.remove(identifier);
});
}
-void RemoteAudioSourceProviderManager::dispatchToThread(Function<void()>&& callback)
-{
- m_queue->dispatch(WTFMove(callback));
-}
-
void RemoteAudioSourceProviderManager::audioStorageChanged(MediaPlayerIdentifier identifier, const SharedMemory::IPCHandle& ipcHandle, const WebCore::CAAudioStreamDescription& description, uint64_t numberOfFrames)
{
ASSERT(!WTF::isMainRunLoop());
Modified: trunk/Source/WebKit/WebProcess/GPU/media/RemoteAudioSourceProviderManager.h (271212 => 271213)
--- trunk/Source/WebKit/WebProcess/GPU/media/RemoteAudioSourceProviderManager.h 2021-01-06 20:35:27 UTC (rev 271212)
+++ trunk/Source/WebKit/WebProcess/GPU/media/RemoteAudioSourceProviderManager.h 2021-01-06 21:08:16 UTC (rev 271213)
@@ -39,7 +39,7 @@
class RemoteAudioSourceProvider;
-class RemoteAudioSourceProviderManager : public IPC::Connection::ThreadMessageReceiverRefCounted {
+class RemoteAudioSourceProviderManager : public IPC::Connection::WorkQueueMessageReceiver {
public:
static Ref<RemoteAudioSourceProviderManager> create() { return adoptRef(*new RemoteAudioSourceProviderManager()); }
~RemoteAudioSourceProviderManager();
@@ -52,9 +52,6 @@
private:
RemoteAudioSourceProviderManager();
- // IPC::Connection::ThreadMessageReceiver
- void dispatchToThread(Function<void()>&&) final;
-
// Messages
void audioStorageChanged(WebCore::MediaPlayerIdentifier, const SharedMemory::IPCHandle&, const WebCore::CAAudioStreamDescription&, uint64_t numberOfFrames);
void audioSamplesAvailable(WebCore::MediaPlayerIdentifier, uint64_t startFrame, uint64_t numberOfFrames);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
