Title: [271242] trunk/JSTests
- Revision
- 271242
- Author
- [email protected]
- Date
- 2021-01-07 10:17:44 -0800 (Thu, 07 Jan 2021)
Log Message
Unreviewed, check ICU header version instead of ICU version
https://bugs.webkit.org/show_bug.cgi?id=220419
Since open-source WebKit is built against old ICU header, we sometimes disable features based on ICU header version.
So, need to check features based on ICU header version instead of ICU version.
* stress/intl-datetimeformat-format-range-should-check-practically-equal.js:
(vm.icuHeaderVersion):
(vm.icuVersion): Deleted.
* stress/intl-datetimeformat-format-range-to-parts-should-check-practically-equal.js:
(vm.icuHeaderVersion):
(vm.icuVersion): Deleted.
Modified Paths
Diff
Modified: trunk/JSTests/ChangeLog (271241 => 271242)
--- trunk/JSTests/ChangeLog 2021-01-07 18:03:33 UTC (rev 271241)
+++ trunk/JSTests/ChangeLog 2021-01-07 18:17:44 UTC (rev 271242)
@@ -1,5 +1,20 @@
2021-01-07 Yusuke Suzuki <[email protected]>
+ Unreviewed, check ICU header version instead of ICU version
+ https://bugs.webkit.org/show_bug.cgi?id=220419
+
+ Since open-source WebKit is built against old ICU header, we sometimes disable features based on ICU header version.
+ So, need to check features based on ICU header version instead of ICU version.
+
+ * stress/intl-datetimeformat-format-range-should-check-practically-equal.js:
+ (vm.icuHeaderVersion):
+ (vm.icuVersion): Deleted.
+ * stress/intl-datetimeformat-format-range-to-parts-should-check-practically-equal.js:
+ (vm.icuHeaderVersion):
+ (vm.icuVersion): Deleted.
+
+2021-01-07 Yusuke Suzuki <[email protected]>
+
Unreviewed, adjust test262 result
https://bugs.webkit.org/show_bug.cgi?id=220420
Modified: trunk/JSTests/stress/intl-datetimeformat-format-range-should-check-practically-equal.js (271241 => 271242)
--- trunk/JSTests/stress/intl-datetimeformat-format-range-should-check-practically-equal.js 2021-01-07 18:03:33 UTC (rev 271241)
+++ trunk/JSTests/stress/intl-datetimeformat-format-range-should-check-practically-equal.js 2021-01-07 18:17:44 UTC (rev 271242)
@@ -34,7 +34,7 @@
throw new Error('bad value: ' + actual);
}
-if ($vm.icuVersion() >= 64) {
+if ($vm.icuHeaderVersion() >= 64) {
{
const date = new Date(2019, 7, 10, 1, 2, 3, 234);
Modified: trunk/JSTests/stress/intl-datetimeformat-format-range-to-parts-should-check-practically-equal.js (271241 => 271242)
--- trunk/JSTests/stress/intl-datetimeformat-format-range-to-parts-should-check-practically-equal.js 2021-01-07 18:03:33 UTC (rev 271241)
+++ trunk/JSTests/stress/intl-datetimeformat-format-range-to-parts-should-check-practically-equal.js 2021-01-07 18:17:44 UTC (rev 271242)
@@ -48,7 +48,7 @@
}
}
-if ($vm.icuVersion() >= 64) {
+if ($vm.icuHeaderVersion() >= 64) {
{
const date = new Date(2019, 7, 10, 1, 2, 3, 234);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
