Title: [271282] trunk/Source/WebKit
- Revision
- 271282
- Author
- [email protected]
- Date
- 2021-01-07 19:58:06 -0800 (Thu, 07 Jan 2021)
Log Message
Remove assertions in MESSAGE_CHECK definition
https://bugs.webkit.org/show_bug.cgi?id=220401
* Platform/IPC/Connection.h:
The unit test associated with r271263 hits these assertions in debug builds.
Since we plan to increase this type of unit testing, I remove the assertions.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (271281 => 271282)
--- trunk/Source/WebKit/ChangeLog 2021-01-08 02:17:17 UTC (rev 271281)
+++ trunk/Source/WebKit/ChangeLog 2021-01-08 03:58:06 UTC (rev 271282)
@@ -1,3 +1,12 @@
+2021-01-07 Alex Christensen <[email protected]>
+
+ Remove assertions in MESSAGE_CHECK definition
+ https://bugs.webkit.org/show_bug.cgi?id=220401
+
+ * Platform/IPC/Connection.h:
+ The unit test associated with r271263 hits these assertions in debug builds.
+ Since we plan to increase this type of unit testing, I remove the assertions.
+
2021-01-07 Mark Lam <[email protected]>
Work around Clang bug in __builtin_return_address().
Modified: trunk/Source/WebKit/Platform/IPC/Connection.h (271281 => 271282)
--- trunk/Source/WebKit/Platform/IPC/Connection.h 2021-01-08 02:17:17 UTC (rev 271281)
+++ trunk/Source/WebKit/Platform/IPC/Connection.h 2021-01-08 03:58:06 UTC (rev 271282)
@@ -80,7 +80,6 @@
#define MESSAGE_CHECK_BASE(assertion, connection) MESSAGE_CHECK_COMPLETION_BASE(assertion, connection, (void)0)
#define MESSAGE_CHECK_COMPLETION_BASE(assertion, connection, completion) do { \
- ASSERT(assertion); \
if (UNLIKELY(!(assertion))) { \
(connection)->markCurrentlyDispatchedMessageAsInvalid(); \
{ completion; } \
@@ -89,7 +88,6 @@
} while (0)
#define MESSAGE_CHECK_WITH_RETURN_VALUE_BASE(assertion, connection, returnValue) do { \
- ASSERT(assertion); \
if (UNLIKELY(!(assertion))) { \
(connection)->markCurrentlyDispatchedMessageAsInvalid(); \
return (returnValue); \
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
