Title: [271299] trunk/Source/WebCore
Revision
271299
Author
[email protected]
Date
2021-01-08 08:58:06 -0800 (Fri, 08 Jan 2021)

Log Message

[Mojave Debug] ASSERTION FAILED: !m_requests.contains(clientIdentifier) in WebKit::SpeechRecognitionServer::start()
https://bugs.webkit.org/show_bug.cgi?id=220426
<rdar://problem/72897083>

Patch by Sihui Liu <[email protected]> on 2021-01-08
Reviewed by Youenn Fablet.

We should send end event to mark the end of recognition. Otherwise, SpeechRecognitionServer does not know the
request is finished and won't remove it from map.

* Modules/speech/SpeechRecognizer.cpp:
(WebCore::SpeechRecognizer::resetRecognition):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (271298 => 271299)


--- trunk/Source/WebCore/ChangeLog	2021-01-08 16:53:57 UTC (rev 271298)
+++ trunk/Source/WebCore/ChangeLog	2021-01-08 16:58:06 UTC (rev 271299)
@@ -1,3 +1,17 @@
+2021-01-08  Sihui Liu  <[email protected]>
+
+        [Mojave Debug] ASSERTION FAILED: !m_requests.contains(clientIdentifier) in WebKit::SpeechRecognitionServer::start()
+        https://bugs.webkit.org/show_bug.cgi?id=220426
+        <rdar://problem/72897083>
+
+        Reviewed by Youenn Fablet.
+
+        We should send end event to mark the end of recognition. Otherwise, SpeechRecognitionServer does not know the 
+        request is finished and won't remove it from map.
+
+        * Modules/speech/SpeechRecognizer.cpp:
+        (WebCore::SpeechRecognizer::resetRecognition):
+
 2021-01-08  Youenn Fablet  <[email protected]>
 
         PaintFrameForMedia has a null identifier when media player is a media stream track video player

Modified: trunk/Source/WebCore/Modules/speech/SpeechRecognizer.cpp (271298 => 271299)


--- trunk/Source/WebCore/Modules/speech/SpeechRecognizer.cpp	2021-01-08 16:53:57 UTC (rev 271298)
+++ trunk/Source/WebCore/Modules/speech/SpeechRecognizer.cpp	2021-01-08 16:58:06 UTC (rev 271299)
@@ -133,6 +133,7 @@
 
 void SpeechRecognizer::resetRecognition()
 {
+    abortRecognition();
 }
 
 #endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to