Title: [271316] trunk
- Revision
- 271316
- Author
- [email protected]
- Date
- 2021-01-08 12:16:39 -0800 (Fri, 08 Jan 2021)
Log Message
[Win] Enable ENABLE_USERSELECT_ALL for -webkit-user-select:all support
https://bugs.webkit.org/show_bug.cgi?id=118740
Reviewed by Don Olmstead.
.:
This change also fixes the assertion failure of
editing/inserting/insert-list-user-select-none-crash.html
(Bug 216256).
* Source/cmake/OptionsFTW.cmake: Removed the line disabling ENABLE_USERSELECT_ALL.
* Source/cmake/OptionsWin.cmake: Ditto.
LayoutTests:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:
Modified Paths
Diff
Modified: trunk/ChangeLog (271315 => 271316)
--- trunk/ChangeLog 2021-01-08 20:10:40 UTC (rev 271315)
+++ trunk/ChangeLog 2021-01-08 20:16:39 UTC (rev 271316)
@@ -1,3 +1,17 @@
+2021-01-08 Fujii Hironori <[email protected]>
+
+ [Win] Enable ENABLE_USERSELECT_ALL for -webkit-user-select:all support
+ https://bugs.webkit.org/show_bug.cgi?id=118740
+
+ Reviewed by Don Olmstead.
+
+ This change also fixes the assertion failure of
+ editing/inserting/insert-list-user-select-none-crash.html
+ (Bug 216256).
+
+ * Source/cmake/OptionsFTW.cmake: Removed the line disabling ENABLE_USERSELECT_ALL.
+ * Source/cmake/OptionsWin.cmake: Ditto.
+
2021-01-07 Ryan Hostetler <[email protected]>
make clean/installsrc fail: You cannot specify -alltargets and also specify individual targets.
Modified: trunk/LayoutTests/ChangeLog (271315 => 271316)
--- trunk/LayoutTests/ChangeLog 2021-01-08 20:10:40 UTC (rev 271315)
+++ trunk/LayoutTests/ChangeLog 2021-01-08 20:16:39 UTC (rev 271316)
@@ -1,3 +1,13 @@
+2021-01-08 Fujii Hironori <[email protected]>
+
+ [Win] Enable ENABLE_USERSELECT_ALL for -webkit-user-select:all support
+ https://bugs.webkit.org/show_bug.cgi?id=118740
+
+ Reviewed by Don Olmstead.
+
+ * platform/win/TestExpectations:
+ * platform/wincairo/TestExpectations:
+
2021-01-08 Youenn Fablet <[email protected]>
Fix count failure check in LayoutTests/webrtc/h264-high.html
Modified: trunk/LayoutTests/platform/win/TestExpectations (271315 => 271316)
--- trunk/LayoutTests/platform/win/TestExpectations 2021-01-08 20:10:40 UTC (rev 271315)
+++ trunk/LayoutTests/platform/win/TestExpectations 2021-01-08 20:16:39 UTC (rev 271316)
@@ -1290,11 +1290,6 @@
webkit.org/b/30234 platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html [ Failure ]
# TODO DRT does not support toggling caret browsing on / off
editing/selection/caret-mode-paragraph-keys-navigation.html [ Skip ]
-webkit.org/b/100424 editing/selection/user-select-all-selection.html [ Failure ]
-webkit.org/b/100424 editing/selection/user-select-all-with-shift.html [ Failure ]
-# TODO -webkit-user-select:all not supported
-webkit.org/b/118740 editing/selection/user-select-all-image-with-single-click.html [ Failure ]
-webkit.org/b/118740 editing/selection/user-select-all-with-single-click.html [ Failure ]
editing/selection/caret-ltr-right.html [ Failure ]
editing/selection/context-menu-on-text.html [ Failure ]
# Lucida Grande is not used for Hebrew text
Modified: trunk/LayoutTests/platform/wincairo/TestExpectations (271315 => 271316)
--- trunk/LayoutTests/platform/wincairo/TestExpectations 2021-01-08 20:10:40 UTC (rev 271315)
+++ trunk/LayoutTests/platform/wincairo/TestExpectations 2021-01-08 20:16:39 UTC (rev 271316)
@@ -1535,10 +1535,6 @@
editing/selection/selection-across-shadow-boundaries-readonly-2.html [ Pass ImageOnlyFailure ]
editing/selection/selection-across-shadow-boundaries-readonly-3.html [ Pass ImageOnlyFailure ]
editing/selection/update-selection-by-style-change.html [ ImageOnlyFailure ]
-editing/selection/user-select-all-image-with-single-click.html [ Failure ]
-editing/selection/user-select-all-selection.html [ Failure ]
-editing/selection/user-select-all-with-shift.html [ Failure ]
-editing/selection/user-select-all-with-single-click.html [ Failure ]
[ Debug ] editing/selection/5057506.html [ Pass Failure ]
[ Debug ] editing/selection/directionality-after-undo-replace.html [ Pass Failure ]
@@ -1852,7 +1848,6 @@
css3/flexbox/flexitem.html [ Failure ]
css3/font-feature-settings-stylistic-set.html [ ImageOnlyFailure ]
css3/masking/clip-path-filter.html [ ImageOnlyFailure ]
-editing/inserting/insert-list-user-select-none-crash.html [ Skip ] # Crash by assertion failure
editing/selection/move-by-word-visually-across-object-element-1.html [ Failure ]
editing/selection/move-by-word-visually-across-object-element-2.html [ Failure ]
editing/selection/move-by-word-visually-across-object-element-3.html [ Failure ]
Modified: trunk/Source/cmake/OptionsFTW.cmake (271315 => 271316)
--- trunk/Source/cmake/OptionsFTW.cmake 2021-01-08 20:10:40 UTC (rev 271315)
+++ trunk/Source/cmake/OptionsFTW.cmake 2021-01-08 20:16:39 UTC (rev 271316)
@@ -164,7 +164,6 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SPEECH_SYNTHESIS PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TELEPHONE_NUMBER_DETECTION PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TEXT_AUTOSIZING PRIVATE OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_USERSELECT_ALL PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_USER_MESSAGE_HANDLERS PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_VARIATION_FONTS PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBDRIVER PRIVATE OFF)
Modified: trunk/Source/cmake/OptionsWin.cmake (271315 => 271316)
--- trunk/Source/cmake/OptionsWin.cmake 2021-01-08 20:10:40 UTC (rev 271315)
+++ trunk/Source/cmake/OptionsWin.cmake 2021-01-08 20:16:39 UTC (rev 271316)
@@ -56,7 +56,6 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_XSLT PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SMOOTH_SCROLLING PRIVATE OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_USERSELECT_ALL PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGL PRIVATE OFF)
# FIXME: Port bmalloc to Windows. https://bugs.webkit.org/show_bug.cgi?id=143310
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
