Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (271318 => 271319)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-01-08 20:33:18 UTC (rev 271318)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-01-08 21:10:45 UTC (rev 271319)
@@ -1,3 +1,21 @@
+2021-01-08 Patrick Angle <[email protected]>
+
+ Web Inspector: Promote experimental "Show independent Styles sidebar" setting to "Elements" settings pane and enable by default
+ https://bugs.webkit.org/show_bug.cgi?id=218126
+
+ Reviewed by Devin Rousso.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ * UserInterface/Base/Setting.js:
+ - Remove experimental naming from setting and enable by default.
+ * UserInterface/Views/RulesStyleDetailsSidebarPanel.js:
+ (WI.RulesStyleDetailsSidebarPanel.prototype.get allowExclusivePresentation):
+ (WI.RulesStyleDetailsSidebarPanel):
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createElementsSettingsView):
+ (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+ - Move setting to "Elements" settings pane.
+
2021-01-07 Patrick Angle <[email protected]>
Web Inspector: console.takeHeapSnapshot() appears to have no effect
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (271318 => 271319)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2021-01-08 20:33:18 UTC (rev 271318)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2021-01-08 21:10:45 UTC (rev 271319)
@@ -442,6 +442,8 @@
localizedStrings["Details"] = "Details";
/* Label for the details sidebar. */
localizedStrings["Details @ Sidebar"] = "Details";
+/* Category label for detail sidebar settings. */
+localizedStrings["Details Sidebars: @ Settings Elements Pane"] = "Details Sidebars:";
localizedStrings["Device %d"] = "Device %d";
localizedStrings["Device Settings"] = "Device Settings";
localizedStrings["Diagnoses common accessibility problems affecting screen readers and other assistive technology."] = "Diagnoses common accessibility problems affecting screen readers and other assistive technology.";
@@ -1300,7 +1302,8 @@
localizedStrings["Show compositing borders"] = "Show compositing borders";
localizedStrings["Show full certificate"] = "Show full certificate";
localizedStrings["Show hidden tabs"] = "Show hidden tabs";
-localizedStrings["Show independent Styles sidebar"] = "Show independent Styles sidebar";
+/* Settings tab checkbox label for whether the independent styles sidebar should be shown */
+localizedStrings["Show independent Styles sidebar @ Settings Elements Pane"] = "Show independent Styles sidebar";
localizedStrings["Show jump to effective property button"] = "Show jump to effective property button";
localizedStrings["Show jump to variable declaration button"] = "Show jump to variable declaration button";
localizedStrings["Show only for selected node"] = "Show only for selected node";
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js (271318 => 271319)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2021-01-08 20:33:18 UTC (rev 271318)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2021-01-08 21:10:45 UTC (rev 271319)
@@ -194,6 +194,7 @@
cpuTimelineThreadDetailsExpanded: new WI.Setting("cpu-timeline-thread-details-expanded", false),
emulateInUserGesture: new WI.Setting("emulate-in-user-gesture", false),
enableControlFlowProfiler: new WI.Setting("enable-control-flow-profiler", false),
+ enableElementsTabIndependentStylesDetailsSidebarPanel: new WI.Setting("elements-tab-independent-styles-details-panel", true),
enableLineWrapping: new WI.Setting("enable-line-wrapping", true),
frontendAppearance: new WI.Setting("frontend-appearance", "system"),
groupMediaRequestsByDOMNode: new WI.Setting("group-media-requests-by-dom-node", WI.Setting.migrateValue("group-by-dom-node") || false),
@@ -222,7 +223,6 @@
experimentalEnablePreviewFeatures: new WI.Setting("experimental-enable-preview-features", true),
experimentalEnableStylesJumpToEffective: new WI.Setting("experimental-styles-jump-to-effective", false),
experimentalEnableStylesJumpToVariableDeclaration: new WI.Setting("experimental-styles-jump-to-variable-declaration", false),
- experimentalEnableIndependentStylesPanel: new WI.Setting("experimental-independent-styles-panel", false),
experimentalEnableFontDetailsPanel: new WI.Setting("experimental-font-details-panel", false),
// Protocol
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsSidebarPanel.js (271318 => 271319)
--- trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsSidebarPanel.js 2021-01-08 20:33:18 UTC (rev 271318)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsSidebarPanel.js 2021-01-08 21:10:45 UTC (rev 271319)
@@ -34,6 +34,6 @@
get allowExclusivePresentation()
{
- return WI.settings.experimentalEnableIndependentStylesPanel.value;
+ return WI.settings.enableElementsTabIndependentStylesDetailsSidebarPanel.value;
}
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (271318 => 271319)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2021-01-08 20:33:18 UTC (rev 271318)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2021-01-08 21:10:45 UTC (rev 271319)
@@ -285,6 +285,9 @@
elementsSettingsView.addSeparator();
}
+ elementsSettingsView.addSetting(WI.UIString("Details Sidebars:", "Details Sidebars: @ Settings Elements Pane", "Category label for detail sidebar settings."), WI.settings.enableElementsTabIndependentStylesDetailsSidebarPanel, WI.UIString("Show independent Styles sidebar", "Show independent Styles sidebar @ Settings Elements Pane", "Settings tab checkbox label for whether the independent styles sidebar should be shown"));
+ elementsSettingsView.addSeparator();
+
elementsSettingsView.addSetting(WI.UIString("CSS Changes:"), WI.settings.cssChangesPerNode, WI.UIString("Show only for selected node"));
this._createReferenceLink(elementsSettingsView);
@@ -400,7 +403,6 @@
}
let elementsGroup = experimentalSettingsView.addGroup(WI.UIString("Elements Tab:", "Elements Tab: @ Experimental Settings", "Category label for experimental settings pertaining to the Elements tab"));
- elementsGroup.addSetting(WI.settings.experimentalEnableIndependentStylesPanel, WI.UIString("Show independent Styles sidebar"));
elementsGroup.addSetting(WI.settings.experimentalEnableFontDetailsPanel, WI.UIString("Show Font details sidebar panel"));
experimentalSettingsView.addSeparator();
@@ -427,7 +429,6 @@
listenForChange(WI.settings.experimentalEnableStylesJumpToVariableDeclaration);
}
- listenForChange(WI.settings.experimentalEnableIndependentStylesPanel);
listenForChange(WI.settings.experimentalEnableFontDetailsPanel);
this._createReferenceLink(experimentalSettingsView);
