Title: [271321] trunk/Source/WebCore
- Revision
- 271321
- Author
- [email protected]
- Date
- 2021-01-08 14:18:26 -0800 (Fri, 08 Jan 2021)
Log Message
REGRESSION (r271273): Crash in WebCore::HTMLMediaElement::setVideoFullscreenGravity
https://bugs.webkit.org/show_bug.cgi?id=220467
Reviewed by Darin Adler.
Add a null check in VideoFullscreenModelVideoElement::setVideoLayerGravity().
Fix layout test crashes:
- media/controls/pip-placeholder-without-video-controls.html
- media/element-containing-pip-video-going-into-fullscreen.html
* platform/cocoa/VideoFullscreenModelVideoElement.mm:
(WebCore::VideoFullscreenModelVideoElement::setVideoLayerGravity):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (271320 => 271321)
--- trunk/Source/WebCore/ChangeLog 2021-01-08 21:49:54 UTC (rev 271320)
+++ trunk/Source/WebCore/ChangeLog 2021-01-08 22:18:26 UTC (rev 271321)
@@ -1,3 +1,19 @@
+2021-01-08 Peng Liu <[email protected]>
+
+ REGRESSION (r271273): Crash in WebCore::HTMLMediaElement::setVideoFullscreenGravity
+ https://bugs.webkit.org/show_bug.cgi?id=220467
+
+ Reviewed by Darin Adler.
+
+ Add a null check in VideoFullscreenModelVideoElement::setVideoLayerGravity().
+
+ Fix layout test crashes:
+ - media/controls/pip-placeholder-without-video-controls.html
+ - media/element-containing-pip-video-going-into-fullscreen.html
+
+ * platform/cocoa/VideoFullscreenModelVideoElement.mm:
+ (WebCore::VideoFullscreenModelVideoElement::setVideoLayerGravity):
+
2021-01-08 Philippe Normand <[email protected]>
[GStreamer] Player audio sink needs to be initialized earlier
Modified: trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm (271320 => 271321)
--- trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm 2021-01-08 21:49:54 UTC (rev 271320)
+++ trunk/Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm 2021-01-08 22:18:26 UTC (rev 271321)
@@ -173,7 +173,8 @@
void VideoFullscreenModelVideoElement::setVideoLayerGravity(MediaPlayer::VideoGravity gravity)
{
- m_videoElement->setVideoFullscreenGravity(gravity);
+ if (m_videoElement)
+ m_videoElement->setVideoFullscreenGravity(gravity);
}
const Vector<AtomString>& VideoFullscreenModelVideoElement::observedEventNames()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
