Title: [271377] trunk/LayoutTests
- Revision
- 271377
- Author
- [email protected]
- Date
- 2021-01-11 13:33:56 -0800 (Mon, 11 Jan 2021)
Log Message
A video element needs to ignore the request to enter/exit fullscreen before the current fullscreen mode change is completed
https://bugs.webkit.org/show_bug.cgi?id=220466
Reviewed by Jer Noble.
A follow-up patch of r271341 to fix a layout test timeout (and failure, see webkit.org/b/183490).
* media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt:
* media/modern-media-controls/media-controller/media-controller-fullscreen-change.html:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (271376 => 271377)
--- trunk/LayoutTests/ChangeLog 2021-01-11 21:12:48 UTC (rev 271376)
+++ trunk/LayoutTests/ChangeLog 2021-01-11 21:33:56 UTC (rev 271377)
@@ -1,3 +1,16 @@
+2021-01-11 Peng Liu <[email protected]>
+
+ A video element needs to ignore the request to enter/exit fullscreen before the current fullscreen mode change is completed
+ https://bugs.webkit.org/show_bug.cgi?id=220466
+
+ Reviewed by Jer Noble.
+
+ A follow-up patch of r271341 to fix a layout test timeout (and failure, see webkit.org/b/183490).
+
+ * media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt:
+ * media/modern-media-controls/media-controller/media-controller-fullscreen-change.html:
+ * platform/mac/TestExpectations:
+
2021-01-11 Devin Rousso <[email protected]>
Web Inspector: Debugger: allow breakpoint actions to be evaluated as a user gesture
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt (271376 => 271377)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt 2021-01-11 21:12:48 UTC (rev 271376)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt 2021-01-11 21:33:56 UTC (rev 271377)
@@ -3,10 +3,12 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+PASS internals.isChangingPresentationMode(media) became false
Media entered fullscreen
PASS mediaController.layoutTraits is LayoutTraits.macOS | LayoutTraits.Fullscreen
PASS mediaController.controls instanceof MacOSFullscreenMediaControls is true
+PASS internals.isChangingPresentationMode(media) became false
Media exited fullscreen
PASS mediaController.layoutTraits is LayoutTraits.macOS | LayoutTraits.Inline
PASS mediaController.controls instanceof MacOSInlineMediaControls is true
Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change.html (271376 => 271377)
--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change.html 2021-01-11 21:12:48 UTC (rev 271376)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change.html 2021-01-11 21:33:56 UTC (rev 271377)
@@ -16,6 +16,9 @@
const button = document.body.appendChild(document.createElement("button"));
button.textContent = "Enter Fullscreen";
+if (window.internals)
+ internals.setMockVideoPresentationModeEnabled(true);
+
function enterFullscreen()
{
if (!("eventSender" in window)) {
@@ -38,7 +41,8 @@
eventSender.mouseUp();
}
-media.addEventListener("webkitfullscreenchange", function() {
+function toggleFullscreen()
+{
if (media.webkitDisplayingFullscreen) {
debug("Media entered fullscreen");
shouldBe("mediaController.layoutTraits", "LayoutTraits.macOS | LayoutTraits.Fullscreen");
@@ -56,6 +60,13 @@
button.remove();
finishJSTest();
}
+}
+
+media.addEventListener("webkitfullscreenchange", function() {
+ if (window.internals)
+ shouldBecomeEqual("internals.isChangingPresentationMode(media)", "false", toggleFullscreen);
+ else
+ toggleFullscreen();
});
media.addEventListener("loadedmetadata", enterFullscreen);
Modified: trunk/LayoutTests/platform/mac/TestExpectations (271376 => 271377)
--- trunk/LayoutTests/platform/mac/TestExpectations 2021-01-11 21:12:48 UTC (rev 271376)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2021-01-11 21:33:56 UTC (rev 271377)
@@ -1454,7 +1454,6 @@
webkit.org/b/183490 media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html [ Failure ]
webkit.org/b/183490 media/modern-media-controls/media-controller/media-controller-fade-controls-when-entering-fullscreen.html [ Failure ]
-webkit.org/b/183490 media/modern-media-controls/media-controller/media-controller-fullscreen-change.html [ Failure ]
webkit.org/b/183490 media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-inline.html [ Failure ]
webkit.org/b/183490 media/modern-media-controls/start-support/start-support-fullscreen.html [ Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
