Title: [271410] trunk/Source/WebInspectorUI
- Revision
- 271410
- Author
- [email protected]
- Date
- 2021-01-12 12:17:14 -0800 (Tue, 12 Jan 2021)
Log Message
Web Inspector: Remove experimental setting and enable Font details sidebar
https://bugs.webkit.org/show_bug.cgi?id=220438
Reviewed by Devin Rousso.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Base/Setting.js:
* UserInterface/Views/ElementsTabContentView.js:
(WI.ElementsTabContentView):
* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (271409 => 271410)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-01-12 19:48:32 UTC (rev 271409)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-01-12 20:17:14 UTC (rev 271410)
@@ -1,3 +1,17 @@
+2021-01-12 Patrick Angle <[email protected]>
+
+ Web Inspector: Remove experimental setting and enable Font details sidebar
+ https://bugs.webkit.org/show_bug.cgi?id=220438
+
+ Reviewed by Devin Rousso.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ * UserInterface/Base/Setting.js:
+ * UserInterface/Views/ElementsTabContentView.js:
+ (WI.ElementsTabContentView):
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+
2021-01-11 Devin Rousso <[email protected]>
Web Inspector: Debugger: allow breakpoint actions to be evaluated as a user gesture
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (271409 => 271410)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2021-01-12 19:48:32 UTC (rev 271409)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2021-01-12 20:17:14 UTC (rev 271410)
@@ -547,8 +547,6 @@
localizedStrings["Elements"] = "Elements";
/* Name of Elements Tab */
localizedStrings["Elements Tab Name"] = "Elements";
-/* Category label for experimental settings pertaining to the Elements tab */
-localizedStrings["Elements Tab: @ Experimental Settings"] = "Elements Tab:";
/* Checkbox shown in the Console to cause future evaluations as though they are in response to user interaction. */
localizedStrings["Emulate User Gesture @ Console"] = "Emulate User Gesture";
/* Checkbox shown when configuring log/evaluate/probe breakpoint actions to cause it to be evaluated as though it was in response to user interaction. */
@@ -1294,7 +1292,6 @@
localizedStrings["Show Console"] = "Show Console";
localizedStrings["Show Console tab"] = "Show Console tab";
localizedStrings["Show Elements"] = "Show Elements";
-localizedStrings["Show Font details sidebar panel"] = "Show Font details sidebar panel";
localizedStrings["Show Path"] = "Show Path";
localizedStrings["Show Remaining (%d)"] = "Show Remaining (%d)";
localizedStrings["Show Scope Chain on pause"] = "Show Scope Chain on pause";
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js (271409 => 271410)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2021-01-12 19:48:32 UTC (rev 271409)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2021-01-12 20:17:14 UTC (rev 271410)
@@ -223,7 +223,6 @@
experimentalEnablePreviewFeatures: new WI.Setting("experimental-enable-preview-features", true),
experimentalEnableStylesJumpToEffective: new WI.Setting("experimental-styles-jump-to-effective", false),
experimentalEnableStylesJumpToVariableDeclaration: new WI.Setting("experimental-styles-jump-to-variable-declaration", false),
- experimentalEnableFontDetailsPanel: new WI.Setting("experimental-font-details-panel", false),
// Protocol
protocolLogAsText: new WI.Setting("protocol-log-as-text", false),
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js (271409 => 271410)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js 2021-01-12 19:48:32 UTC (rev 271409)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js 2021-01-12 20:17:14 UTC (rev 271410)
@@ -33,7 +33,7 @@
];
// COMPATIBILITY (iOS 14.0): `CSS.getFontDataForNode` did not exist yet.
- if (WI.settings.experimentalEnableFontDetailsPanel.value && InspectorBackend.hasCommand("CSS.getFontDataForNode"))
+ if (InspectorBackend.hasCommand("CSS.getFontDataForNode"))
detailsSidebarPanelConstructors.push(WI.FontDetailsSidebarPanel);
detailsSidebarPanelConstructors.push(WI.ChangesDetailsSidebarPanel, WI.DOMNodeDetailsSidebarPanel);
if (InspectorBackend.hasDomain("LayerTree"))
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (271409 => 271410)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2021-01-12 19:48:32 UTC (rev 271409)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2021-01-12 20:17:14 UTC (rev 271410)
@@ -402,10 +402,6 @@
experimentalSettingsView.addSeparator();
}
- let elementsGroup = experimentalSettingsView.addGroup(WI.UIString("Elements Tab:", "Elements Tab: @ Experimental Settings", "Category label for experimental settings pertaining to the Elements tab"));
- elementsGroup.addSetting(WI.settings.experimentalEnableFontDetailsPanel, WI.UIString("Show Font details sidebar panel"));
- experimentalSettingsView.addSeparator();
-
let reloadInspectorButton = document.createElement("button");
reloadInspectorButton.textContent = WI.UIString("Reload Web Inspector");
reloadInspectorButton.addEventListener("click", (event) => {
@@ -429,8 +425,6 @@
listenForChange(WI.settings.experimentalEnableStylesJumpToVariableDeclaration);
}
- listenForChange(WI.settings.experimentalEnableFontDetailsPanel);
-
this._createReferenceLink(experimentalSettingsView);
this.addSettingsView(experimentalSettingsView);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
