Title: [271499] trunk
- Revision
- 271499
- Author
- [email protected]
- Date
- 2021-01-14 14:37:48 -0800 (Thu, 14 Jan 2021)
Log Message
Add dotless j and small N to unicode lookalike character list
https://bugs.webkit.org/show_bug.cgi?id=220632
<rdar://problem/72101901>
Patch by Alex Christensen <[email protected]> on 2021-01-14
Reviewed by David Kilzer.
Source/WTF:
They are visually distinguishable from j and n, but they are also not used in any common languages like dotless i is,
(I know, all my international phonetic alphabet enthusiast friends are disappointed)
so there's not much reason not to add them. Chrome and Firefox have already added them, so let's do it too.
* wtf/URLHelpers.cpp:
(WTF::URLHelpers::isLookalikeCharacter):
Tools:
* TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (271498 => 271499)
--- trunk/Source/WTF/ChangeLog 2021-01-14 21:40:55 UTC (rev 271498)
+++ trunk/Source/WTF/ChangeLog 2021-01-14 22:37:48 UTC (rev 271499)
@@ -1,3 +1,18 @@
+2021-01-14 Alex Christensen <[email protected]>
+
+ Add dotless j and small N to unicode lookalike character list
+ https://bugs.webkit.org/show_bug.cgi?id=220632
+ <rdar://problem/72101901>
+
+ Reviewed by David Kilzer.
+
+ They are visually distinguishable from j and n, but they are also not used in any common languages like dotless i is,
+ (I know, all my international phonetic alphabet enthusiast friends are disappointed)
+ so there's not much reason not to add them. Chrome and Firefox have already added them, so let's do it too.
+
+ * wtf/URLHelpers.cpp:
+ (WTF::URLHelpers::isLookalikeCharacter):
+
2021-01-14 Geoffrey Garen <[email protected]>
Removed most uses of dispatch_async(dispatch_get_main_queue(), ...)
Modified: trunk/Source/WTF/wtf/URLHelpers.cpp (271498 => 271499)
--- trunk/Source/WTF/wtf/URLHelpers.cpp 2021-01-14 21:40:55 UTC (rev 271498)
+++ trunk/Source/WTF/wtf/URLHelpers.cpp 2021-01-14 22:37:48 UTC (rev 271499)
@@ -130,8 +130,10 @@
/* 0x0131 LATIN SMALL LETTER DOTLESS I is intentionally not considered a lookalike character because it is visually distinguishable from i and it has legitimate use in the Turkish language. */
case 0x01C0: /* LATIN LETTER DENTAL CLICK */
case 0x01C3: /* LATIN LETTER RETROFLEX CLICK */
+ case 0x0237: /* LATIN SMALL LETTER DOTLESS J */
case 0x0251: /* LATIN SMALL LETTER ALPHA */
case 0x0261: /* LATIN SMALL LETTER SCRIPT G */
+ case 0x0274: /* LATIN LETTER SMALL CAPITAL N */
case 0x027E: /* LATIN SMALL LETTER R WITH FISHHOOK */
case 0x02D0: /* MODIFIER LETTER TRIANGULAR COLON */
case 0x0335: /* COMBINING SHORT STROKE OVERLAY */
Modified: trunk/Tools/ChangeLog (271498 => 271499)
--- trunk/Tools/ChangeLog 2021-01-14 21:40:55 UTC (rev 271498)
+++ trunk/Tools/ChangeLog 2021-01-14 22:37:48 UTC (rev 271499)
@@ -1,3 +1,14 @@
+2021-01-14 Alex Christensen <[email protected]>
+
+ Add dotless j and small N to unicode lookalike character list
+ https://bugs.webkit.org/show_bug.cgi?id=220632
+ <rdar://problem/72101901>
+
+ Reviewed by David Kilzer.
+
+ * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
+ (TestWebKitAPI::TEST):
+
2021-01-14 Aakash Jain <[email protected]>
EWS should correctly identify the OS for Big Sur dot releases
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm (271498 => 271499)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm 2021-01-14 21:40:55 UTC (rev 271498)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm 2021-01-14 22:37:48 UTC (rev 271499)
@@ -113,6 +113,8 @@
"xn--2-zic", // U+0032 U+05E1
"xn--uoa", // U+027E
"xn--fja", // U+01C0
+ "xn--koa", // U+0274
+ "xn--tma", // U+0237
};
for (const String& host : punycodedSpoofHosts) {
auto url = "" host, "/").utf8();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
