Title: [271536] trunk
- Revision
- 271536
- Author
- [email protected]
- Date
- 2021-01-15 14:54:07 -0800 (Fri, 15 Jan 2021)
Log Message
AX: increment/decrement synthetic arrow events don't work in ARIA slider examples
https://bugs.webkit.org/show_bug.cgi?id=220626
<rdar://problem/73228924>
Reviewed by Zalan Bujtas.
Source/WebCore:
keyCode is still expected to be filled in with standard codes for arrow keys.
Updated test: accessibility/keyevents-posted-for-increment-actions.html
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::postKeyboardKeysForValueChange):
LayoutTests:
* accessibility/keyevents-posted-for-increment-actions-expected.txt:
* accessibility/keyevents-posted-for-increment-actions.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (271535 => 271536)
--- trunk/LayoutTests/ChangeLog 2021-01-15 22:28:53 UTC (rev 271535)
+++ trunk/LayoutTests/ChangeLog 2021-01-15 22:54:07 UTC (rev 271536)
@@ -1,3 +1,14 @@
+2021-01-15 Chris Fleizach <[email protected]>
+
+ AX: increment/decrement synthetic arrow events don't work in ARIA slider examples
+ https://bugs.webkit.org/show_bug.cgi?id=220626
+ <rdar://problem/73228924>
+
+ Reviewed by Zalan Bujtas.
+
+ * accessibility/keyevents-posted-for-increment-actions-expected.txt:
+ * accessibility/keyevents-posted-for-increment-actions.html:
+
2021-01-15 Jer Noble <[email protected]>
Playback fails at marketwatch.com
Modified: trunk/LayoutTests/accessibility/keyevents-posted-for-increment-actions-expected.txt (271535 => 271536)
--- trunk/LayoutTests/accessibility/keyevents-posted-for-increment-actions-expected.txt 2021-01-15 22:28:53 UTC (rev 271535)
+++ trunk/LayoutTests/accessibility/keyevents-posted-for-increment-actions-expected.txt 2021-01-15 22:54:07 UTC (rev 271536)
@@ -5,18 +5,18 @@
Increment/Decrement - LTR
Horizontal orientation
-Keycode received: identifier: right key name: ArrowRight
-Keycode received: identifier: left key name: ArrowLeft
+Keycode received: identifier: right key name: ArrowRight key code: 39
+Keycode received: identifier: left key name: ArrowLeft key code: 37
Vertical orientation
-Keycode received: identifier: up key name: ArrowUp
-Keycode received: identifier: down key name: ArrowDown
+Keycode received: identifier: up key name: ArrowUp key code: 38
+Keycode received: identifier: down key name: ArrowDown key code: 40
Increment/Decrement - RTL
Horizontal orientation
-Keycode received: identifier: left key name: ArrowLeft
-Keycode received: identifier: right key name: ArrowRight
+Keycode received: identifier: left key name: ArrowLeft key code: 37
+Keycode received: identifier: right key name: ArrowRight key code: 39
Vertical orientation
-Keycode received: identifier: up key name: ArrowUp
-Keycode received: identifier: down key name: ArrowDown
+Keycode received: identifier: up key name: ArrowUp key code: 38
+Keycode received: identifier: down key name: ArrowDown key code: 40
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/accessibility/keyevents-posted-for-increment-actions.html (271535 => 271536)
--- trunk/LayoutTests/accessibility/keyevents-posted-for-increment-actions.html 2021-01-15 22:28:53 UTC (rev 271535)
+++ trunk/LayoutTests/accessibility/keyevents-posted-for-increment-actions.html 2021-01-15 22:54:07 UTC (rev 271536)
@@ -20,7 +20,7 @@
var keyCount = 0;
function handleKeyDown(event) {
- debug("Keycode received: identifier: " + event.keyIdentifier + " key name: " + event.key);
+ debug("Keycode received: identifier: " + event.keyIdentifier + " key name: " + event.key + " key code: " + event.keyCode);
event.preventDefault();
event.stopPropagation();
Modified: trunk/Source/WebCore/ChangeLog (271535 => 271536)
--- trunk/Source/WebCore/ChangeLog 2021-01-15 22:28:53 UTC (rev 271535)
+++ trunk/Source/WebCore/ChangeLog 2021-01-15 22:54:07 UTC (rev 271536)
@@ -1,3 +1,18 @@
+2021-01-15 Chris Fleizach <[email protected]>
+
+ AX: increment/decrement synthetic arrow events don't work in ARIA slider examples
+ https://bugs.webkit.org/show_bug.cgi?id=220626
+ <rdar://problem/73228924>
+
+ Reviewed by Zalan Bujtas.
+
+ keyCode is still expected to be filled in with standard codes for arrow keys.
+
+ Updated test: accessibility/keyevents-posted-for-increment-actions.html
+
+ * accessibility/AccessibilityNodeObject.cpp:
+ (WebCore::AccessibilityNodeObject::postKeyboardKeysForValueChange):
+
2021-01-15 Chris Dumez <[email protected]>
[GPUProcess] Move DOM / Canvas rendering off the main thread in the GPUProcess
Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (271535 => 271536)
--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2021-01-15 22:28:53 UTC (rev 271535)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2021-01-15 22:54:07 UTC (rev 271536)
@@ -1134,8 +1134,10 @@
bool vertical = orientation() == AccessibilityOrientation::Vertical;
bool isLTR = page()->userInterfaceLayoutDirection() == UserInterfaceLayoutDirection::LTR;
- keyInit.key = increase ? vertical ? "ArrowUp"_s : isLTR ? "ArrowRight"_s : "ArrowLeft"_s : vertical ? "ArrowDown"_s : isLTR ? "ArrowLeft"_s : "ArrowRight"_s;
- keyInit.keyIdentifier = increase ? vertical ? "up"_s : isLTR ? "right"_s : "left"_s : vertical ? "down"_s : isLTR ? "left"_s : "right"_s;
+ typedef enum { left = 37, up = 38, right = 39, down = 40 } keyCode;
+ keyInit.key = increase ? (vertical ? "ArrowUp"_s : (isLTR ? "ArrowRight"_s : "ArrowLeft"_s)) : (vertical ? "ArrowDown"_s : (isLTR ? "ArrowLeft"_s : "ArrowRight"_s));
+ keyInit.keyCode = increase ? (vertical ? keyCode::up : (isLTR ? keyCode::right : keyCode::left)) : (vertical ? keyCode::down : (isLTR ? keyCode::left : keyCode::right));
+ keyInit.keyIdentifier = increase ? (vertical ? "up"_s : (isLTR ? "right"_s : "left"_s)) : (vertical ? "down"_s : (isLTR ? "left"_s : "right"_s));
return dispatchSimulatedKeyboardUpDownEvent(this, keyInit);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
