Diff
Modified: trunk/Source/WebKit/ChangeLog (271564 => 271565)
--- trunk/Source/WebKit/ChangeLog 2021-01-17 21:06:49 UTC (rev 271564)
+++ trunk/Source/WebKit/ChangeLog 2021-01-17 23:51:38 UTC (rev 271565)
@@ -1,3 +1,23 @@
+2021-01-17 Yusuke Suzuki <[email protected]>
+
+ JITOperation does not exist in WebKit
+ https://bugs.webkit.org/show_bug.cgi?id=220686
+
+ Reviewed by Mark Lam.
+
+ Now, we do not register host functions as JIT operations. As a result, WebKit.framework does not have any JITOperations.
+ We should remove population of JITOperations code in WebKit.framework.
+
+ * Shared/API/c/WKString.cpp:
+ (WKStringCopyJSString):
+ * Shared/Cocoa/WebKit2InitializeCocoa.mm:
+ (WebKit::runInitializationCode):
+ * Shared/WebKit2Initialize.cpp:
+ (WebKit::InitializeWebKit2):
+ * Shared/WebKitJITOperations.cpp: Removed.
+ * Sources.txt:
+ * WebKit.xcodeproj/project.pbxproj:
+
2021-01-17 Fujii Hironori <[email protected]>
[non-Cocoa] Add a new AuxiliaryProcessMainBase class for auxiliary processes without singleton()
Modified: trunk/Source/WebKit/Shared/API/c/WKString.cpp (271564 => 271565)
--- trunk/Source/WebKit/Shared/API/c/WKString.cpp 2021-01-17 21:06:49 UTC (rev 271564)
+++ trunk/Source/WebKit/Shared/API/c/WKString.cpp 2021-01-17 23:51:38 UTC (rev 271565)
@@ -28,7 +28,6 @@
#include "WKStringPrivate.h"
#include "WKAPICast.h"
-#include "WebKitJITOperations.h"
#include <_javascript_Core/InitializeThreading.h>
#include <_javascript_Core/OpaqueJSString.h>
#include <WebCore/WebCoreJITOperations.h>
@@ -137,6 +136,5 @@
{
JSC::initialize();
WebCore::populateJITOperations();
- WebKit::populateJITOperations();
return OpaqueJSString::tryCreate(WebKit::toImpl(stringRef)->string()).leakRef();
}
Modified: trunk/Source/WebKit/Shared/Cocoa/WebKit2InitializeCocoa.mm (271564 => 271565)
--- trunk/Source/WebKit/Shared/Cocoa/WebKit2InitializeCocoa.mm 2021-01-17 21:06:49 UTC (rev 271564)
+++ trunk/Source/WebKit/Shared/Cocoa/WebKit2InitializeCocoa.mm 2021-01-17 23:51:38 UTC (rev 271565)
@@ -26,7 +26,6 @@
#import "config.h"
#import "WebKit2Initialize.h"
-#import "WebKitJITOperations.h"
#import <_javascript_Core/InitializeThreading.h>
#import <WebCore/VersionChecks.h>
#import <WebCore/WebCoreJITOperations.h>
@@ -58,7 +57,6 @@
WTF::RefCountedBase::enableThreadingChecksGlobally();
WebCore::populateJITOperations();
- WebKit::populateJITOperations();
}
void InitializeWebKit2()
Modified: trunk/Source/WebKit/Shared/WebKit2Initialize.cpp (271564 => 271565)
--- trunk/Source/WebKit/Shared/WebKit2Initialize.cpp 2021-01-17 21:06:49 UTC (rev 271564)
+++ trunk/Source/WebKit/Shared/WebKit2Initialize.cpp 2021-01-17 23:51:38 UTC (rev 271565)
@@ -27,7 +27,6 @@
#include "WebKit2Initialize.h"
#include "LogInitialization.h"
-#include "WebKitJITOperations.h"
#include <_javascript_Core/InitializeThreading.h>
#include <WebCore/LogInitialization.h>
#include <WebCore/WebCoreJITOperations.h>
@@ -53,7 +52,6 @@
#endif // !LOG_DISABLED || !RELEASE_LOG_DISABLED
WebCore::populateJITOperations();
- WebKit::populateJITOperations();
}
#endif // !PLATFORM(COCOA)
Deleted: trunk/Source/WebKit/Shared/WebKitJITOperations.cpp (271564 => 271565)
--- trunk/Source/WebKit/Shared/WebKitJITOperations.cpp 2021-01-17 21:06:49 UTC (rev 271564)
+++ trunk/Source/WebKit/Shared/WebKitJITOperations.cpp 2021-01-17 23:51:38 UTC (rev 271565)
@@ -1,48 +0,0 @@
-/*
- * Copyright (C) 2020 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-#include "WebKitJITOperations.h"
-
-#include <_javascript_Core/JITOperationList.h>
-
-namespace WebKit {
-
-#if ENABLE(JIT_OPERATION_VALIDATION)
-extern const uintptr_t startOfJITOperationsInWebKit __asm("section$start$__DATA_CONST$__jsc_ops");
-extern const uintptr_t endOfJITOperationsInWebKit __asm("section$end$__DATA_CONST$__jsc_ops");
-#endif
-
-void populateJITOperations()
-{
-#if ENABLE(JIT_OPERATION_VALIDATION)
- static std::once_flag onceKey;
- std::call_once(onceKey, [] {
- JSC::JITOperationList::populatePointersInEmbedder(&startOfJITOperationsInWebKit, &endOfJITOperationsInWebKit);
- });
-#endif
-}
-
-}
Modified: trunk/Source/WebKit/Sources.txt (271564 => 271565)
--- trunk/Source/WebKit/Sources.txt 2021-01-17 21:06:49 UTC (rev 271564)
+++ trunk/Source/WebKit/Sources.txt 2021-01-17 23:51:38 UTC (rev 271565)
@@ -202,7 +202,6 @@
Shared/WebImage.cpp
Shared/WebKeyboardEvent.cpp @no-unify
Shared/WebKit2Initialize.cpp @no-unify
-Shared/WebKitJITOperations.cpp @no-unify
Shared/WebMemorySampler.cpp
Shared/WebMouseEvent.cpp @no-unify
Shared/WebPageCreationParameters.cpp
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (271564 => 271565)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2021-01-17 21:06:49 UTC (rev 271564)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2021-01-17 23:51:38 UTC (rev 271565)
@@ -1929,7 +1929,6 @@
E1D26A53175964D90095BFD1 /* WebContentProcess.xib in Resources */ = {isa = PBXBuildFile; fileRef = E1D26A4C1759634E0095BFD1 /* WebContentProcess.xib */; };
E1E552C516AE065F004ED653 /* SandboxInitializationParameters.h in Headers */ = {isa = PBXBuildFile; fileRef = E1E552C316AE065E004ED653 /* SandboxInitializationParameters.h */; };
E1EE53E311F8CFC000CCBEE4 /* InjectedBundlePageEditorClient.h in Headers */ = {isa = PBXBuildFile; fileRef = E1EE53DC11F8CF9F00CCBEE4 /* InjectedBundlePageEditorClient.h */; };
- E3582C2B2527F6AA00D1B790 /* WebKitJITOperations.h in Headers */ = {isa = PBXBuildFile; fileRef = E3582C2A2527F69C00D1B790 /* WebKitJITOperations.h */; };
E3866AE52397400400F88FE9 /* WebDeviceOrientationUpdateProviderProxy.mm in Sources */ = {isa = PBXBuildFile; fileRef = E3866AE42397400400F88FE9 /* WebDeviceOrientationUpdateProviderProxy.mm */; };
E3866AE72397405300F88FE9 /* WebDeviceOrientationUpdateProviderProxy.h in Headers */ = {isa = PBXBuildFile; fileRef = E3866AE62397405300F88FE9 /* WebDeviceOrientationUpdateProviderProxy.h */; };
E3866B082399A2D100F88FE9 /* WebDeviceOrientationUpdateProviderProxyMessages.h in Headers */ = {isa = PBXBuildFile; fileRef = E3866B052399979C00F88FE9 /* WebDeviceOrientationUpdateProviderProxyMessages.h */; };
@@ -1939,7 +1938,6 @@
E38A1FC023A551BF00D2374F /* UserInterfaceIdiom.mm in Sources */ = {isa = PBXBuildFile; fileRef = E38A1FBF23A551BF00D2374F /* UserInterfaceIdiom.mm */; };
E39628DD23960CC600658ECD /* WebDeviceOrientationUpdateProvider.h in Headers */ = {isa = PBXBuildFile; fileRef = E39628DB23960CC500658ECD /* WebDeviceOrientationUpdateProvider.h */; };
E39628DE23960CC600658ECD /* WebDeviceOrientationUpdateProvider.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E39628DC23960CC600658ECD /* WebDeviceOrientationUpdateProvider.cpp */; };
- E3C8467C2527F9DE0054FD9C /* WebKitJITOperations.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E3582C292527F69B00D1B790 /* WebKitJITOperations.cpp */; };
E3CAAA442413279900CED2E2 /* AccessibilitySupportSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = E3CAAA432413278A00CED2E2 /* AccessibilitySupportSPI.h */; };
E413F59D1AC1ADC400345360 /* NetworkCacheEntry.h in Headers */ = {isa = PBXBuildFile; fileRef = E413F59B1AC1ADB600345360 /* NetworkCacheEntry.h */; };
E42E06101AA7523B00B11699 /* NetworkCacheIOChannel.h in Headers */ = {isa = PBXBuildFile; fileRef = E42E060B1AA7440D00B11699 /* NetworkCacheIOChannel.h */; };
@@ -5709,8 +5707,6 @@
E1EE53DC11F8CF9F00CCBEE4 /* InjectedBundlePageEditorClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InjectedBundlePageEditorClient.h; sourceTree = "<group>"; };
E1EE53E611F8CFFB00CCBEE4 /* InjectedBundlePageEditorClient.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InjectedBundlePageEditorClient.cpp; sourceTree = "<group>"; };
E3439B632345463A0011DE0B /* NetworkProcessConnectionInfo.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = NetworkProcessConnectionInfo.h; path = Network/NetworkProcessConnectionInfo.h; sourceTree = "<group>"; };
- E3582C292527F69B00D1B790 /* WebKitJITOperations.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WebKitJITOperations.cpp; sourceTree = "<group>"; };
- E3582C2A2527F69C00D1B790 /* WebKitJITOperations.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebKitJITOperations.h; sourceTree = "<group>"; };
E3866AE42397400400F88FE9 /* WebDeviceOrientationUpdateProviderProxy.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = WebDeviceOrientationUpdateProviderProxy.mm; path = ios/WebDeviceOrientationUpdateProviderProxy.mm; sourceTree = "<group>"; };
E3866AE62397405300F88FE9 /* WebDeviceOrientationUpdateProviderProxy.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = WebDeviceOrientationUpdateProviderProxy.h; path = ios/WebDeviceOrientationUpdateProviderProxy.h; sourceTree = "<group>"; };
E3866AED2398471A00F88FE9 /* WebDeviceOrientationUpdateProviderProxy.messages.in */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; name = WebDeviceOrientationUpdateProviderProxy.messages.in; path = ios/WebDeviceOrientationUpdateProviderProxy.messages.in; sourceTree = "<group>"; };
@@ -6609,8 +6605,6 @@
0F4000FF2527D6F700E91DA7 /* WebKeyboardEvent.h */,
BC9BA5021697C45300E44616 /* WebKit2Initialize.cpp */,
BC9BA5031697C45300E44616 /* WebKit2Initialize.h */,
- E3582C292527F69B00D1B790 /* WebKitJITOperations.cpp */,
- E3582C2A2527F69C00D1B790 /* WebKitJITOperations.h */,
905620E812BC248B000799B6 /* WebMemorySampler.cpp */,
905620E912BC248B000799B6 /* WebMemorySampler.h */,
C0337DAF127A28D0008FF4F4 /* WebMouseEvent.cpp */,
@@ -12120,7 +12114,6 @@
1A6280C51919949F006AD9F9 /* WebKit.h in Headers */,
BCB63478116BF10600603215 /* WebKit2_C.h in Headers */,
BC9BA5051697C45300E44616 /* WebKit2Initialize.h in Headers */,
- E3582C2B2527F6AA00D1B790 /* WebKitJITOperations.h in Headers */,
1A6280C71919950C006AD9F9 /* WebKitPrivate.h in Headers */,
CD003A5319D49B5D005ABCE0 /* WebMediaKeyStorageManager.h in Headers */,
9B5BEC262400F4A90070C6EF /* WebMediaStrategy.h in Headers */,
@@ -13997,7 +13990,6 @@
1A6280F31919982A006AD9F9 /* WebKit.m in Sources */,
2D92A78B212B6AB100F493FD /* WebKit2Initialize.cpp in Sources */,
A181A79821ACC74B0059A316 /* WebKitAdditions.mm in Sources */,
- E3C8467C2527F9DE0054FD9C /* WebKitJITOperations.cpp in Sources */,
51F060E11654318500F3282F /* WebMDNSRegisterMessageReceiver.cpp in Sources */,
2D92A78C212B6AB100F493FD /* WebMouseEvent.cpp in Sources */,
31BA924D148831260062EDB5 /* WebNotificationManagerMessageReceiver.cpp in Sources */,