Title: [271578] trunk/Tools
- Revision
- 271578
- Author
- [email protected]
- Date
- 2021-01-18 03:24:27 -0800 (Mon, 18 Jan 2021)
Log Message
[WPE] Fix WPEQt tests after r271514
https://bugs.webkit.org/show_bug.cgi?id=220681
Reviewed by Carlos Garcia Campos.
Setting the title became async, so we must wait for it to be
processed.
* TestWebKitAPI/Tests/WPEQt/TestLoad.cpp:
(TestLoad::main):
* TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp:
(TestLoadHtml::main):
* TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp:
(TestLoadRequest::main):
* TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp:
(TestRunJavaScript::main):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (271577 => 271578)
--- trunk/Tools/ChangeLog 2021-01-18 10:29:00 UTC (rev 271577)
+++ trunk/Tools/ChangeLog 2021-01-18 11:24:27 UTC (rev 271578)
@@ -1,3 +1,22 @@
+2021-01-18 Lauro Moura <[email protected]>
+
+ [WPE] Fix WPEQt tests after r271514
+ https://bugs.webkit.org/show_bug.cgi?id=220681
+
+ Reviewed by Carlos Garcia Campos.
+
+ Setting the title became async, so we must wait for it to be
+ processed.
+
+ * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp:
+ (TestLoad::main):
+ * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp:
+ (TestLoadHtml::main):
+ * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp:
+ (TestLoadRequest::main):
+ * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp:
+ (TestRunJavaScript::main):
+
2021-01-17 Jonathan Bedard <[email protected]>
[webkitscmpy] Add GitHub credentials (Follow-up fix)
Modified: trunk/Tools/TestWebKitAPI/Tests/WPEQt/TestLoad.cpp (271577 => 271578)
--- trunk/Tools/TestWebKitAPI/Tests/WPEQt/TestLoad.cpp 2021-01-18 10:29:00 UTC (rev 271577)
+++ trunk/Tools/TestWebKitAPI/Tests/WPEQt/TestLoad.cpp 2021-01-18 11:24:27 UTC (rev 271578)
@@ -49,6 +49,7 @@
m_view->setUrl(url);
waitForLoadSucceeded(m_view);
+ waitForSignal(m_view, SIGNAL(titleChanged()));
QTRY_COMPARE(m_view->loadProgress(), 100);
QTRY_VERIFY(!m_view->isLoading());
QCOMPARE(m_view->title(), QStringLiteral("FooBar"));
Modified: trunk/Tools/TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp (271577 => 271578)
--- trunk/Tools/TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp 2021-01-18 10:29:00 UTC (rev 271577)
+++ trunk/Tools/TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp 2021-01-18 11:24:27 UTC (rev 271578)
@@ -31,6 +31,7 @@
{
m_view->loadHtml(QString("<html><head><title>WebViewTitle</title></head><body />"));
waitForLoadSucceeded(m_view);
+ waitForSignal(m_view, SIGNAL(titleChanged()));
QTRY_COMPARE(m_view->loadProgress(), 100);
QTRY_VERIFY(!m_view->isLoading());
QCOMPARE(m_view->title(), QStringLiteral("WebViewTitle"));
Modified: trunk/Tools/TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp (271577 => 271578)
--- trunk/Tools/TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp 2021-01-18 10:29:00 UTC (rev 271577)
+++ trunk/Tools/TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp 2021-01-18 11:24:27 UTC (rev 271578)
@@ -47,6 +47,7 @@
QSignalSpy loadChangedSignalSpy(m_view, SIGNAL(loadingChanged(WPEQtViewLoadRequest*)));
m_view->setUrl(url);
waitForLoadSucceeded(m_view);
+ waitForSignal(m_view, SIGNAL(titleChanged()));
QVERIFY(!m_view->isLoading());
QCOMPARE(m_view->loadProgress(), 100);
QCOMPARE(m_view->title(), QStringLiteral("FooBar"));
Modified: trunk/Tools/TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp (271577 => 271578)
--- trunk/Tools/TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp 2021-01-18 10:29:00 UTC (rev 271577)
+++ trunk/Tools/TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp 2021-01-18 11:24:27 UTC (rev 271578)
@@ -33,6 +33,7 @@
m_view->loadHtml(QString("<html><head><title>%1</title></head><body /></html>").arg(title));
waitForLoadSucceeded(m_view);
+ waitForSignal(m_view, SIGNAL(titleChanged()));
QCOMPARE(m_view->loadProgress(), 100);
QVERIFY(!m_view->isLoading());
QCOMPARE(m_view->title(), title);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
