Title: [271589] trunk/Source/WebCore
- Revision
- 271589
- Author
- [email protected]
- Date
- 2021-01-18 16:03:48 -0800 (Mon, 18 Jan 2021)
Log Message
Apple Mail AX, VoiceOver: When composing a new email message, moving VO focus to the message body field does not bring keyboard focus along.
https://bugs.webkit.org/show_bug.cgi?id=220672
<rdar://problem/73045466>
Reviewed by Darin Adler.
The call to AccessibilityObject::setFocused to set the focus to the
scroll view needs to happen before the check for canSetFocusAttribute.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setFocused):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (271588 => 271589)
--- trunk/Source/WebCore/ChangeLog 2021-01-19 00:00:44 UTC (rev 271588)
+++ trunk/Source/WebCore/ChangeLog 2021-01-19 00:03:48 UTC (rev 271589)
@@ -1,5 +1,19 @@
2021-01-18 Andres Gonzalez <[email protected]>
+ Apple Mail AX, VoiceOver: When composing a new email message, moving VO focus to the message body field does not bring keyboard focus along.
+ https://bugs.webkit.org/show_bug.cgi?id=220672
+ <rdar://problem/73045466>
+
+ Reviewed by Darin Adler.
+
+ The call to AccessibilityObject::setFocused to set the focus to the
+ scroll view needs to happen before the check for canSetFocusAttribute.
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::setFocused):
+
+2021-01-18 Andres Gonzalez <[email protected]>
+
Fix for LayoutTests/accessibility/canvas-fallback-content.html in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=220644
Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (271588 => 271589)
--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2021-01-19 00:00:44 UTC (rev 271588)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2021-01-19 00:03:48 UTC (rev 271589)
@@ -1848,6 +1848,9 @@
void AccessibilityRenderObject::setFocused(bool on)
{
+ // Call the base class setFocused to ensure the view is focused and active.
+ AccessibilityObject::setFocused(on);
+
if (!canSetFocusAttribute())
return;
@@ -1859,9 +1862,6 @@
return;
}
- // Call the base class setFocused to ensure the view is focused and active.
- AccessibilityObject::setFocused(on);
-
// When a node is told to set focus, that can cause it to be deallocated, which means that doing
// anything else inside this object will crash. To fix this, we added a RefPtr to protect this object
// long enough for duration.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
