Title: [271744] trunk/Source/WebCore
- Revision
- 271744
- Author
- [email protected]
- Date
- 2021-01-22 07:09:47 -0800 (Fri, 22 Jan 2021)
Log Message
Denying storage access on playstation.com then clicking sign-in fails to show the prompt again
https://bugs.webkit.org/show_bug.cgi?id=220838
<rdar://problem/73477444>
Reviewed by Alex Christensen.
Temporary cross-page storage access in the Web Process for quirks
should only be granted if the user hits "Allow" on the prompt.
This was causing the prompt to fail to show if a user clicks "Don't
Allow" then tries to sign in, then sign-in would fail without
storage access in the Network Process.
* page/Quirks.cpp:
(WebCore::Quirks::requestStorageAccessAndHandleClick const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (271743 => 271744)
--- trunk/Source/WebCore/ChangeLog 2021-01-22 12:11:37 UTC (rev 271743)
+++ trunk/Source/WebCore/ChangeLog 2021-01-22 15:09:47 UTC (rev 271744)
@@ -1,3 +1,20 @@
+2021-01-22 Kate Cheney <[email protected]>
+
+ Denying storage access on playstation.com then clicking sign-in fails to show the prompt again
+ https://bugs.webkit.org/show_bug.cgi?id=220838
+ <rdar://problem/73477444>
+
+ Reviewed by Alex Christensen.
+
+ Temporary cross-page storage access in the Web Process for quirks
+ should only be granted if the user hits "Allow" on the prompt.
+ This was causing the prompt to fail to show if a user clicks "Don't
+ Allow" then tries to sign in, then sign-in would fail without
+ storage access in the Network Process.
+
+ * page/Quirks.cpp:
+ (WebCore::Quirks::requestStorageAccessAndHandleClick const):
+
2021-01-22 Chris Lord <[email protected]>
Remove individual settings accessors from WorkerGlobalScope and add Settings::Values accessor
Modified: trunk/Source/WebCore/page/Quirks.cpp (271743 => 271744)
--- trunk/Source/WebCore/page/Quirks.cpp 2021-01-22 12:11:37 UTC (rev 271743)
+++ trunk/Source/WebCore/page/Quirks.cpp 2021-01-22 15:09:47 UTC (rev 271744)
@@ -1060,6 +1060,11 @@
}
DocumentStorageAccess::requestStorageAccessForNonDocumentQuirk(*m_document, WTFMove(domainInNeedOfStorageAccess), [firstPartyDomain, domainInNeedOfStorageAccess, completionHandler = WTFMove(completionHandler)](StorageAccessWasGranted storageAccessGranted) mutable {
+ if (storageAccessGranted == StorageAccessWasGranted::No) {
+ completionHandler(storageAccessGranted);
+ return;
+ }
+
ResourceLoadObserver::shared().setDomainsWithCrossPageStorageAccess({{ firstPartyDomain, domainInNeedOfStorageAccess }}, [storageAccessGranted, completionHandler = WTFMove(completionHandler)] () mutable {
completionHandler(storageAccessGranted);
});
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
