Title: [271746] trunk
Revision
271746
Author
[email protected]
Date
2021-01-22 09:27:41 -0800 (Fri, 22 Jan 2021)

Log Message

Disable Options:useAtMethod because of compatibility issue.
https://bugs.webkit.org/show_bug.cgi?id=220788
rdar://72933608

Reviewed by Saam Barati and Yusuke Suzuki.

Source/_javascript_Core:

See https://github.com/tc39/proposal-relative-indexing-method/issues/41.

* jsc.cpp:
(CommandLine::parseArguments):
- enable Options::useAtMethod by default for the jsc shell for testing.
* runtime/OptionsList.h:

LayoutTests:

Enable Options::useAtMethod for these tests.

* inspector/model/remote-object-get-properties.html:
* js/Object-getOwnPropertyNames.html:
* js/array-unscopables-properties.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (271745 => 271746)


--- trunk/LayoutTests/ChangeLog	2021-01-22 16:29:46 UTC (rev 271745)
+++ trunk/LayoutTests/ChangeLog	2021-01-22 17:27:41 UTC (rev 271746)
@@ -1,3 +1,17 @@
+2021-01-22  Mark Lam  <[email protected]>
+
+        Disable Options:useAtMethod because of compatibility issue.
+        https://bugs.webkit.org/show_bug.cgi?id=220788
+        rdar://72933608
+
+        Reviewed by Saam Barati and Yusuke Suzuki.
+
+        Enable Options::useAtMethod for these tests.
+
+        * inspector/model/remote-object-get-properties.html:
+        * js/Object-getOwnPropertyNames.html:
+        * js/array-unscopables-properties.html:
+
 2021-01-22  Ziran Sun  <[email protected]>
 
         [css-grid] Relayout grid items when definiteness changes.

Modified: trunk/LayoutTests/inspector/model/remote-object-get-properties.html (271745 => 271746)


--- trunk/LayoutTests/inspector/model/remote-object-get-properties.html	2021-01-22 16:29:46 UTC (rev 271745)
+++ trunk/LayoutTests/inspector/model/remote-object-get-properties.html	2021-01-22 17:27:41 UTC (rev 271746)
@@ -1,4 +1,4 @@
-<!doctype html>
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"><!-- webkit-test-runner [ jscOptions=--useAtMethod=true ] -->
 <html>
 <head>
 <script src=""

Modified: trunk/LayoutTests/js/Object-getOwnPropertyNames.html (271745 => 271746)


--- trunk/LayoutTests/js/Object-getOwnPropertyNames.html	2021-01-22 16:29:46 UTC (rev 271745)
+++ trunk/LayoutTests/js/Object-getOwnPropertyNames.html	2021-01-22 17:27:41 UTC (rev 271746)
@@ -1,4 +1,4 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"><!-- webkit-test-runner [ jscOptions=--useAtMethod=true ] -->
 <html>
 <head>
 <script src=""

Modified: trunk/LayoutTests/js/array-unscopables-properties.html (271745 => 271746)


--- trunk/LayoutTests/js/array-unscopables-properties.html	2021-01-22 16:29:46 UTC (rev 271745)
+++ trunk/LayoutTests/js/array-unscopables-properties.html	2021-01-22 17:27:41 UTC (rev 271746)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"><!-- webkit-test-runner [ jscOptions=--useAtMethod=true ] -->
 <html>
 <head>
 <script src=""

Modified: trunk/Source/_javascript_Core/ChangeLog (271745 => 271746)


--- trunk/Source/_javascript_Core/ChangeLog	2021-01-22 16:29:46 UTC (rev 271745)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-01-22 17:27:41 UTC (rev 271746)
@@ -1,3 +1,18 @@
+2021-01-22  Mark Lam  <[email protected]>
+
+        Disable Options:useAtMethod because of compatibility issue.
+        https://bugs.webkit.org/show_bug.cgi?id=220788
+        rdar://72933608
+
+        Reviewed by Saam Barati and Yusuke Suzuki.
+
+        See https://github.com/tc39/proposal-relative-indexing-method/issues/41.
+
+        * jsc.cpp:
+        (CommandLine::parseArguments):
+        - enable Options::useAtMethod by default for the jsc shell for testing.
+        * runtime/OptionsList.h:
+
 2021-01-21  Devin Rousso  <[email protected]>
 
         [Apple Pay] use the first item in `shippingOptions` even when it's not `selected`

Modified: trunk/Source/_javascript_Core/jsc.cpp (271745 => 271746)


--- trunk/Source/_javascript_Core/jsc.cpp	2021-01-22 16:29:46 UTC (rev 271745)
+++ trunk/Source/_javascript_Core/jsc.cpp	2021-01-22 17:27:41 UTC (rev 271746)
@@ -1,6 +1,6 @@
 /*
  *  Copyright (C) 1999-2000 Harri Porten ([email protected])
- *  Copyright (C) 2004-2020 Apple Inc. All rights reserved.
+ *  Copyright (C) 2004-2021 Apple Inc. All rights reserved.
  *  Copyright (C) 2006 Bjoern Graf ([email protected])
  *
  *  This library is free software; you can redistribute it and/or
@@ -3176,6 +3176,7 @@
     Options::AllowUnfinalizedAccessScope scope;
     Options::initialize();
     Options::useSharedArrayBuffer() = true;
+    Options::useAtMethod() = true;
     
 #if PLATFORM(IOS_FAMILY)
     Options::crashIfCantAllocateJITMemory() = true;

Modified: trunk/Source/_javascript_Core/runtime/OptionsList.h (271745 => 271746)


--- trunk/Source/_javascript_Core/runtime/OptionsList.h	2021-01-22 16:29:46 UTC (rev 271745)
+++ trunk/Source/_javascript_Core/runtime/OptionsList.h	2021-01-22 17:27:41 UTC (rev 271746)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2019-2020 Apple Inc. All rights reserved.
+ * Copyright (C) 2019-2021 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -495,7 +495,7 @@
     v(Bool, useWeakRefs, true, Normal, "Expose the WeakRef constructor.") \
     v(Bool, useIntlDateTimeFormatDayPeriod, true, Normal, "Expose the Intl.DateTimeFormat dayPeriod feature.") \
     v(Bool, useIntlDateTimeFormatRangeToParts, true, Normal, "Expose the Intl.DateTimeFormat#formatRangeToParts feature.") \
-    v(Bool, useAtMethod, true, Normal, "Expose the at() method on Array, %TypedArray%, and String.") \
+    v(Bool, useAtMethod, false, Normal, "Expose the at() method on Array, %TypedArray%, and String.") \
     v(Bool, useSharedArrayBuffer, false, Normal, nullptr) \
     v(Bool, useArrayAllocationProfiling, true, Normal, "If true, we will use our normal array allocation profiling. If false, the allocation profile will always claim to be undecided.") \
     v(Bool, forcePolyProto, false, Normal, "If true, create_this will always create an object with a poly proto structure.") \
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to