Title: [271767] trunk/Source/_javascript_Core
- Revision
- 271767
- Author
- [email protected]
- Date
- 2021-01-22 16:23:06 -0800 (Fri, 22 Jan 2021)
Log Message
Obj-C API should do correct type checks when using a 32-bit address space
https://bugs.webkit.org/show_bug.cgi?id=220880
<rdar://72370334>
Reviewed by Tadeu Zagallo.
* API/JSValue.mm:
(-[JSValue isNull]):
(-[JSValue isBoolean]):
(-[JSValue isNumber]):
(-[JSValue isString]):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/JSValue.mm (271766 => 271767)
--- trunk/Source/_javascript_Core/API/JSValue.mm 2021-01-23 00:07:28 UTC (rev 271766)
+++ trunk/Source/_javascript_Core/API/JSValue.mm 2021-01-23 00:23:06 UTC (rev 271767)
@@ -408,7 +408,7 @@
- (BOOL)isNull
{
#if !CPU(ADDRESS64)
- return JSValueIsUndefined([_context JSGlobalContextRef], m_value);
+ return JSValueIsNull([_context JSGlobalContextRef], m_value);
#else
return toJS(m_value).isNull();
#endif
@@ -417,7 +417,7 @@
- (BOOL)isBoolean
{
#if !CPU(ADDRESS64)
- return JSValueIsUndefined([_context JSGlobalContextRef], m_value);
+ return JSValueIsBoolean([_context JSGlobalContextRef], m_value);
#else
return toJS(m_value).isBoolean();
#endif
@@ -426,7 +426,7 @@
- (BOOL)isNumber
{
#if !CPU(ADDRESS64)
- return JSValueIsUndefined([_context JSGlobalContextRef], m_value);
+ return JSValueIsNumber([_context JSGlobalContextRef], m_value);
#else
return toJS(m_value).isNumber();
#endif
@@ -435,7 +435,7 @@
- (BOOL)isString
{
#if !CPU(ADDRESS64)
- return JSValueIsUndefined([_context JSGlobalContextRef], m_value);
+ return JSValueIsString([_context JSGlobalContextRef], m_value);
#else
return toJS(m_value).isString();
#endif
Modified: trunk/Source/_javascript_Core/ChangeLog (271766 => 271767)
--- trunk/Source/_javascript_Core/ChangeLog 2021-01-23 00:07:28 UTC (rev 271766)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-01-23 00:23:06 UTC (rev 271767)
@@ -1,3 +1,17 @@
+2021-01-22 Keith Miller <[email protected]>
+
+ Obj-C API should do correct type checks when using a 32-bit address space
+ https://bugs.webkit.org/show_bug.cgi?id=220880
+ <rdar://72370334>
+
+ Reviewed by Tadeu Zagallo.
+
+ * API/JSValue.mm:
+ (-[JSValue isNull]):
+ (-[JSValue isBoolean]):
+ (-[JSValue isNumber]):
+ (-[JSValue isString]):
+
2021-01-22 Yusuke Suzuki <[email protected]>
REGRESSION (r271731): Unchecked JS exception under GlobalObject::moduleLoaderFetch
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
