Title: [271776] trunk/Source/WebCore
Revision
271776
Author
[email protected]
Date
2021-01-23 06:16:09 -0800 (Sat, 23 Jan 2021)

Log Message

[LFC][Integration] Disable inline boxes with layers
https://bugs.webkit.org/show_bug.cgi?id=220891

Reviewed by Antti Koivisto.

* layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForChild):
* rendering/RenderInline.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (271775 => 271776)


--- trunk/Source/WebCore/ChangeLog	2021-01-23 12:32:22 UTC (rev 271775)
+++ trunk/Source/WebCore/ChangeLog	2021-01-23 14:16:09 UTC (rev 271776)
@@ -1,3 +1,14 @@
+2021-01-23  Zalan Bujtas  <[email protected]>
+
+        [LFC][Integration] Disable inline boxes with layers
+        https://bugs.webkit.org/show_bug.cgi?id=220891
+
+        Reviewed by Antti Koivisto.
+
+        * layout/integration/LayoutIntegrationCoverage.cpp:
+        (WebCore::LayoutIntegration::canUseForChild):
+        * rendering/RenderInline.h:
+
 2021-01-22  Zalan Bujtas  <[email protected]>
 
         [LFC][RenderTreeDump] Expand RenderInline 0 height quirk logic to previous/next siblings

Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp (271775 => 271776)


--- trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp	2021-01-23 12:32:22 UTC (rev 271775)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp	2021-01-23 14:16:09 UTC (rev 271776)
@@ -649,6 +649,9 @@
         if (renderInline.isRubyInline() || renderInline.isQuote() || renderInline.isSVGInline())
             SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonSupportedChild, reasons, includeReasons);
 
+        if (renderInline.requiresLayer())
+            SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonSupportedChild, reasons, includeReasons)
+
         auto& style = renderInline.style();
         if (!isSupportedStyle(style))
             SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonSupportedChild, reasons, includeReasons)

Modified: trunk/Source/WebCore/rendering/RenderInline.h (271775 => 271776)


--- trunk/Source/WebCore/rendering/RenderInline.h	2021-01-23 12:32:22 UTC (rev 271775)
+++ trunk/Source/WebCore/rendering/RenderInline.h	2021-01-23 14:16:09 UTC (rev 271776)
@@ -89,6 +89,8 @@
 
     bool hitTestCulledInline(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset);
 
+    bool requiresLayer() const override { return isInFlowPositioned() || createsGroup() || hasClipPath() || willChangeCreatesStackingContext() || hasRunningAcceleratedAnimations(); }
+
 protected:
     void willBeDestroyed() override;
 
@@ -119,8 +121,6 @@
 
     bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) final;
 
-    bool requiresLayer() const override { return isInFlowPositioned() || createsGroup() || hasClipPath() || willChangeCreatesStackingContext() || hasRunningAcceleratedAnimations(); }
-
     LayoutUnit offsetLeft() const final;
     LayoutUnit offsetTop() const final;
     LayoutUnit offsetWidth() const final { return linesBoundingBox().width(); }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to