Title: [271783] trunk/Source/WebCore
- Revision
- 271783
- Author
- [email protected]
- Date
- 2021-01-24 11:04:53 -0800 (Sun, 24 Jan 2021)
Log Message
[LFC][IFC] Remove unused function Line::isRunConsideredEmpty
https://bugs.webkit.org/show_bug.cgi?id=220900
Reviewed by Antti Koivisto.
We don't track "is considered empty" line state anymore.
* layout/inlineformatting/InlineLine.cpp:
(WebCore::Layout::Line::isRunConsideredEmpty const): Deleted.
* layout/inlineformatting/InlineLine.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (271782 => 271783)
--- trunk/Source/WebCore/ChangeLog 2021-01-24 17:59:48 UTC (rev 271782)
+++ trunk/Source/WebCore/ChangeLog 2021-01-24 19:04:53 UTC (rev 271783)
@@ -1,5 +1,18 @@
2021-01-24 Zalan Bujtas <[email protected]>
+ [LFC][IFC] Remove unused function Line::isRunConsideredEmpty
+ https://bugs.webkit.org/show_bug.cgi?id=220900
+
+ Reviewed by Antti Koivisto.
+
+ We don't track "is considered empty" line state anymore.
+
+ * layout/inlineformatting/InlineLine.cpp:
+ (WebCore::Layout::Line::isRunConsideredEmpty const): Deleted.
+ * layout/inlineformatting/InlineLine.h:
+
+2021-01-24 Zalan Bujtas <[email protected]>
+
[LFC][IFC] Ceil inline level box's width and height values when converting from float to LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=220898
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp (271782 => 271783)
--- trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp 2021-01-24 17:59:48 UTC (rev 271782)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp 2021-01-24 19:04:53 UTC (rev 271783)
@@ -324,39 +324,6 @@
m_runs.append({ inlineItem, contentLogicalRight(), 0_lu });
}
-bool Line::isRunConsideredEmpty(const Run& run) const
-{
- if (run.isText())
- return false;
-
- if (run.isLineBreak())
- return true;
-
- // Note that this does not check whether the inline container has content. It simply checks if the container itself is considered non-empty.
- if (run.isInlineBoxStart() || run.isInlineBoxEnd()) {
- if (!run.logicalWidth())
- return true;
- // Margin does not make the container non-empty only border or padding.
- auto& boxGeometry = formattingContext().geometryForBox(run.layoutBox());
- auto hasBorderOrPadding = run.isInlineBoxStart() ? boxGeometry.borderLeft() || (boxGeometry.paddingLeft() && boxGeometry.paddingLeft().value())
- : boxGeometry.borderRight() || (boxGeometry.paddingRight() && boxGeometry.paddingRight().value());
- return !hasBorderOrPadding;
- }
-
- if (run.isBox()) {
- if (run.layoutBox().isReplacedBox())
- return false;
- ASSERT(run.layoutBox().isInlineBlockBox() || run.layoutBox().isInlineTableBox());
- return !run.logicalWidth();
- }
-
- if (run.isWordBreakOpportunity())
- return true;
-
- ASSERT_NOT_REACHED();
- return true;
-}
-
void Line::addTrailingHyphen(InlineLayoutUnit hyphenLogicalWidth)
{
for (auto& run : WTF::makeReversedRange(m_runs)) {
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLine.h (271782 => 271783)
--- trunk/Source/WebCore/layout/inlineformatting/InlineLine.h 2021-01-24 17:59:48 UTC (rev 271782)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLine.h 2021-01-24 19:04:53 UTC (rev 271783)
@@ -141,7 +141,6 @@
void removeTrailingTrimmableContent();
void visuallyCollapsePreWrapOverflowContent(InlineLayoutUnit extraHorizontalSpace);
- bool isRunConsideredEmpty(const Run&) const;
const InlineFormattingContext& formattingContext() const;
struct TrimmableTrailingContent {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
