Title: [272043] trunk
- Revision
- 272043
- Author
- [email protected]
- Date
- 2021-01-28 18:54:35 -0800 (Thu, 28 Jan 2021)
Log Message
[ Big Sur ] media/media-source/media-source-webm-init-inside-segment.html is failing
https://bugs.webkit.org/show_bug.cgi?id=220552
<rdar://problem/73048070>
Patch by Jean-Yves Avenard <[email protected]> on 2021-01-28
Reviewed by Jer Noble.
Source/WebCore:
No new tests - fixes an existing test.
* platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::SourceBufferParserWebM::supportedAudioCodecs): Don't make the webm supported codec
conditional.
This change makes the webm audio support consistent with video support. supportedAudioCodecs
is used by the libwebm parser to determine which codec IDs are to be rejected outright.
If a codec id that isn't supported is encountered a parsing error will be thrown, which
ultimately causes a HTML audio or video error.
If webkit is compiled without opus or vorbis support, in this particular case we do not want
an error to be produced but instead ignore the track.
LayoutTests:
* platform/mac/TestExpectations: unskip test
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (272042 => 272043)
--- trunk/LayoutTests/ChangeLog 2021-01-29 02:21:37 UTC (rev 272042)
+++ trunk/LayoutTests/ChangeLog 2021-01-29 02:54:35 UTC (rev 272043)
@@ -1,3 +1,13 @@
+2021-01-28 Jean-Yves Avenard <[email protected]>
+
+ [ Big Sur ] media/media-source/media-source-webm-init-inside-segment.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=220552
+ <rdar://problem/73048070>
+
+ Reviewed by Jer Noble.
+
+ * platform/mac/TestExpectations: unskip test
+
2021-01-28 Peng Liu <[email protected]>
[GPUP][MSE] A video element does not fire “canplaythrough” event if SourceBuffer.abort() is called
Modified: trunk/LayoutTests/platform/mac/TestExpectations (272042 => 272043)
--- trunk/LayoutTests/platform/mac/TestExpectations 2021-01-29 02:21:37 UTC (rev 272042)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2021-01-29 02:54:35 UTC (rev 272043)
@@ -2256,5 +2256,3 @@
webkit.org/b/220077 imported/w3c/web-platform-tests/webrtc/protocol/crypto-suite.https.html [ Pass Failure ]
webkit.org/b/220332 [ BigSur+ ] imported/w3c/web-platform-tests/mimesniff/mime-types/charset-parameter.window.html [ Pass Failure ]
-
-webkit.org/b/220552 [ BigSur+ ] media/media-source/media-source-webm-init-inside-segment.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (272042 => 272043)
--- trunk/Source/WebCore/ChangeLog 2021-01-29 02:21:37 UTC (rev 272042)
+++ trunk/Source/WebCore/ChangeLog 2021-01-29 02:54:35 UTC (rev 272043)
@@ -1,3 +1,24 @@
+2021-01-28 Jean-Yves Avenard <[email protected]>
+
+ [ Big Sur ] media/media-source/media-source-webm-init-inside-segment.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=220552
+ <rdar://problem/73048070>
+
+ Reviewed by Jer Noble.
+
+ No new tests - fixes an existing test.
+
+ * platform/graphics/cocoa/SourceBufferParserWebM.cpp:
+ (WebCore::SourceBufferParserWebM::supportedAudioCodecs): Don't make the webm supported codec
+ conditional.
+ This change makes the webm audio support consistent with video support. supportedAudioCodecs
+ is used by the libwebm parser to determine which codec IDs are to be rejected outright.
+ If a codec id that isn't supported is encountered a parsing error will be thrown, which
+ ultimately causes a HTML audio or video error.
+
+ If webkit is compiled without opus or vorbis support, in this particular case we do not want
+ an error to be produced but instead ignore the track.
+
2021-01-28 Megan Gardner <[email protected]>
Add plumbing to allow AppHighlights to be stored.
Modified: trunk/Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp (272042 => 272043)
--- trunk/Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp 2021-01-29 02:21:37 UTC (rev 272042)
+++ trunk/Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp 2021-01-29 02:54:35 UTC (rev 272043)
@@ -1308,14 +1308,7 @@
const HashSet<String>& SourceBufferParserWebM::supportedAudioCodecs()
{
- static auto codecs = makeNeverDestroyed<HashSet<String>>({
-#if ENABLE(VORBIS)
- "A_VORBIS",
-#endif
-#if ENABLE(OPUS)
- "A_OPUS",
-#endif
- });
+ static auto codecs = makeNeverDestroyed<HashSet<String>>({ "A_VORBIS", "A_OPUS" });
return codecs;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
