- Revision
- 272053
- Author
- [email protected]
- Date
- 2021-01-29 01:01:22 -0800 (Fri, 29 Jan 2021)
Log Message
[MacOS] Enable WebKitTestRunner audio and video capture in GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=221035
Reviewed by Eric Carlson.
Tools:
Remove the default TestOptions values and instead on MacOS rely on capture in GPUProcess.
On iOS, capture ill still happen inprocess for the time being.
* WebKitTestRunner/TestOptions.cpp:
(WTR::TestOptions::defaults):
LayoutTests:
fast/mediastream/media-stream-track-interrupted.html needs to be run with mock audio capture in process
as interruption mock testing is only supported this way.
SpeechRecognition in GPUProcess is not yet working so we disable capture in GPU Process for these two tests
until SpeechRecognition in GPUProcess is supported.
* fast/mediastream/media-stream-track-interrupted.html:
* fast/speechrecognition/start-recognition-then-stop.html:
* fast/speechrecognition/start-second-recognition.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (272052 => 272053)
--- trunk/LayoutTests/ChangeLog 2021-01-29 08:53:14 UTC (rev 272052)
+++ trunk/LayoutTests/ChangeLog 2021-01-29 09:01:22 UTC (rev 272053)
@@ -1,5 +1,21 @@
2021-01-29 Youenn Fablet <[email protected]>
+ [MacOS] Enable WebKitTestRunner audio and video capture in GPUProcess
+ https://bugs.webkit.org/show_bug.cgi?id=221035
+
+ Reviewed by Eric Carlson.
+
+ fast/mediastream/media-stream-track-interrupted.html needs to be run with mock audio capture in process
+ as interruption mock testing is only supported this way.
+ SpeechRecognition in GPUProcess is not yet working so we disable capture in GPU Process for these two tests
+ until SpeechRecognition in GPUProcess is supported.
+
+ * fast/mediastream/media-stream-track-interrupted.html:
+ * fast/speechrecognition/start-recognition-then-stop.html:
+ * fast/speechrecognition/start-second-recognition.html:
+
+2021-01-29 Youenn Fablet <[email protected]>
+
Use WebRTC GPU process flag for MediaRecorder
https://bugs.webkit.org/show_bug.cgi?id=220967
Modified: trunk/LayoutTests/fast/mediastream/media-stream-track-interrupted.html (272052 => 272053)
--- trunk/LayoutTests/fast/mediastream/media-stream-track-interrupted.html 2021-01-29 08:53:14 UTC (rev 272052)
+++ trunk/LayoutTests/fast/mediastream/media-stream-track-interrupted.html 2021-01-29 09:01:22 UTC (rev 272053)
@@ -1,4 +1,4 @@
-<!-- webkit-test-runner [ CaptureAudioInUIProcessEnabled=false ] -->
+<!DOCTYPE html><!-- webkit-test-runner [ CaptureAudioInGPUProcessEnabled=false CaptureAudioInUIProcessEnabled=false ] -->
<!DOCTYPE html>
<html>
<head>
Modified: trunk/LayoutTests/fast/speechrecognition/start-recognition-then-stop.html (272052 => 272053)
--- trunk/LayoutTests/fast/speechrecognition/start-recognition-then-stop.html 2021-01-29 08:53:14 UTC (rev 272052)
+++ trunk/LayoutTests/fast/speechrecognition/start-recognition-then-stop.html 2021-01-29 09:01:22 UTC (rev 272053)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ CaptureAudioInGPUProcessEnabled=false ] -->
<html>
<body>
<script src=""
@@ -34,4 +34,4 @@
</script>
</body>
-</html>
\ No newline at end of file
+</html>
Modified: trunk/LayoutTests/fast/speechrecognition/start-second-recognition.html (272052 => 272053)
--- trunk/LayoutTests/fast/speechrecognition/start-second-recognition.html 2021-01-29 08:53:14 UTC (rev 272052)
+++ trunk/LayoutTests/fast/speechrecognition/start-second-recognition.html 2021-01-29 09:01:22 UTC (rev 272053)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ CaptureAudioInGPUProcessEnabled=false ] -->
<html>
<body>
<script src=""
@@ -29,4 +29,4 @@
</script>
</body>
-</html>
\ No newline at end of file
+</html>
Modified: trunk/Tools/ChangeLog (272052 => 272053)
--- trunk/Tools/ChangeLog 2021-01-29 08:53:14 UTC (rev 272052)
+++ trunk/Tools/ChangeLog 2021-01-29 09:01:22 UTC (rev 272053)
@@ -1,3 +1,16 @@
+2021-01-29 Youenn Fablet <[email protected]>
+
+ [MacOS] Enable WebKitTestRunner audio and video capture in GPUProcess
+ https://bugs.webkit.org/show_bug.cgi?id=221035
+
+ Reviewed by Eric Carlson.
+
+ Remove the default TestOptions values and instead on MacOS rely on capture in GPUProcess.
+ On iOS, capture ill still happen inprocess for the time being.
+
+ * WebKitTestRunner/TestOptions.cpp:
+ (WTR::TestOptions::defaults):
+
2021-01-29 Carlos Garcia Campos <[email protected]>
[SOUP] Use a GInputStream to set the request body in preparation for libsoup3
Modified: trunk/Tools/WebKitTestRunner/TestOptions.cpp (272052 => 272053)
--- trunk/Tools/WebKitTestRunner/TestOptions.cpp 2021-01-29 08:53:14 UTC (rev 272052)
+++ trunk/Tools/WebKitTestRunner/TestOptions.cpp 2021-01-29 09:01:22 UTC (rev 272053)
@@ -31,6 +31,14 @@
namespace WTR {
+#if PLATFORM(MAC)
+static constexpr bool captureAudioInGPUProcessEnabledValue = true;
+static constexpr bool captureVideoInGPUProcessEnabledValue = true;
+#else
+static constexpr bool captureAudioInGPUProcessEnabledValue = false;
+static constexpr bool captureVideoInGPUProcessEnabledValue = false;
+#endif
+
const TestFeatures& TestOptions::defaults()
{
static TestFeatures features;
@@ -44,9 +52,9 @@
{ "AllowUniversalAccessFromFileURLs", true },
{ "AsyncFrameScrollingEnabled", false },
{ "AsyncOverflowScrollingEnabled", false },
- { "CaptureAudioInGPUProcessEnabled", false },
+ { "CaptureAudioInGPUProcessEnabled", captureAudioInGPUProcessEnabledValue },
{ "CaptureAudioInUIProcessEnabled", false },
- { "CaptureVideoInGPUProcessEnabled", false },
+ { "CaptureVideoInGPUProcessEnabled", captureVideoInGPUProcessEnabledValue },
{ "CaptureVideoInUIProcessEnabled", false },
{ "DOMPasteAllowed", true },
{ "FrameFlatteningEnabled", false },
