Title: [272106] branches/safari-611-branch
Revision
272106
Author
[email protected]
Date
2021-01-29 21:41:08 -0800 (Fri, 29 Jan 2021)

Log Message

Cherry-pick r271388. rdar://problem/73473676

    Safari 14 on 2x display renders NYS DMV page as blurry
    https://bugs.webkit.org/show_bug.cgi?id=220528
    <rdar://problem/71440246>

    Reviewed by Tim Horton.

    Source/WebCore:

    Certain combinations of nested perspective and transform cause Core Animation to
    rasterize at unit scale, which makes layers blurry on Retina displays.

    Enable code that was already used on iOS to set layer rasterization scale.

    Test: compositing/contents-scale/hidpi-tests/rasterization-scale.html

    * platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
    (WebCore::PlatformCALayerCocoa::setContentsScale):

    LayoutTests:

    * compositing/contents-scale/hidpi-tests/rasterization-scale-expected.html: Added.
    * compositing/contents-scale/hidpi-tests/rasterization-scale.html: Added.

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Added Paths

Diff

Modified: branches/safari-611-branch/LayoutTests/ChangeLog (272105 => 272106)


--- branches/safari-611-branch/LayoutTests/ChangeLog	2021-01-30 05:41:05 UTC (rev 272105)
+++ branches/safari-611-branch/LayoutTests/ChangeLog	2021-01-30 05:41:08 UTC (rev 272106)
@@ -1,5 +1,46 @@
 2021-01-29  Alan Coon  <[email protected]>
 
+        Cherry-pick r271388. rdar://problem/73473676
+
+    Safari 14 on 2x display renders NYS DMV page as blurry
+    https://bugs.webkit.org/show_bug.cgi?id=220528
+    <rdar://problem/71440246>
+    
+    Reviewed by Tim Horton.
+    
+    Source/WebCore:
+    
+    Certain combinations of nested perspective and transform cause Core Animation to
+    rasterize at unit scale, which makes layers blurry on Retina displays.
+    
+    Enable code that was already used on iOS to set layer rasterization scale.
+    
+    Test: compositing/contents-scale/hidpi-tests/rasterization-scale.html
+    
+    * platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
+    (WebCore::PlatformCALayerCocoa::setContentsScale):
+    
+    LayoutTests:
+    
+    * compositing/contents-scale/hidpi-tests/rasterization-scale-expected.html: Added.
+    * compositing/contents-scale/hidpi-tests/rasterization-scale.html: Added.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-01-11  Simon Fraser  <[email protected]>
+
+            Safari 14 on 2x display renders NYS DMV page as blurry
+            https://bugs.webkit.org/show_bug.cgi?id=220528
+            <rdar://problem/71440246>
+
+            Reviewed by Tim Horton.
+
+            * compositing/contents-scale/hidpi-tests/rasterization-scale-expected.html: Added.
+            * compositing/contents-scale/hidpi-tests/rasterization-scale.html: Added.
+
+2021-01-29  Alan Coon  <[email protected]>
+
         Cherry-pick r271379. rdar://problem/73473604
 
     Keep newly created IDBObjectStores in deleted map when IDBTransaction is aborted

Added: branches/safari-611-branch/LayoutTests/compositing/contents-scale/hidpi-tests/rasterization-scale-expected.html (0 => 272106)


--- branches/safari-611-branch/LayoutTests/compositing/contents-scale/hidpi-tests/rasterization-scale-expected.html	                        (rev 0)
+++ branches/safari-611-branch/LayoutTests/compositing/contents-scale/hidpi-tests/rasterization-scale-expected.html	2021-01-30 05:41:08 UTC (rev 272106)
@@ -0,0 +1,27 @@
+<!DOCTYPE html>
+<html>
+<head>
+    <meta name="viewport" content="initial-scale=1.0">
+    <style>
+        .container {
+            overflow: hidden;
+            padding: 10px;
+            height: 2450px;
+        }
+        
+        .child {
+            height: 2500px;
+            overflow: hidden;
+            transform: translateZ(0);
+        }
+    </style>
+</head>
+<body>
+
+<div class="container">
+    <div class="child">
+        <p>This text should not be blurry on retina devices</p>
+    </div>
+</div>
+</body>
+</html>

Added: branches/safari-611-branch/LayoutTests/compositing/contents-scale/hidpi-tests/rasterization-scale.html (0 => 272106)


--- branches/safari-611-branch/LayoutTests/compositing/contents-scale/hidpi-tests/rasterization-scale.html	                        (rev 0)
+++ branches/safari-611-branch/LayoutTests/compositing/contents-scale/hidpi-tests/rasterization-scale.html	2021-01-30 05:41:08 UTC (rev 272106)
@@ -0,0 +1,29 @@
+<!DOCTYPE html>
+<html>
+<head>
+    <meta name="viewport" content="initial-scale=1.0">
+    <style>
+        .container {
+            perspective: 1000px;
+            overflow: hidden;
+            padding: 10px;
+            height: 2450px;
+        }
+        
+        .child {
+            height: 2500px;
+            overflow: hidden;
+            perspective: 1000px;
+            transform: translateZ(0);
+        }
+    </style>
+</head>
+<body>
+
+<div class="container">
+    <div class="child">
+        <p>This text should not be blurry on retina devices</p>
+    </div>
+</div>
+</body>
+</html>

Modified: branches/safari-611-branch/Source/WebCore/ChangeLog (272105 => 272106)


--- branches/safari-611-branch/Source/WebCore/ChangeLog	2021-01-30 05:41:05 UTC (rev 272105)
+++ branches/safari-611-branch/Source/WebCore/ChangeLog	2021-01-30 05:41:08 UTC (rev 272106)
@@ -1,5 +1,53 @@
 2021-01-29  Alan Coon  <[email protected]>
 
+        Cherry-pick r271388. rdar://problem/73473676
+
+    Safari 14 on 2x display renders NYS DMV page as blurry
+    https://bugs.webkit.org/show_bug.cgi?id=220528
+    <rdar://problem/71440246>
+    
+    Reviewed by Tim Horton.
+    
+    Source/WebCore:
+    
+    Certain combinations of nested perspective and transform cause Core Animation to
+    rasterize at unit scale, which makes layers blurry on Retina displays.
+    
+    Enable code that was already used on iOS to set layer rasterization scale.
+    
+    Test: compositing/contents-scale/hidpi-tests/rasterization-scale.html
+    
+    * platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
+    (WebCore::PlatformCALayerCocoa::setContentsScale):
+    
+    LayoutTests:
+    
+    * compositing/contents-scale/hidpi-tests/rasterization-scale-expected.html: Added.
+    * compositing/contents-scale/hidpi-tests/rasterization-scale.html: Added.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-01-11  Simon Fraser  <[email protected]>
+
+            Safari 14 on 2x display renders NYS DMV page as blurry
+            https://bugs.webkit.org/show_bug.cgi?id=220528
+            <rdar://problem/71440246>
+
+            Reviewed by Tim Horton.
+
+            Certain combinations of nested perspective and transform cause Core Animation to
+            rasterize at unit scale, which makes layers blurry on Retina displays.
+
+            Enable code that was already used on iOS to set layer rasterization scale.
+
+            Test: compositing/contents-scale/hidpi-tests/rasterization-scale.html
+
+            * platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
+            (WebCore::PlatformCALayerCocoa::setContentsScale):
+
+2021-01-29  Alan Coon  <[email protected]>
+
         Cherry-pick r271379. rdar://problem/73473604
 
     Keep newly created IDBObjectStores in deleted map when IDBTransaction is aborted

Modified: branches/safari-611-branch/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm (272105 => 272106)


--- branches/safari-611-branch/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm	2021-01-30 05:41:05 UTC (rev 272105)
+++ branches/safari-611-branch/Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm	2021-01-30 05:41:08 UTC (rev 272106)
@@ -915,9 +915,7 @@
 {
     BEGIN_BLOCK_OBJC_EXCEPTIONS
     [m_layer setContentsScale:value];
-#if PLATFORM(IOS_FAMILY)
     [m_layer setRasterizationScale:value];
-#endif
     END_BLOCK_OBJC_EXCEPTIONS
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to