Title: [272112] branches/safari-611-branch/Source/WebCore
Revision
272112
Author
[email protected]
Date
2021-01-29 21:41:37 -0800 (Fri, 29 Jan 2021)

Log Message

Cherry-pick r271515. rdar://problem/73473627

    REGRESSION(r269813): PLT5 regressed by 0.5%
    https://bugs.webkit.org/show_bug.cgi?id=220652
    <rdar://problem/71517335>

    Reviewed by Antti Koivisto.

    In r269813 we added support for animating more pseudo-elements besides ::after and ::before. However, the only other
    pseudo-element we realistically should be supporting animations for at this juncture is ::marker. So instead of
    calling Style::TreeResolver::resolvePseudoStyle() for all public pseudo-elements, we call it for ::after, ::before
    and ::marker alone.

    * style/StyleTreeResolver.cpp:
    (WebCore::Style::TreeResolver::resolveElement):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-611-branch/Source/WebCore/ChangeLog (272111 => 272112)


--- branches/safari-611-branch/Source/WebCore/ChangeLog	2021-01-30 05:41:34 UTC (rev 272111)
+++ branches/safari-611-branch/Source/WebCore/ChangeLog	2021-01-30 05:41:37 UTC (rev 272112)
@@ -1,5 +1,42 @@
 2021-01-29  Alan Coon  <[email protected]>
 
+        Cherry-pick r271515. rdar://problem/73473627
+
+    REGRESSION(r269813): PLT5 regressed by 0.5%
+    https://bugs.webkit.org/show_bug.cgi?id=220652
+    <rdar://problem/71517335>
+    
+    Reviewed by Antti Koivisto.
+    
+    In r269813 we added support for animating more pseudo-elements besides ::after and ::before. However, the only other
+    pseudo-element we realistically should be supporting animations for at this juncture is ::marker. So instead of
+    calling Style::TreeResolver::resolvePseudoStyle() for all public pseudo-elements, we call it for ::after, ::before
+    and ::marker alone.
+    
+    * style/StyleTreeResolver.cpp:
+    (WebCore::Style::TreeResolver::resolveElement):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-01-15  Antoine Quint  <[email protected]>
+
+            REGRESSION(r269813): PLT5 regressed by 0.5%
+            https://bugs.webkit.org/show_bug.cgi?id=220652
+            <rdar://problem/71517335>
+
+            Reviewed by Antti Koivisto.
+
+            In r269813 we added support for animating more pseudo-elements besides ::after and ::before. However, the only other
+            pseudo-element we realistically should be supporting animations for at this juncture is ::marker. So instead of
+            calling Style::TreeResolver::resolvePseudoStyle() for all public pseudo-elements, we call it for ::after, ::before
+            and ::marker alone.
+
+            * style/StyleTreeResolver.cpp:
+            (WebCore::Style::TreeResolver::resolveElement):
+
+2021-01-29  Alan Coon  <[email protected]>
+
         Cherry-pick r271507. rdar://problem/73473467
 
     [Cocoa] Strip DataDetectors links when copying content to the pasteboard

Modified: branches/safari-611-branch/Source/WebCore/style/StyleTreeResolver.cpp (272111 => 272112)


--- branches/safari-611-branch/Source/WebCore/style/StyleTreeResolver.cpp	2021-01-30 05:41:34 UTC (rev 272111)
+++ branches/safari-611-branch/Source/WebCore/style/StyleTreeResolver.cpp	2021-01-30 05:41:37 UTC (rev 272112)
@@ -249,10 +249,12 @@
     }
 
     PseudoIdToElementUpdateMap pseudoUpdates;
-    for (PseudoId pseudoId = PseudoId::FirstPublicPseudoId; pseudoId < PseudoId::FirstInternalPseudoId; pseudoId = static_cast<PseudoId>(static_cast<unsigned>(pseudoId) + 1)) {
-        if (auto elementUpdate = resolvePseudoStyle(element, update, pseudoId))
-            pseudoUpdates.set(pseudoId, WTFMove(*elementUpdate));
-    }
+    if (auto beforeElementUpdate = resolvePseudoStyle(element, update, PseudoId::Before))
+        pseudoUpdates.set(PseudoId::Before, WTFMove(*beforeElementUpdate));
+    if (auto afterElementUpdate = resolvePseudoStyle(element, update, PseudoId::After))
+        pseudoUpdates.set(PseudoId::After, WTFMove(*afterElementUpdate));
+    if (auto markerElementUpdate = resolvePseudoStyle(element, update, PseudoId::Marker))
+        pseudoUpdates.set(PseudoId::Marker, WTFMove(*markerElementUpdate));
 
 #if ENABLE(TOUCH_ACTION_REGIONS)
     // FIXME: Track this exactly.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to