Title: [272151] branches/safari-611-branch/Source/WebKit
- Revision
- 272151
- Author
- [email protected]
- Date
- 2021-02-01 11:25:07 -0800 (Mon, 01 Feb 2021)
Log Message
Cherry-pick r271916. rdar://problem/73834276
IPC::Decoder constructor should mark the Decoder as invalid if header decoding fails
https://bugs.webkit.org/show_bug.cgi?id=220990
<rdar://problem/64984186>
Reviewed by Darin Adler.
Mark the decoder as invalid if any of the decode operations fail, not just the first one.
* Platform/IPC/Decoder.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-611-branch/Source/WebKit/ChangeLog (272150 => 272151)
--- branches/safari-611-branch/Source/WebKit/ChangeLog 2021-02-01 19:18:50 UTC (rev 272150)
+++ branches/safari-611-branch/Source/WebKit/ChangeLog 2021-02-01 19:25:07 UTC (rev 272151)
@@ -1,3 +1,32 @@
+2021-02-01 Alan Coon <[email protected]>
+
+ Cherry-pick r271916. rdar://problem/73834276
+
+ IPC::Decoder constructor should mark the Decoder as invalid if header decoding fails
+ https://bugs.webkit.org/show_bug.cgi?id=220990
+ <rdar://problem/64984186>
+
+ Reviewed by Darin Adler.
+
+ Mark the decoder as invalid if any of the decode operations fail, not just the first one.
+
+ * Platform/IPC/Decoder.cpp:
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2021-01-26 Brent Fulgham <[email protected]>
+
+ IPC::Decoder constructor should mark the Decoder as invalid if header decoding fails
+ https://bugs.webkit.org/show_bug.cgi?id=220990
+ <rdar://problem/64984186>
+
+ Reviewed by Darin Adler.
+
+ Mark the decoder as invalid if any of the decode operations fail, not just the first one.
+
+ * Platform/IPC/Decoder.cpp:
+
2021-01-29 Alan Coon <[email protected]>
Cherry-pick r271503. rdar://problem/73473503
Modified: branches/safari-611-branch/Source/WebKit/Platform/IPC/Decoder.cpp (272150 => 272151)
--- branches/safari-611-branch/Source/WebKit/Platform/IPC/Decoder.cpp 2021-02-01 19:18:50 UTC (rev 272150)
+++ branches/safari-611-branch/Source/WebKit/Platform/IPC/Decoder.cpp 2021-02-01 19:25:07 UTC (rev 272151)
@@ -64,14 +64,20 @@
return;
}
- if (!decode(m_messageFlags))
+ if (!decode(m_messageFlags)) {
+ markInvalid();
return;
+ }
- if (!decode(m_messageName))
+ if (!decode(m_messageName)) {
+ markInvalid();
return;
+ }
- if (!decode(m_destinationID))
+ if (!decode(m_destinationID)) {
+ markInvalid();
return;
+ }
}
Decoder::Decoder(const uint8_t* buffer, size_t bufferSize, ConstructWithoutHeaderTag)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
