Title: [272156] branches/safari-611-branch/LayoutTests/imported/w3c
Revision
272156
Author
[email protected]
Date
2021-02-01 12:11:36 -0800 (Mon, 01 Feb 2021)

Log Message

Cherry-pick r271611. rdar://problem/73838923

    [ BigSur ] imported/w3c/web-platform-tests/fetch/nosniff/parsing-nosniff.window.html is flaky failing
    https://bugs.webkit.org/show_bug.cgi?id=220631
    <rdar://problem/73212492>

    Reviewed by Alex Christensen.

    I reproduced locally the error and saw a -1005 error, 'The network connection was lost'.
    When running tests sequentially instead of in parallel, I do not see this anymore.

    * web-platform-tests/fetch/nosniff/parsing-nosniff.window.js:
    (runTests):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-611-branch/LayoutTests/imported/w3c/ChangeLog (272155 => 272156)


--- branches/safari-611-branch/LayoutTests/imported/w3c/ChangeLog	2021-02-01 20:11:32 UTC (rev 272155)
+++ branches/safari-611-branch/LayoutTests/imported/w3c/ChangeLog	2021-02-01 20:11:36 UTC (rev 272156)
@@ -1,3 +1,36 @@
+2021-02-01  Alan Coon  <[email protected]>
+
+        Cherry-pick r271611. rdar://problem/73838923
+
+    [ BigSur ] imported/w3c/web-platform-tests/fetch/nosniff/parsing-nosniff.window.html is flaky failing
+    https://bugs.webkit.org/show_bug.cgi?id=220631
+    <rdar://problem/73212492>
+    
+    Reviewed by Alex Christensen.
+    
+    I reproduced locally the error and saw a -1005 error, 'The network connection was lost'.
+    When running tests sequentially instead of in parallel, I do not see this anymore.
+    
+    * web-platform-tests/fetch/nosniff/parsing-nosniff.window.js:
+    (runTests):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-01-19  Youenn Fablet  <[email protected]>
+
+            [ BigSur ] imported/w3c/web-platform-tests/fetch/nosniff/parsing-nosniff.window.html is flaky failing
+            https://bugs.webkit.org/show_bug.cgi?id=220631
+            <rdar://problem/73212492>
+
+            Reviewed by Alex Christensen.
+
+            I reproduced locally the error and saw a -1005 error, 'The network connection was lost'.
+            When running tests sequentially instead of in parallel, I do not see this anymore.
+
+            * web-platform-tests/fetch/nosniff/parsing-nosniff.window.js:
+            (runTests):
+
 2021-01-25  Alan Coon  <[email protected]>
 
         Cherry-pick r271435. rdar://problem/73477090

Modified: branches/safari-611-branch/LayoutTests/imported/w3c/web-platform-tests/fetch/nosniff/parsing-nosniff.window.js (272155 => 272156)


--- branches/safari-611-branch/LayoutTests/imported/w3c/web-platform-tests/fetch/nosniff/parsing-nosniff.window.js	2021-02-01 20:11:32 UTC (rev 272155)
+++ branches/safari-611-branch/LayoutTests/imported/w3c/web-platform-tests/fetch/nosniff/parsing-nosniff.window.js	2021-02-01 20:11:36 UTC (rev 272156)
@@ -4,7 +4,9 @@
   for (let i = 0; i < allTestData.length; i++) {
     const testData = allTestData[i],
           input = encodeURIComponent(testData.input);
-    async_test(t => {
+    promise_test(t => {
+      let resolve;
+      const promise = new Promise(r => resolve = r);
       const script = document.createElement("script");
       t.add_cleanup(() => script.remove());
       // A <script> element loading a classic script does not care about the MIME type, unless
@@ -11,14 +13,15 @@
       // X-Content-Type-Options: nosniff is specified, in which case a _javascript_ MIME type is
       // enforced, which x/x is not.
       if (testData.nosniff) {
-        script._onerror_ = t.step_func_done();
+        script._onerror_ = resolve;
         script._onload_ = t.unreached_func("Script should not have loaded");
       } else {
         script._onerror_ = t.unreached_func("Script should have loaded");
-        script._onload_ = t.step_func_done();
+        script._onload_ = resolve;
       }
       script.src = "" + input;
       document.body.appendChild(script);
+      return promise;
     }, input);
   }
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to