Title: [272185] trunk/Source/WebCore
- Revision
- 272185
- Author
- [email protected]
- Date
- 2021-02-01 18:55:56 -0800 (Mon, 01 Feb 2021)
Log Message
REGRESSION (iOS 14.2): Can't play html audio with muted attribute
https://bugs.webkit.org/show_bug.cgi?id=219295
<rdar://problem/71863148>
Reviewed by Eric Carlson.
In r266844, we added a power-saving feature that would disable the audio decoder for initially
muted media elements. However, this caused an issue for .mp3 files, where the duration of the
track is computed by the decoder, and not the parser. Since the goal of the power-saving feature
was to reduce the CPU cost for decoding a muted audio track on a <video> element, partially
revert this change by making it apply only to <video> elements and not <audio> ones.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (272184 => 272185)
--- trunk/Source/WebCore/ChangeLog 2021-02-02 02:49:59 UTC (rev 272184)
+++ trunk/Source/WebCore/ChangeLog 2021-02-02 02:55:56 UTC (rev 272185)
@@ -1,3 +1,20 @@
+2021-02-01 Jer Noble <[email protected]>
+
+ REGRESSION (iOS 14.2): Can't play html audio with muted attribute
+ https://bugs.webkit.org/show_bug.cgi?id=219295
+ <rdar://problem/71863148>
+
+ Reviewed by Eric Carlson.
+
+ In r266844, we added a power-saving feature that would disable the audio decoder for initially
+ muted media elements. However, this caused an issue for .mp3 files, where the duration of the
+ track is computed by the decoder, and not the parser. Since the goal of the power-saving feature
+ was to reduce the CPU cost for decoding a muted audio track on a <video> element, partially
+ revert this change by making it apply only to <video> elements and not <audio> ones.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
+
2021-02-01 Simon Fraser <[email protected]>
Devirtualize InputType::supportsValidation()
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (272184 => 272185)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2021-02-02 02:49:59 UTC (rev 272184)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2021-02-02 02:55:56 UTC (rev 272185)
@@ -1012,7 +1012,8 @@
[m_avPlayer.get() setMuted:m_muted];
#if HAVE(AVPLAYER_SUPRESSES_AUDIO_RENDERING)
- m_avPlayer.get().suppressesAudioRendering = YES;
+ if (player()->isVideoPlayer())
+ m_avPlayer.get().suppressesAudioRendering = YES;
#endif
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
