Title: [272205] trunk/Source/WebKit
- Revision
- 272205
- Author
- [email protected]
- Date
- 2021-02-02 04:12:03 -0800 (Tue, 02 Feb 2021)
Log Message
Only update IPC connection of RemoteCaptureSampleManager for audio sources
https://bugs.webkit.org/show_bug.cgi?id=221200
Reviewed by Eric Carlson.
There is no need to update the connection for sources that are not added to the RemoteCaptureSampleManager.
* WebProcess/cocoa/UserMediaCaptureManager.cpp:
(WebKit::UserMediaCaptureManager::addSource):
(WebKit::UserMediaCaptureManager::didUpdateSourceConnection):
* WebProcess/cocoa/UserMediaCaptureManager.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (272204 => 272205)
--- trunk/Source/WebKit/ChangeLog 2021-02-02 11:12:14 UTC (rev 272204)
+++ trunk/Source/WebKit/ChangeLog 2021-02-02 12:12:03 UTC (rev 272205)
@@ -1,3 +1,17 @@
+2021-02-02 Youenn Fablet <[email protected]>
+
+ Only update IPC connection of RemoteCaptureSampleManager for audio sources
+ https://bugs.webkit.org/show_bug.cgi?id=221200
+
+ Reviewed by Eric Carlson.
+
+ There is no need to update the connection for sources that are not added to the RemoteCaptureSampleManager.
+
+ * WebProcess/cocoa/UserMediaCaptureManager.cpp:
+ (WebKit::UserMediaCaptureManager::addSource):
+ (WebKit::UserMediaCaptureManager::didUpdateSourceConnection):
+ * WebProcess/cocoa/UserMediaCaptureManager.h:
+
2021-02-02 Antoine Quint <[email protected]>
WKASCAuthorizationPresenterDelegate needs to import RunLoop.h and BlockPtr.h
Modified: trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp (272204 => 272205)
--- trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp 2021-02-02 11:12:14 UTC (rev 272204)
+++ trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp 2021-02-02 12:12:03 UTC (rev 272205)
@@ -88,7 +88,7 @@
void UserMediaCaptureManager::addSource(Ref<RemoteRealtimeMediaSource>&& source)
{
if (source->type() == RealtimeMediaSource::Type::Audio)
- m_remoteCaptureSampleManager.addSource(source.copyRef());
+ m_remoteAudioCaptureSampleManager.addSource(source.copyRef());
auto identifier = source->identifier();
ASSERT(!m_sources.contains(identifier));
@@ -196,7 +196,8 @@
void UserMediaCaptureManager::didUpdateSourceConnection(RemoteRealtimeMediaSource& source)
{
- m_remoteCaptureSampleManager.didUpdateSourceConnection(source);
+ if (source.type() == RealtimeMediaSource::Type::Audio)
+ m_remoteAudioCaptureSampleManager.didUpdateSourceConnection(source);
}
}
Modified: trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.h (272204 => 272205)
--- trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.h 2021-02-02 11:12:14 UTC (rev 272204)
+++ trunk/Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.h 2021-02-02 12:12:03 UTC (rev 272205)
@@ -137,7 +137,7 @@
AudioFactory m_audioFactory;
VideoFactory m_videoFactory;
DisplayFactory m_displayFactory;
- RemoteCaptureSampleManager m_remoteCaptureSampleManager;
+ RemoteCaptureSampleManager m_remoteAudioCaptureSampleManager;
};
} // namespace WebKit
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
