Title: [272218] trunk/Source/WebCore
Revision
272218
Author
[email protected]
Date
2021-02-02 10:13:59 -0800 (Tue, 02 Feb 2021)

Log Message

Promote debug assertion to release assertion in cookiesForURL()
https://bugs.webkit.org/show_bug.cgi?id=221268

Reviewed by Alex Christensen.

Promote debug assertion to release assertion in cookiesForURL(). We have a weird/rare crash in this
area and I want to rule out that this is not what is happening.

* platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::cookiesForURL):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (272217 => 272218)


--- trunk/Source/WebCore/ChangeLog	2021-02-02 18:10:39 UTC (rev 272217)
+++ trunk/Source/WebCore/ChangeLog	2021-02-02 18:13:59 UTC (rev 272218)
@@ -1,3 +1,16 @@
+2021-02-02  Chris Dumez  <[email protected]>
+
+        Promote debug assertion to release assertion in cookiesForURL()
+        https://bugs.webkit.org/show_bug.cgi?id=221268
+
+        Reviewed by Alex Christensen.
+
+        Promote debug assertion to release assertion in cookiesForURL(). We have a weird/rare crash in this
+        area and I want to rule out that this is not what is happening.
+
+        * platform/network/cocoa/NetworkStorageSessionCocoa.mm:
+        (WebCore::cookiesForURL):
+
 2021-02-02  Rini Patel  <[email protected]>
 
         Remove unused functions from GraphicsContextGL and ExtensionsGL

Modified: trunk/Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm (272217 => 272218)


--- trunk/Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm	2021-02-02 18:10:39 UTC (rev 272217)
+++ trunk/Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm	2021-02-02 18:13:59 UTC (rev 272218)
@@ -266,7 +266,7 @@
     [storage _getCookiesForURL:url mainDocumentURL:mainDocumentURL partition:partition completionHandler:completionHandler];
     UNUSED_PARAM(sameSiteInfo);
 #endif
-    ASSERT(!!cookiesPtr);
+    RELEASE_ASSERT(!!cookiesPtr);
     return WTFMove(*cookiesPtr);
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to