Title: [272224] trunk/Source/WebCore
- Revision
- 272224
- Author
- [email protected]
- Date
- 2021-02-02 10:59:48 -0800 (Tue, 02 Feb 2021)
Log Message
REGRESSION (r271219): [Mojave] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_timeupdate_on_seek.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=220447
<rdar://problem/72910551>
Reviewed by Eric Carlson.
Changing the pitch algorithm in the handler for playerItemStatusDidChange() causes problems on the Mojave test bots
where the media element never reaches the `canplay` state. Back out the change from r271219 only on Mojave.
* WebCore.xcodeproj/project.pbxproj:
* page/Quirks.cpp:
(WebCore::Quirks::needsPerDocumentAutoplayBehavior const):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatusDidChange):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (272223 => 272224)
--- trunk/Source/WebCore/ChangeLog 2021-02-02 18:56:10 UTC (rev 272223)
+++ trunk/Source/WebCore/ChangeLog 2021-02-02 18:59:48 UTC (rev 272224)
@@ -1,3 +1,20 @@
+2021-02-02 Jer Noble <[email protected]>
+
+ REGRESSION (r271219): [Mojave] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_timeupdate_on_seek.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=220447
+ <rdar://problem/72910551>
+
+ Reviewed by Eric Carlson.
+
+ Changing the pitch algorithm in the handler for playerItemStatusDidChange() causes problems on the Mojave test bots
+ where the media element never reaches the `canplay` state. Back out the change from r271219 only on Mojave.
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * page/Quirks.cpp:
+ (WebCore::Quirks::needsPerDocumentAutoplayBehavior const):
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatusDidChange):
+
2021-02-02 Zalan Bujtas <[email protected]>
[LFC][Integration] Disable inline-box content with non-initial line-box-contain values
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (272223 => 272224)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2021-02-02 18:56:10 UTC (rev 272223)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2021-02-02 18:59:48 UTC (rev 272224)
@@ -2975,9 +2975,13 @@
{
m_cachedItemStatus = status;
+ // Setting the pitch algorithm here causes tests to fail on Mojave; revert this change
+ // for <= Mojave builds.
+#if !(PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED > 101400)
// FIXME(rdar://72829354): Remove after AVFoundation radar is fixed.
if (status == AVPlayerItemStatusReadyToPlay)
[m_avPlayerItem setAudioTimePitchAlgorithm:audioTimePitchAlgorithmForMediaPlayerPitchCorrectionAlgorithm(player()->pitchCorrectionAlgorithm(), player()->preservesPitch())];
+#endif
updateStates();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
