Title: [272263] branches/safari-611-branch/Source/WebKit
Revision
272263
Author
[email protected]
Date
2021-02-02 17:40:15 -0800 (Tue, 02 Feb 2021)

Log Message

Cherry-pick r271895. rdar://problem/73890430

    REGRESSION(r261238): WKWebView crashes on launch inside a quicklook preview
    https://bugs.webkit.org/show_bug.cgi?id=219632
    <rdar://problem/72154830>

    Reviewed by Alexey Proskuryakov.

    Partially revert r261238 to allow applications without access to 'nsurlsessiond' to still
    be able to use WebKit for local file access. This workaround should be removed once we
    complete the work needed to support true offline WebKit use.

    * Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:
    (WebKit::XPCServiceInitializerDelegate::checkEntitlements): Add an early return if the application
    possesses the 'com.apple.security.network.client' entitlement.

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-611-branch/Source/WebKit/ChangeLog (272262 => 272263)


--- branches/safari-611-branch/Source/WebKit/ChangeLog	2021-02-03 01:40:13 UTC (rev 272262)
+++ branches/safari-611-branch/Source/WebKit/ChangeLog	2021-02-03 01:40:15 UTC (rev 272263)
@@ -1,5 +1,42 @@
 2021-02-02  Alan Coon  <[email protected]>
 
+        Cherry-pick r271895. rdar://problem/73890430
+
+    REGRESSION(r261238): WKWebView crashes on launch inside a quicklook preview
+    https://bugs.webkit.org/show_bug.cgi?id=219632
+    <rdar://problem/72154830>
+    
+    Reviewed by Alexey Proskuryakov.
+    
+    Partially revert r261238 to allow applications without access to 'nsurlsessiond' to still
+    be able to use WebKit for local file access. This workaround should be removed once we
+    complete the work needed to support true offline WebKit use.
+    
+    * Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:
+    (WebKit::XPCServiceInitializerDelegate::checkEntitlements): Add an early return if the application
+    possesses the 'com.apple.security.network.client' entitlement.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-01-26  Brent Fulgham  <[email protected]>
+
+            REGRESSION(r261238): WKWebView crashes on launch inside a quicklook preview
+            https://bugs.webkit.org/show_bug.cgi?id=219632
+            <rdar://problem/72154830>
+
+            Reviewed by Alexey Proskuryakov.
+
+            Partially revert r261238 to allow applications without access to 'nsurlsessiond' to still
+            be able to use WebKit for local file access. This workaround should be removed once we
+            complete the work needed to support true offline WebKit use.
+
+            * Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:
+            (WebKit::XPCServiceInitializerDelegate::checkEntitlements): Add an early return if the application
+            possesses the 'com.apple.security.network.client' entitlement.
+
+2021-02-02  Alan Coon  <[email protected]>
+
         Cherry-pick r271890. rdar://problem/73890942
 
     [CoreIPC] Add size check in decodeSharedBuffer to allow it to be validated against the SharedMemory received

Modified: branches/safari-611-branch/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm (272262 => 272263)


--- branches/safari-611-branch/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm	2021-02-03 01:40:13 UTC (rev 272262)
+++ branches/safari-611-branch/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm	2021-02-03 01:40:15 UTC (rev 272263)
@@ -43,6 +43,10 @@
 {
 #if PLATFORM(MAC) || PLATFORM(MACCATALYST)
     if (isClientSandboxed()) {
+        // FIXME(<rdar://problem/54178641>): Remove this check once WebKit can work without network access.
+        if (hasEntitlement("com.apple.security.network.client"))
+            return true;
+
         audit_token_t auditToken = { };
         xpc_connection_get_audit_token(m_connection.get(), &auditToken);
         if (auto rc = sandbox_check_by_audit_token(auditToken, "mach-lookup", static_cast<enum sandbox_filter_type>(SANDBOX_FILTER_GLOBAL_NAME | SANDBOX_CHECK_NO_REPORT), "com.apple.nsurlsessiond")) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to