Title: [272304] trunk
Revision
272304
Author
[email protected]
Date
2021-02-03 02:34:39 -0800 (Wed, 03 Feb 2021)

Log Message

Enable webrtc video capture in GPUProcess for iOS WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=220966

Reviewed by Eric Carlson.

Tools:

* WebKitTestRunner/TestOptions.cpp:

LayoutTests:

Disable capture in GPUProcess for now in these tests as:
- SpeechRecognition in GPUProcess needs some work
- Internals API in platform/ios/mediastream/video-muted-in-background-tab.html are not supported with GPUProcess.

* fast/speechrecognition/ios/audio-capture.html:
* fast/speechrecognition/ios/restart-recognition-after-stop.html:
* fast/speechrecognition/ios/start-recognition-then-stop.html:
* platform/ios/mediastream/video-muted-in-background-tab.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (272303 => 272304)


--- trunk/LayoutTests/ChangeLog	2021-02-03 09:44:05 UTC (rev 272303)
+++ trunk/LayoutTests/ChangeLog	2021-02-03 10:34:39 UTC (rev 272304)
@@ -1,3 +1,19 @@
+2021-02-03  Youenn Fablet  <[email protected]>
+
+        Enable webrtc video capture in GPUProcess for iOS WebKitTestRunner
+        https://bugs.webkit.org/show_bug.cgi?id=220966
+
+        Reviewed by Eric Carlson.
+
+        Disable capture in GPUProcess for now in these tests as:
+        - SpeechRecognition in GPUProcess needs some work
+        - Internals API in platform/ios/mediastream/video-muted-in-background-tab.html are not supported with GPUProcess.
+
+        * fast/speechrecognition/ios/audio-capture.html:
+        * fast/speechrecognition/ios/restart-recognition-after-stop.html:
+        * fast/speechrecognition/ios/start-recognition-then-stop.html:
+        * platform/ios/mediastream/video-muted-in-background-tab.html:
+
 2021-02-02  Lauro Moura  <[email protected]>
 
         [GLIB] Gardening debug timeouts

Modified: trunk/LayoutTests/fast/speechrecognition/ios/audio-capture.html (272303 => 272304)


--- trunk/LayoutTests/fast/speechrecognition/ios/audio-capture.html	2021-02-03 09:44:05 UTC (rev 272303)
+++ trunk/LayoutTests/fast/speechrecognition/ios/audio-capture.html	2021-02-03 10:34:39 UTC (rev 272304)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ CaptureAudioInGPUProcessEnabled=false ] -->
 <html>
 <body>
 <script src=""
@@ -25,4 +25,4 @@
 
 </script>
 </body>
-</html>
\ No newline at end of file
+</html>

Modified: trunk/LayoutTests/fast/speechrecognition/ios/restart-recognition-after-stop.html (272303 => 272304)


--- trunk/LayoutTests/fast/speechrecognition/ios/restart-recognition-after-stop.html	2021-02-03 09:44:05 UTC (rev 272303)
+++ trunk/LayoutTests/fast/speechrecognition/ios/restart-recognition-after-stop.html	2021-02-03 10:34:39 UTC (rev 272304)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ CaptureAudioInGPUProcessEnabled=false ] -->
 <html>
 <body>
 <script src=""
@@ -43,4 +43,4 @@
 
 </script>
 </body>
-</html>
\ No newline at end of file
+</html>

Modified: trunk/LayoutTests/fast/speechrecognition/ios/start-recognition-then-stop.html (272303 => 272304)


--- trunk/LayoutTests/fast/speechrecognition/ios/start-recognition-then-stop.html	2021-02-03 09:44:05 UTC (rev 272303)
+++ trunk/LayoutTests/fast/speechrecognition/ios/start-recognition-then-stop.html	2021-02-03 10:34:39 UTC (rev 272304)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html><!-- webkit-test-runner [ CaptureAudioInGPUProcessEnabled=false ] -->
 <html>
 <body>
 <script src=""
@@ -59,4 +59,4 @@
 
 </script>
 </body>
-</html>
\ No newline at end of file
+</html>

Modified: trunk/LayoutTests/platform/ios/mediastream/video-muted-in-background-tab.html (272303 => 272304)


--- trunk/LayoutTests/platform/ios/mediastream/video-muted-in-background-tab.html	2021-02-03 09:44:05 UTC (rev 272303)
+++ trunk/LayoutTests/platform/ios/mediastream/video-muted-in-background-tab.html	2021-02-03 10:34:39 UTC (rev 272304)
@@ -1,5 +1,4 @@
-
-<!doctype html>
+<!DOCTYPE html><!-- webkit-test-runner [ CaptureAudioInGPUProcessEnabled=false CaptureVideoInGPUProcessEnabled=false ] -->
 <html>
     <head>
         <meta charset="utf-8">

Modified: trunk/Tools/ChangeLog (272303 => 272304)


--- trunk/Tools/ChangeLog	2021-02-03 09:44:05 UTC (rev 272303)
+++ trunk/Tools/ChangeLog	2021-02-03 10:34:39 UTC (rev 272304)
@@ -1,3 +1,12 @@
+2021-02-03  Youenn Fablet  <[email protected]>
+
+        Enable webrtc video capture in GPUProcess for iOS WebKitTestRunner
+        https://bugs.webkit.org/show_bug.cgi?id=220966
+
+        Reviewed by Eric Carlson.
+
+        * WebKitTestRunner/TestOptions.cpp:
+
 2021-02-02  Ryan Haddad  <[email protected]>
 
         Update Test262 bot to Big Sur

Modified: trunk/Tools/WebKitTestRunner/TestOptions.cpp (272303 => 272304)


--- trunk/Tools/WebKitTestRunner/TestOptions.cpp	2021-02-03 09:44:05 UTC (rev 272303)
+++ trunk/Tools/WebKitTestRunner/TestOptions.cpp	2021-02-03 10:34:39 UTC (rev 272304)
@@ -31,7 +31,7 @@
 
 namespace WTR {
 
-#if PLATFORM(MAC)
+#if PLATFORM(COCOA)
 static constexpr bool captureAudioInGPUProcessEnabledValue = true;
 static constexpr bool captureVideoInGPUProcessEnabledValue = true;
 #else
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to