Title: [272335] trunk/Source/WebKit
Revision
272335
Author
timothy_hor...@apple.com
Date
2021-02-03 12:32:22 -0800 (Wed, 03 Feb 2021)

Log Message

REGRESSION (r270392): Launch time regression under IOSurface::maximumSize()
https://bugs.webkit.org/show_bug.cgi?id=221346
<rdar://problem/73507706>

Reviewed by Sam Weinig.

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
Scope r270392 to only the case where it is needed, when DOM rendering in the GPU process
is enabled and the Web Content process does not have access to IOSurface,
because it causes a small launch time regression.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (272334 => 272335)


--- trunk/Source/WebKit/ChangeLog	2021-02-03 20:27:31 UTC (rev 272334)
+++ trunk/Source/WebKit/ChangeLog	2021-02-03 20:32:22 UTC (rev 272335)
@@ -1,3 +1,17 @@
+2021-02-03  Tim Horton  <timothy_hor...@apple.com>
+
+        REGRESSION (r270392): Launch time regression under IOSurface::maximumSize()
+        https://bugs.webkit.org/show_bug.cgi?id=221346
+        <rdar://problem/73507706>
+
+        Reviewed by Sam Weinig.
+
+        * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+        (WebKit::WebProcessPool::platformInitializeWebProcess):
+        Scope r270392 to only the case where it is needed, when DOM rendering in the GPU process
+        is enabled and the Web Content process does not have access to IOSurface,
+        because it causes a small launch time regression.
+
 2021-02-03  Aditya Keerthi  <akeer...@apple.com>
 
         [iOS][FCR] Add new picker for select elements

Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (272334 => 272335)


--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2021-02-03 20:27:31 UTC (rev 272334)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2021-02-03 20:32:22 UTC (rev 272335)
@@ -471,7 +471,10 @@
     parameters.hasStylusDevice = [[WKStylusDeviceObserver sharedInstance] hasStylusDevice];
 #endif
 
-    parameters.maximumIOSurfaceSize = WebCore::IOSurface::maximumSize();
+    // If we're using the GPU process for DOM rendering, we can't query the maximum IOSurface size in the Web Content process.
+    // However, querying this is a launch time regression, so limit this to only the necessary case.
+    if (m_defaultPageGroup->preferences().useGPUProcessForDOMRenderingEnabled())
+        parameters.maximumIOSurfaceSize = WebCore::IOSurface::maximumSize();
 }
 
 void WebProcessPool::platformInitializeNetworkProcess(NetworkProcessCreationParameters& parameters)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to