Title: [272355] trunk/Source/WebKit
Revision
272355
Author
timothy_hor...@apple.com
Date
2021-02-03 20:43:29 -0800 (Wed, 03 Feb 2021)

Log Message

ASSERTION FAILED: !size.isEmpty() under platformInitializeWebProcess

* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
Follow-up to r272335; don't call IOSurface::setMaximumSize if the UI process
did not send us a size. Caused all Web Content processes to assert in debug on launch.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (272354 => 272355)


--- trunk/Source/WebKit/ChangeLog	2021-02-04 04:09:26 UTC (rev 272354)
+++ trunk/Source/WebKit/ChangeLog	2021-02-04 04:43:29 UTC (rev 272355)
@@ -1,3 +1,12 @@
+2021-02-03  Timothy Horton  <timothy_hor...@apple.com>
+
+        ASSERTION FAILED: !size.isEmpty() under platformInitializeWebProcess
+
+        * WebProcess/cocoa/WebProcessCocoa.mm:
+        (WebKit::WebProcess::platformInitializeWebProcess):
+        Follow-up to r272335; don't call IOSurface::setMaximumSize if the UI process
+        did not send us a size. Caused all Web Content processes to assert in debug on launch.
+
 2021-02-03  Jer Noble  <jer.no...@apple.com>
 
         [Cocoa] WebM audio goes out-of-sync or stops playing after a seek

Modified: trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (272354 => 272355)


--- trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2021-02-04 04:09:26 UTC (rev 272354)
+++ trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2021-02-04 04:43:29 UTC (rev 272355)
@@ -417,7 +417,8 @@
         softLink_HIServices__AXSetAuditTokenIsAuthenticatedCallback(isAXAuthenticatedCallback);
 #endif
     
-    WebCore::IOSurface::setMaximumSize(parameters.maximumIOSurfaceSize);
+    if (!parameters.maximumIOSurfaceSize.isEmpty())
+        WebCore::IOSurface::setMaximumSize(parameters.maximumIOSurfaceSize);
 }
 
 void WebProcess::platformSetWebsiteDataStoreParameters(WebProcessDataStoreParameters&& parameters)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to