Title: [272413] trunk/Source/ThirdParty/libwebrtc
Revision
272413
Author
[email protected]
Date
2021-02-05 07:11:44 -0800 (Fri, 05 Feb 2021)

Log Message

[CMake] Hide libwebrtc symbols
https://bugs.webkit.org/show_bug.cgi?id=221333

This is a naive approach to hide libwebrtc symbols, particularly beacuse of boringssl, which
migth collide with system's libssl. It compiles libwebrtc with visibility set to hidden.

Patch by Víctor Manuel Jáquez Leal <[email protected]> on 2021-02-05
Reviewed by Michael Catanzaro.

* CMakeLists.txt:

Modified Paths

Diff

Modified: trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt (272412 => 272413)


--- trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt	2021-02-05 14:29:23 UTC (rev 272412)
+++ trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt	2021-02-05 15:11:44 UTC (rev 272413)
@@ -1426,6 +1426,9 @@
     "-w"
 )
 
+set_target_properties(webrtc PROPERTIES CXX_VISIBILITY_PRESET hidden)
+set_target_properties(webrtc PROPERTIES C_VISIBILITY_PRESET hidden)
+
 target_compile_definitions(webrtc PRIVATE
   OPENSSL_NO_ASM
   DISABLE_H265
@@ -1433,7 +1436,7 @@
   EXPAT_RELATIVE_PATH
   HAVE_LRINT
   HAVE_LRINTF
-  HAVE_NETINET_IN_H 
+  HAVE_NETINET_IN_H
   HAVE_SCTP
   HAVE_WEBRTC_VIDEO
   HAVE_WEBRTC_VOICE

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (272412 => 272413)


--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2021-02-05 14:29:23 UTC (rev 272412)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2021-02-05 15:11:44 UTC (rev 272413)
@@ -1,3 +1,15 @@
+2021-02-05  Víctor Manuel Jáquez Leal  <[email protected]>
+
+        [CMake] Hide libwebrtc symbols
+        https://bugs.webkit.org/show_bug.cgi?id=221333
+
+        This is a naive approach to hide libwebrtc symbols, particularly beacuse of boringssl, which
+        migth collide with system's libssl. It compiles libwebrtc with visibility set to hidden.
+
+        Reviewed by Michael Catanzaro.
+
+        * CMakeLists.txt:
+
 2021-02-02  Youenn Fablet  <[email protected]>
 
         Update WebRTC usrsctp to M88
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to