Title: [272429] trunk/Source/WebCore
- Revision
- 272429
- Author
- [email protected]
- Date
- 2021-02-05 10:59:01 -0800 (Fri, 05 Feb 2021)
Log Message
[GPUProcess] If the GPUProcess crashes during fullscreen playback, video pauses and exits fullscreen
https://bugs.webkit.org/show_bug.cgi?id=221485
Reviewed by Eric Carlson.
If the GPUProcess crashed during fullscreen playback, video would pause and exit fullscreen. This was suboptimal.
The video now just resumes playing while in fullscreen, just like we do when inline.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerReloadAndResumePlaybackIfNeeded):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (272428 => 272429)
--- trunk/Source/WebCore/ChangeLog 2021-02-05 18:58:06 UTC (rev 272428)
+++ trunk/Source/WebCore/ChangeLog 2021-02-05 18:59:01 UTC (rev 272429)
@@ -1,3 +1,16 @@
+2021-02-05 Chris Dumez <[email protected]>
+
+ [GPUProcess] If the GPUProcess crashes during fullscreen playback, video pauses and exits fullscreen
+ https://bugs.webkit.org/show_bug.cgi?id=221485
+
+ Reviewed by Eric Carlson.
+
+ If the GPUProcess crashed during fullscreen playback, video would pause and exit fullscreen. This was suboptimal.
+ The video now just resumes playing while in fullscreen, just like we do when inline.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::mediaPlayerReloadAndResumePlaybackIfNeeded):
+
2021-02-05 Youenn Fablet <[email protected]>
Make sure click attribution is processed in case of redirected kept alive loads
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (272428 => 272429)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2021-02-05 18:58:06 UTC (rev 272428)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2021-02-05 18:59:01 UTC (rev 272429)
@@ -1205,9 +1205,8 @@
load();
- // FIXME: It would be even better if we could resume in full screen mode, but, for now, exiting full screen makes the video rendering work.
if (m_videoFullscreenMode != VideoFullscreenModeNone)
- exitFullscreen();
+ enterFullscreen(m_videoFullscreenMode);
if (previousMediaTime) {
m_resourceSelectionTaskQueue.enqueueTask([this, previousMediaTime] {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
