Title: [272457] trunk
- Revision
- 272457
- Author
- [email protected]
- Date
- 2021-02-05 21:09:47 -0800 (Fri, 05 Feb 2021)
Log Message
[MSVC] Catalog warnings
https://bugs.webkit.org/show_bug.cgi?id=199248
Reviewed by Fujii Hironori.
Catalog all the MSVC warnings providing the message and a link to documentation
for the warning. Some warnings are noted as being against the style guide so they
won't be addressed. All other warnings could potentially be fixed in the codebase.
* Source/cmake/OptionsMSVC.cmake:
Modified Paths
Diff
Modified: trunk/ChangeLog (272456 => 272457)
--- trunk/ChangeLog 2021-02-06 04:06:30 UTC (rev 272456)
+++ trunk/ChangeLog 2021-02-06 05:09:47 UTC (rev 272457)
@@ -1,3 +1,16 @@
+2021-02-05 Don Olmstead <[email protected]>
+
+ [MSVC] Catalog warnings
+ https://bugs.webkit.org/show_bug.cgi?id=199248
+
+ Reviewed by Fujii Hironori.
+
+ Catalog all the MSVC warnings providing the message and a link to documentation
+ for the warning. Some warnings are noted as being against the style guide so they
+ won't be addressed. All other warnings could potentially be fixed in the codebase.
+
+ * Source/cmake/OptionsMSVC.cmake:
+
2021-02-04 Adrian Perez de Castro <[email protected]>
Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.31.1 release
Modified: trunk/Source/cmake/OptionsMSVC.cmake (272456 => 272457)
--- trunk/Source/cmake/OptionsMSVC.cmake 2021-02-06 04:06:30 UTC (rev 272456)
+++ trunk/Source/cmake/OptionsMSVC.cmake 2021-02-06 05:09:47 UTC (rev 272457)
@@ -1,10 +1,105 @@
+# List of disabled warnings
+# When adding to the list add a short description and link to the warning's text if available
+#
+# https://bugs.webkit.org/show_bug.cgi?id=221508 is for tracking removal of warnings
add_compile_options(
- /wd4018 /wd4068 /wd4099 /wd4100 /wd4127 /wd4138 /wd4146 /wd4180 /wd4189
- /wd4201 /wd4206 /wd4244 /wd4251 /wd4267 /wd4275 /wd4288 /wd4291 /wd4305
- /wd4309 /wd4344 /wd4355 /wd4389 /wd4396 /wd4456 /wd4457 /wd4458 /wd4459
- /wd4481 /wd4503 /wd4505 /wd4510 /wd4512 /wd4530 /wd4610 /wd4611 /wd4646
- /wd4702 /wd4706 /wd4722 /wd4800 /wd4819 /wd4951 /wd4952 /wd4996 /wd6011
- /wd6031 /wd6211 /wd6246 /wd6255 /wd6387 /wd4091
+ /wd4018 # 'token' : signed/unsigned mismatch
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4018
+
+ /wd4060 # switch statement contains no 'case' or 'default' labels
+
+ /wd4068 # unknown pragma
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4068
+
+ /wd4100 # 'identifier' : unreferenced formal parameter
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4100
+
+ /wd4127 # conditional _expression_ is constant
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4127
+
+ /wd4146 # unary minus operator applied to unsigned type, result still unsigned
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-2-c4146
+
+ /wd4189 # 'identifier' : local variable is initialized but not referenced
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4189
+
+ /wd4201 # nonstandard extension used : nameless struct/union
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4201
+
+ /wd4244 # 'argument' : conversion from 'type1' to 'type2', possible loss of data
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-2-c4244
+
+ /wd4245 # 'conversion' : conversion from 'type1' to 'type2', signed/unsigned mismatch
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4245
+
+ /wd4251 # 'identifier' : class 'type' needs to have dll-interface to be used by clients of class 'type2'
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4251
+
+ /wd4275 # non - DLL-interface class 'class_1' used as base for DLL-interface class 'class_2'
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-2-c4275
+
+ /wd4267 # 'var' : conversion from 'size_t' to 'type', possible loss of data
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4267
+
+ /wd4305 # 'context' : truncation from 'type1' to 'type2'
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4305
+
+ /wd4312 # 'operation' : conversion from 'type1' to 'type2' of greater size
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4312
+
+ /wd4324 # 'struct_name' : structure was padded due to __declspec(align())
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4324
+
+ /wd4389 # 'operator' : signed/unsigned mismatch
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4389
+
+ /wd4456 # declaration of 'identifier' hides previous local declaration
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4456
+
+ /wd4457 # declaration of 'identifier' hides function parameter
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4457
+
+ /wd4458 # declaration of 'identifier' hides class member
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4458
+
+ /wd4459 # declaration of 'identifier' hides global declaration
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4459
+
+ /wd4505 # 'function' : unreferenced local function has been removed
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4505
+
+
+ /wd4611 # interaction between 'function' and C++ object destruction is non-portable
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4611
+
+ /wd4646 # function declared with __declspec(noreturn) has non-void return type
+ # https://docs.microsoft.com/mt-mt/cpp/error-messages/compiler-warnings/compiler-warning-level-3-c4646
+
+ /wd4701 # Potentially uninitialized local variable 'name' used
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4701
+
+ /wd4702 # unreachable code
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4702
+
+ /wd4706 # assignment within conditional _expression_
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4706
+ # NOTE: Can't fix without changes to style guide
+
+ /wd4715 # 'function' : not all control paths return a value
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4715
+
+ /wd4722 # 'function' : destructor never returns, potential memory leak
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4722
+
+ /wd4838 # conversion from 'type_1' to 'type_2' requires a narrowing conversion
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4838
+
+ /wd4840 # non-portable use of class 'type' as an argument to a variadic function
+ # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4840
+
+ /wd4996 # Your code uses a function, class member, variable, or typedef that's marked deprecated
+
+ /wd5205 # delete of an abstract class 'type-name' that has a non-virtual destructor results in undefined behavior
)
# Create pdb files for debugging purposes, also for Release builds
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
