Title: [272479] trunk
- Revision
- 272479
- Author
- [email protected]
- Date
- 2021-02-07 20:18:03 -0800 (Sun, 07 Feb 2021)
Log Message
REGRESSION(r272379) [WPE] imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant tests are Image Failing
https://bugs.webkit.org/show_bug.cgi?id=221523
Reviewed by Adrian Perez de Castro.
Source/WebCore:
Covered by existing tests.
This change makes the mathml tests pass again, but still does not
fixes fast/text/multi-code-unit-simple-path.html, which is still not
mismatching on both GTK/WPE.
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advanceInternal): Avoid inserting the
trailing zero for GLIB.
LayoutTests:
* platform/wpe/TestExpectations: Remove expected failures
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (272478 => 272479)
--- trunk/LayoutTests/ChangeLog 2021-02-08 02:11:42 UTC (rev 272478)
+++ trunk/LayoutTests/ChangeLog 2021-02-08 04:18:03 UTC (rev 272479)
@@ -1,3 +1,12 @@
+2021-02-07 Lauro Moura <[email protected]>
+
+ REGRESSION(r272379) [WPE] imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant tests are Image Failing
+ https://bugs.webkit.org/show_bug.cgi?id=221523
+
+ Reviewed by Adrian Perez de Castro.
+
+ * platform/wpe/TestExpectations: Remove expected failures
+
2021-02-07 Zalan Bujtas <[email protected]>
[LFC][IFC] ASSERT(constraints.left->x <= constraints.right->x) when left and right floats run out of space
Modified: trunk/LayoutTests/platform/wpe/TestExpectations (272478 => 272479)
--- trunk/LayoutTests/platform/wpe/TestExpectations 2021-02-08 02:11:42 UTC (rev 272478)
+++ trunk/LayoutTests/platform/wpe/TestExpectations 2021-02-08 04:18:03 UTC (rev 272479)
@@ -207,25 +207,6 @@
# SVG
webkit.org/b/220614 imported/w3c/web-platform-tests/svg/linking/reftests/url-reference-local-textpath.svg [ Failure Pass ]
-# Text
-webkit.org/b/221523 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-bold-fraktur.html [ ImageOnlyFailure ]
-webkit.org/b/221523 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-bold-italic.html [ ImageOnlyFailure ]
-webkit.org/b/221523 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-bold-sans-serif.html [ ImageOnlyFailure ]
-webkit.org/b/221523 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-bold-script.html [ ImageOnlyFailure ]
-webkit.org/b/221523 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-bold.html [ ImageOnlyFailure ]
-webkit.org/b/221523 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-double-struck.html [ ImageOnlyFailure ]
-webkit.org/b/221523 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-fraktur.html [ ImageOnlyFailure ]
-webkit.org/b/221523 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-initial.html [ ImageOnlyFailure ]
-webkit.org/b/221523 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-italic.html [ ImageOnlyFailure ]
-webkit.org/b/221523 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-looped.html [ ImageOnlyFailure ]
-webkit.org/b/221523 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-monospace.html [ ImageOnlyFailure ]
-webkit.org/b/221523 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-bold-italic.html [ ImageOnlyFailure ]
-webkit.org/b/221523 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-italic.html [ ImageOnlyFailure ]
-webkit.org/b/221523 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif.html [ ImageOnlyFailure ]
-webkit.org/b/221523 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-script.html [ ImageOnlyFailure ]
-webkit.org/b/221523 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-stretched.html [ ImageOnlyFailure ]
-webkit.org/b/221523 imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-tailed.html [ ImageOnlyFailure ]
-
# WebGL
webkit.org/b/213203 webgl/1.0.3/conformance/rendering/multisample-corruption.html [ Failure Timeout ]
webkit.org/b/220720 fast/canvas/webgl/oes-vertex-array-object.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (272478 => 272479)
--- trunk/Source/WebCore/ChangeLog 2021-02-08 02:11:42 UTC (rev 272478)
+++ trunk/Source/WebCore/ChangeLog 2021-02-08 04:18:03 UTC (rev 272479)
@@ -1,3 +1,20 @@
+2021-02-07 Lauro Moura <[email protected]>
+
+ REGRESSION(r272379) [WPE] imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant tests are Image Failing
+ https://bugs.webkit.org/show_bug.cgi?id=221523
+
+ Reviewed by Adrian Perez de Castro.
+
+ Covered by existing tests.
+
+ This change makes the mathml tests pass again, but still does not
+ fixes fast/text/multi-code-unit-simple-path.html, which is still not
+ mismatching on both GTK/WPE.
+
+ * platform/graphics/WidthIterator.cpp:
+ (WebCore::WidthIterator::advanceInternal): Avoid inserting the
+ trailing zero for GLIB.
+
2021-02-07 Zalan Bujtas <[email protected]>
[LFC][IFC] ASSERT(constraints.left->x <= constraints.right->x) when left and right floats run out of space
Modified: trunk/Source/WebCore/platform/graphics/WidthIterator.cpp (272478 => 272479)
--- trunk/Source/WebCore/platform/graphics/WidthIterator.cpp 2021-02-08 02:11:42 UTC (rev 272478)
+++ trunk/Source/WebCore/platform/graphics/WidthIterator.cpp 2021-02-08 04:18:03 UTC (rev 272479)
@@ -262,7 +262,7 @@
glyph = 0;
glyphBuffer.add(glyph, *font, width, currentCharacterIndex);
-#if !PLATFORM(COCOA) || USE(CTFONTSHAPEGLYPHS)
+#if (!PLATFORM(COCOA) && !USE(GLIB)) || USE(CTFONTSHAPEGLYPHS)
// These 0 glyphs are needed by shapers if the source text has surrogate pairs.
// However, CTFontTransformGlyphs() can't delete these 0 glyphs from the shaped text,
// so we shouldn't add them in the first place if we're using that shaping routine.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
