Title: [272491] trunk/Source/WebCore
- Revision
- 272491
- Author
- [email protected]
- Date
- 2021-02-08 08:14:32 -0800 (Mon, 08 Feb 2021)
Log Message
Fix WebXRWebGLLayer m_isCompositionDisabled checks
https://bugs.webkit.org/show_bug.cgi?id=221551
Patch by Imanol Fernandez <[email protected]> on 2021-02-08
Reviewed by Sergio Villar Senin.
Fix reversed m_isCompositionDisabled checks.
* Modules/webxr/WebXRWebGLLayer.cpp:
(WebCore::WebXRWebGLLayer::create):
(WebCore::WebXRWebGLLayer::WebXRWebGLLayer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (272490 => 272491)
--- trunk/Source/WebCore/ChangeLog 2021-02-08 15:40:52 UTC (rev 272490)
+++ trunk/Source/WebCore/ChangeLog 2021-02-08 16:14:32 UTC (rev 272491)
@@ -1,3 +1,16 @@
+2021-02-08 Imanol Fernandez <[email protected]>
+
+ Fix WebXRWebGLLayer m_isCompositionDisabled checks
+ https://bugs.webkit.org/show_bug.cgi?id=221551
+
+ Reviewed by Sergio Villar Senin.
+
+ Fix reversed m_isCompositionDisabled checks.
+
+ * Modules/webxr/WebXRWebGLLayer.cpp:
+ (WebCore::WebXRWebGLLayer::create):
+ (WebCore::WebXRWebGLLayer::WebXRWebGLLayer):
+
2021-02-08 Andres Gonzalez <[email protected]>
Add support for aria-sort change notifications.
Modified: trunk/Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp (272490 => 272491)
--- trunk/Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp 2021-02-08 15:40:52 UTC (rev 272490)
+++ trunk/Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp 2021-02-08 16:14:32 UTC (rev 272491)
@@ -74,7 +74,7 @@
// 9. (see constructor except for the resources initialization step which is handled in the if block below)
auto layer = adoptRef(*new WebXRWebGLLayer(WTFMove(session), WTFMove(context), init));
- if (layer->m_isCompositionDisabled) {
+ if (!layer->m_isCompositionDisabled) {
// 9.4. Allocate and initialize resources compatible with session’s XR device, including GPU accessible memory buffers,
// as required to support the compositing of layer.
// 9.5. If layer’s resources were unable to be created for any reason, throw an OperationError and abort these steps.
@@ -109,7 +109,7 @@
m_isCompositionDisabled = m_session->mode() == XRSessionMode::Inline;
// 9. If layer’s composition disabled boolean is false:
- if (m_isCompositionDisabled) {
+ if (!m_isCompositionDisabled) {
// 1. Initialize layer’s antialias to layerInit’s antialias value.
m_antialias = init.antialias;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
