Title: [272571] trunk/Source/WebCore
- Revision
- 272571
- Author
- [email protected]
- Date
- 2021-02-09 02:30:52 -0800 (Tue, 09 Feb 2021)
Log Message
Rename XRWebGLLayer m_IscompositionDisabled to m_IscompositionEnabled
https://bugs.webkit.org/show_bug.cgi?id=221599
Patch by Imanol Fernandez <[email protected]> on 2021-02-09
Reviewed by Sergio Villar Senin.
The spec agreed to rename this to avoid double negations in code.
See https://github.com/immersive-web/webxr/pull/1172.
* Modules/webxr/WebXRWebGLLayer.cpp:
(WebCore::WebXRWebGLLayer::create):
(WebCore::WebXRWebGLLayer::WebXRWebGLLayer):
* Modules/webxr/WebXRWebGLLayer.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (272570 => 272571)
--- trunk/Source/WebCore/ChangeLog 2021-02-09 10:02:13 UTC (rev 272570)
+++ trunk/Source/WebCore/ChangeLog 2021-02-09 10:30:52 UTC (rev 272571)
@@ -1,3 +1,18 @@
+2021-02-09 Imanol Fernandez <[email protected]>
+
+ Rename XRWebGLLayer m_IscompositionDisabled to m_IscompositionEnabled
+ https://bugs.webkit.org/show_bug.cgi?id=221599
+
+ Reviewed by Sergio Villar Senin.
+
+ The spec agreed to rename this to avoid double negations in code.
+ See https://github.com/immersive-web/webxr/pull/1172.
+
+ * Modules/webxr/WebXRWebGLLayer.cpp:
+ (WebCore::WebXRWebGLLayer::create):
+ (WebCore::WebXRWebGLLayer::WebXRWebGLLayer):
+ * Modules/webxr/WebXRWebGLLayer.h:
+
2021-02-08 Rob Buis <[email protected]>
Make auto && <ratio> use content box-sizing
Modified: trunk/Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp (272570 => 272571)
--- trunk/Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp 2021-02-09 10:02:13 UTC (rev 272570)
+++ trunk/Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp 2021-02-09 10:30:52 UTC (rev 272571)
@@ -74,7 +74,7 @@
// 9. (see constructor except for the resources initialization step which is handled in the if block below)
auto layer = adoptRef(*new WebXRWebGLLayer(WTFMove(session), WTFMove(context), init));
- if (!layer->m_isCompositionDisabled) {
+ if (layer->m_isCompositionEnabled) {
// 9.4. Allocate and initialize resources compatible with session’s XR device, including GPU accessible memory buffers,
// as required to support the compositing of layer.
// 9.5. If layer’s resources were unable to be created for any reason, throw an OperationError and abort these steps.
@@ -106,10 +106,10 @@
// 8. Initialize layer's composition disabled boolean as follows:
// If session is an inline session -> Initialize layer's composition disabled to true
// Otherwise -> Initialize layer's composition disabled boolean to false
- m_isCompositionDisabled = m_session->mode() == XRSessionMode::Inline;
+ m_isCompositionEnabled = m_session->mode() != XRSessionMode::Inline;
// 9. If layer’s composition disabled boolean is false:
- if (!m_isCompositionDisabled) {
+ if (m_isCompositionEnabled) {
// 1. Initialize layer’s antialias to layerInit’s antialias value.
m_antialias = init.antialias;
Modified: trunk/Source/WebCore/Modules/webxr/WebXRWebGLLayer.h (272570 => 272571)
--- trunk/Source/WebCore/Modules/webxr/WebXRWebGLLayer.h 2021-02-09 10:02:13 UTC (rev 272570)
+++ trunk/Source/WebCore/Modules/webxr/WebXRWebGLLayer.h 2021-02-09 10:30:52 UTC (rev 272571)
@@ -84,7 +84,7 @@
WebXRRenderingContext m_context;
bool m_antialias { false };
bool m_ignoreDepthValues { false };
- bool m_isCompositionDisabled { false };
+ bool m_isCompositionEnabled { true };
struct {
RefPtr<WebGLFramebuffer> object;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
