Title: [272579] trunk/Source/WebCore
Revision
272579
Author
[email protected]
Date
2021-02-09 07:03:44 -0800 (Tue, 09 Feb 2021)

Log Message

[LFC][IFC] canUseForText should also check if the space glyph comes from the primary font
https://bugs.webkit.org/show_bug.cgi?id=221592

Reviewed by Antti Koivisto.

Currently all the glyphs in the content have to come from the primary font, including the space.
(see fast/text/multiple-feature-properties.html)

* layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForText):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (272578 => 272579)


--- trunk/Source/WebCore/ChangeLog	2021-02-09 14:56:00 UTC (rev 272578)
+++ trunk/Source/WebCore/ChangeLog	2021-02-09 15:03:44 UTC (rev 272579)
@@ -1,5 +1,18 @@
 2021-02-09  Zalan Bujtas  <[email protected]>
 
+        [LFC][IFC] canUseForText should also check if the space glyph comes from the primary font
+        https://bugs.webkit.org/show_bug.cgi?id=221592
+
+        Reviewed by Antti Koivisto.
+
+        Currently all the glyphs in the content have to come from the primary font, including the space.
+        (see fast/text/multiple-feature-properties.html)
+
+        * layout/integration/LayoutIntegrationCoverage.cpp:
+        (WebCore::LayoutIntegration::canUseForText):
+
+2021-02-09  Zalan Bujtas  <[email protected]>
+
         [LFC][IFC] Remove misleading TextUtil::fixedPitchWidth
         https://bugs.webkit.org/show_bug.cgi?id=221581
 

Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp (272578 => 272579)


--- trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp	2021-02-09 14:56:00 UTC (rev 272578)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp	2021-02-09 15:03:44 UTC (rev 272579)
@@ -445,9 +445,6 @@
 
     for (unsigned i = 0; i < length; ++i) {
         auto character = text[i];
-        if (FontCascade::treatAsSpace(character))
-            continue;
-
         auto characterReasons = canUseForCharacter(character, textIsJustified, includeReasons);
         if (characterReasons)
             ADD_REASONS_AND_RETURN_IF_NEEDED(characterReasons, reasons, includeReasons);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to