Title: [272612] trunk
- Revision
- 272612
- Author
- [email protected]
- Date
- 2021-02-09 14:07:12 -0800 (Tue, 09 Feb 2021)
Log Message
Fix warning introduced by r272580
https://bugs.webkit.org/show_bug.cgi?id=221612
JSTests:
Unreviewd, update test262/config.yaml
Patch by Caio Lima <[email protected]> on 2021-02-09
* test262/config.yaml:
Since `class-methods-private` also includes private accessors tests,
we should enable it only after https://bugs.webkit.org/show_bug.cgi?id=194435
gets closed.
Source/_javascript_Core:
Unreviewed build fixes.
Patch by Caio Lima <[email protected]> on 2021-02-09
* bytecode/CheckPrivateBrandVariant.cpp:
* bytecode/CheckPrivateBrandVariant.h:
* bytecode/SetPrivateBrandVariant.cpp:
* bytecode/SetPrivateBrandVariant.h:
Modified Paths
Diff
Modified: trunk/JSTests/ChangeLog (272611 => 272612)
--- trunk/JSTests/ChangeLog 2021-02-09 22:05:39 UTC (rev 272611)
+++ trunk/JSTests/ChangeLog 2021-02-09 22:07:12 UTC (rev 272612)
@@ -1,5 +1,18 @@
2021-02-09 Caio Lima <[email protected]>
+ Fix warning introduced by r272580
+ https://bugs.webkit.org/show_bug.cgi?id=221612
+
+ Unreviewd, update test262/config.yaml
+
+ * test262/config.yaml:
+
+ Since `class-methods-private` also includes private accessors tests,
+ we should enable it only after https://bugs.webkit.org/show_bug.cgi?id=194435
+ gets closed.
+
+2021-02-09 Caio Lima <[email protected]>
+
[ESNext] Implement private methods
https://bugs.webkit.org/show_bug.cgi?id=194434
Modified: trunk/JSTests/test262/config.yaml (272611 => 272612)
--- trunk/JSTests/test262/config.yaml 2021-02-09 22:05:39 UTC (rev 272611)
+++ trunk/JSTests/test262/config.yaml 2021-02-09 22:07:12 UTC (rev 272612)
@@ -4,7 +4,6 @@
WeakRef: useWeakRefs
FinalizationRegistry: useWeakRefs
class-fields-private: usePrivateClassFields
- class-methods-private: usePrivateMethods
class-static-fields-public: usePublicStaticClassFields
class-static-fields-private: usePrivateStaticClassFields
Intl.DateTimeFormat-dayPeriod: useIntlDateTimeFormatDayPeriod
@@ -20,6 +19,7 @@
- regexp-lookbehind
- legacy-regexp
+ - class-methods-private
- class-static-methods-private
- cleanupSome
- host-gc-required
Modified: trunk/Source/_javascript_Core/ChangeLog (272611 => 272612)
--- trunk/Source/_javascript_Core/ChangeLog 2021-02-09 22:05:39 UTC (rev 272611)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-02-09 22:07:12 UTC (rev 272612)
@@ -1,5 +1,17 @@
2021-02-09 Caio Lima <[email protected]>
+ Fix warning introduced by r272580
+ https://bugs.webkit.org/show_bug.cgi?id=221612
+
+ Unreviewed build fixes.
+
+ * bytecode/CheckPrivateBrandVariant.cpp:
+ * bytecode/CheckPrivateBrandVariant.h:
+ * bytecode/SetPrivateBrandVariant.cpp:
+ * bytecode/SetPrivateBrandVariant.h:
+
+2021-02-09 Caio Lima <[email protected]>
+
[ESNext] Implement private methods
https://bugs.webkit.org/show_bug.cgi?id=194434
Modified: trunk/Source/_javascript_Core/bytecode/CheckPrivateBrandVariant.cpp (272611 => 272612)
--- trunk/Source/_javascript_Core/bytecode/CheckPrivateBrandVariant.cpp 2021-02-09 22:05:39 UTC (rev 272611)
+++ trunk/Source/_javascript_Core/bytecode/CheckPrivateBrandVariant.cpp 2021-02-09 22:07:12 UTC (rev 272612)
@@ -38,11 +38,6 @@
CheckPrivateBrandVariant::~CheckPrivateBrandVariant() { }
-CheckPrivateBrandVariant::CheckPrivateBrandVariant(const CheckPrivateBrandVariant& other)
-{
- *this = other;
-}
-
bool CheckPrivateBrandVariant::attemptToMerge(const CheckPrivateBrandVariant& other)
{
if (!!m_identifier != !!other.m_identifier)
Modified: trunk/Source/_javascript_Core/bytecode/CheckPrivateBrandVariant.h (272611 => 272612)
--- trunk/Source/_javascript_Core/bytecode/CheckPrivateBrandVariant.h 2021-02-09 22:05:39 UTC (rev 272611)
+++ trunk/Source/_javascript_Core/bytecode/CheckPrivateBrandVariant.h 2021-02-09 22:07:12 UTC (rev 272612)
@@ -41,8 +41,6 @@
~CheckPrivateBrandVariant();
- CheckPrivateBrandVariant(const CheckPrivateBrandVariant&);
-
const StructureSet& structureSet() const { return m_structureSet; }
StructureSet& structureSet() { return m_structureSet; }
Modified: trunk/Source/_javascript_Core/bytecode/SetPrivateBrandVariant.cpp (272611 => 272612)
--- trunk/Source/_javascript_Core/bytecode/SetPrivateBrandVariant.cpp 2021-02-09 22:05:39 UTC (rev 272611)
+++ trunk/Source/_javascript_Core/bytecode/SetPrivateBrandVariant.cpp 2021-02-09 22:07:12 UTC (rev 272612)
@@ -39,11 +39,6 @@
SetPrivateBrandVariant::~SetPrivateBrandVariant() { }
-SetPrivateBrandVariant::SetPrivateBrandVariant(const SetPrivateBrandVariant& other)
-{
- *this = other;
-}
-
bool SetPrivateBrandVariant::attemptToMerge(const SetPrivateBrandVariant& other)
{
if (!!m_identifier != !!other.m_identifier)
Modified: trunk/Source/_javascript_Core/bytecode/SetPrivateBrandVariant.h (272611 => 272612)
--- trunk/Source/_javascript_Core/bytecode/SetPrivateBrandVariant.h 2021-02-09 22:05:39 UTC (rev 272611)
+++ trunk/Source/_javascript_Core/bytecode/SetPrivateBrandVariant.h 2021-02-09 22:07:12 UTC (rev 272612)
@@ -40,8 +40,6 @@
~SetPrivateBrandVariant();
- SetPrivateBrandVariant(const SetPrivateBrandVariant&);
-
Structure* oldStructure() const { return m_oldStructure; }
Structure* newStructure() const { return m_newStructure; }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
