Title: [272617] trunk/Source
- Revision
- 272617
- Author
- [email protected]
- Date
- 2021-02-09 15:06:53 -0800 (Tue, 09 Feb 2021)
Log Message
[Cocoa] rename `ENGINEERING_BUILD` to `ENABLE_DEVELOPER_MODE` to match other platforms
https://bugs.webkit.org/show_bug.cgi?id=221621
Reviewed by Michael Catanzaro.
* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
Source/WebCore:
(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (272616 => 272617)
--- trunk/Source/WebCore/ChangeLog 2021-02-09 23:04:04 UTC (rev 272616)
+++ trunk/Source/WebCore/ChangeLog 2021-02-09 23:06:53 UTC (rev 272617)
@@ -1,3 +1,14 @@
+2021-02-09 Devin Rousso <[email protected]>
+
+ [Cocoa] rename `ENGINEERING_BUILD` to `ENABLE_DEVELOPER_MODE` to match other platforms
+ https://bugs.webkit.org/show_bug.cgi?id=221621
+
+ Reviewed by Michael Catanzaro.
+
+ * Configurations/Base.xcconfig:
+ * Configurations/DebugRelease.xcconfig:
+ (WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
+
2021-02-09 Simon Fraser <[email protected]>
Change release log to mention IOSurface
Modified: trunk/Source/WebCore/Configurations/Base.xcconfig (272616 => 272617)
--- trunk/Source/WebCore/Configurations/Base.xcconfig 2021-02-09 23:04:04 UTC (rev 272616)
+++ trunk/Source/WebCore/Configurations/Base.xcconfig 2021-02-09 23:06:53 UTC (rev 272617)
@@ -70,7 +70,7 @@
GCC_NO_COMMON_BLOCKS = YES;
GCC_OBJC_CALL_CXX_CDTORS = YES;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
-GCC_PREPROCESSOR_DEFINITIONS = $(inherited) $(ENGINEERING_BUILD_DEFINES);
+GCC_PREPROCESSOR_DEFINITIONS = $(inherited) $(DEVELOPER_MODE_DEFINES);
GCC_SYMBOLS_PRIVATE_EXTERN = YES;
GCC_THREADSAFE_STATICS = NO;
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
@@ -93,8 +93,8 @@
GCC_WARN_UNUSED_VARIABLE = YES;
WARNING_CFLAGS = -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wconditional-uninitialized -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough -Wvla -Wno-unknown-warning-option -Wliteral-conversion;
-ENGINEERING_BUILD_DEFINES = $(ENGINEERING_BUILD_DEFINES_$(ENGINEERING_BUILD));
-ENGINEERING_BUILD_DEFINES_1 = ENGINEERING_BUILD=1;
+DEVELOPER_MODE_DEFINES = $(DEVELOPER_MODE_DEFINES_$(DEVELOPER_MODE));
+DEVELOPER_MODE_DEFINES_1 = ENABLE_DEVELOPER_MODE=1;
TARGET_MACOS_LEGACY_VERSION_IDENTIFIER = $(TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_$(MACOSX_DEPLOYMENT_TARGET:base))
TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_10 = 10$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier)
Modified: trunk/Source/WebCore/Configurations/DebugRelease.xcconfig (272616 => 272617)
--- trunk/Source/WebCore/Configurations/DebugRelease.xcconfig 2021-02-09 23:04:04 UTC (rev 272616)
+++ trunk/Source/WebCore/Configurations/DebugRelease.xcconfig 2021-02-09 23:06:53 UTC (rev 272617)
@@ -49,7 +49,7 @@
MACOSX_DEPLOYMENT_TARGET_110000 = 11.0;
MACOSX_DEPLOYMENT_TARGET_120000 = 12.0;
-ENGINEERING_BUILD = 1;
+DEVELOPER_MODE = 1;
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = YES;
DEBUG_INFORMATION_FORMAT = dwarf;
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (272616 => 272617)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2021-02-09 23:04:04 UTC (rev 272616)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2021-02-09 23:06:53 UTC (rev 272617)
@@ -7156,7 +7156,7 @@
if (functionValue.isCallable(vm))
return true;
-#if ENGINEERING_BUILD || !defined(NDEBUG)
+#if ENABLE(DEVELOPER_MODE) || !defined(NDEBUG)
// Setting a scriptURL allows the source to be debuggable in the inspector.
URL scriptURL = URL({ }, "mediaControlsScript"_s);
#else
Modified: trunk/Source/WebInspectorUI/ChangeLog (272616 => 272617)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-02-09 23:04:04 UTC (rev 272616)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-02-09 23:06:53 UTC (rev 272617)
@@ -1,3 +1,13 @@
+2021-02-09 Devin Rousso <[email protected]>
+
+ [Cocoa] rename `ENGINEERING_BUILD` to `ENABLE_DEVELOPER_MODE` to match other platforms
+ https://bugs.webkit.org/show_bug.cgi?id=221621
+
+ Reviewed by Michael Catanzaro.
+
+ * Configurations/Base.xcconfig:
+ * Configurations/DebugRelease.xcconfig:
+
2021-02-08 Patrick Angle <[email protected]>
Web Inspector: Add `CSS.setLayoutContextTypeChangedMode` for getting information about all layout contexts
Modified: trunk/Source/WebInspectorUI/Configurations/Base.xcconfig (272616 => 272617)
--- trunk/Source/WebInspectorUI/Configurations/Base.xcconfig 2021-02-09 23:04:04 UTC (rev 272616)
+++ trunk/Source/WebInspectorUI/Configurations/Base.xcconfig 2021-02-09 23:06:53 UTC (rev 272617)
@@ -45,7 +45,7 @@
GCC_GENERATE_DEBUGGING_SYMBOLS = YES;
GCC_NO_COMMON_BLOCKS = YES;
GCC_PRECOMPILE_PREFIX_HEADER = NO;
-GCC_PREPROCESSOR_DEFINITIONS = $(inherited) $(ENGINEERING_BUILD_DEFINES);
+GCC_PREPROCESSOR_DEFINITIONS = $(inherited) $(DEVELOPER_MODE_DEFINES);
GCC_THREADSAFE_STATICS = NO;
GCC_TREAT_WARNINGS_AS_ERRORS = YES;
GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
@@ -64,8 +64,8 @@
GCC_WARN_UNUSED_VARIABLE = YES
WARNING_CFLAGS = -Wall -W -Wcast-qual -Wchar-subscripts -Wconditional-uninitialized -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -Wexit-time-destructors -Wvla -Wliteral-conversion;
-ENGINEERING_BUILD_DEFINES = $(ENGINEERING_BUILD_DEFINES_$(ENGINEERING_BUILD));
-ENGINEERING_BUILD_DEFINES_1 = ENGINEERING_BUILD=1;
+DEVELOPER_MODE_DEFINES = $(DEVELOPER_MODE_DEFINES_$(DEVELOPER_MODE));
+DEVELOPER_MODE_DEFINES_1 = ENABLE_DEVELOPER_MODE=1;
SUPPORTED_PLATFORMS = iphoneos iphonesimulator macosx appletvos appletvsimulator watchos watchsimulator;
SUPPORTS_MACCATALYST = YES;
Modified: trunk/Source/WebInspectorUI/Configurations/DebugRelease.xcconfig (272616 => 272617)
--- trunk/Source/WebInspectorUI/Configurations/DebugRelease.xcconfig 2021-02-09 23:04:04 UTC (rev 272616)
+++ trunk/Source/WebInspectorUI/Configurations/DebugRelease.xcconfig 2021-02-09 23:06:53 UTC (rev 272617)
@@ -26,7 +26,7 @@
MACOSX_DEPLOYMENT_TARGET_110000 = 11.0;
MACOSX_DEPLOYMENT_TARGET_120000 = 12.0;
-ENGINEERING_BUILD = 1;
+DEVELOPER_MODE = 1;
GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = YES;
DEBUG_INFORMATION_FORMAT = dwarf;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
