Title: [105484] trunk/Source/WebCore
- Revision
- 105484
- Author
- [email protected]
- Date
- 2012-01-19 23:18:58 -0800 (Thu, 19 Jan 2012)
Log Message
Node::canHaveLightChildRendererWithShadow is not used anywhere.
https://bugs.webkit.org/show_bug.cgi?id=76627
Patch by Shinya Kawanaka <[email protected]> on 2012-01-19
Reviewed by Darin Adler.
Since Node::canHaveLightChildRendererWithShadow is not overriden anywhere, and it returns always false.
We can remove it.
No new tests, because no change in behavior.
* dom/Node.h:
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::shouldCreateRenderer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (105483 => 105484)
--- trunk/Source/WebCore/ChangeLog 2012-01-20 06:39:21 UTC (rev 105483)
+++ trunk/Source/WebCore/ChangeLog 2012-01-20 07:18:58 UTC (rev 105484)
@@ -1,3 +1,19 @@
+2012-01-19 Shinya Kawanaka <[email protected]>
+
+ Node::canHaveLightChildRendererWithShadow is not used anywhere.
+ https://bugs.webkit.org/show_bug.cgi?id=76627
+
+ Reviewed by Darin Adler.
+
+ Since Node::canHaveLightChildRendererWithShadow is not overriden anywhere, and it returns always false.
+ We can remove it.
+
+ No new tests, because no change in behavior.
+
+ * dom/Node.h:
+ * dom/NodeRenderingContext.cpp:
+ (WebCore::NodeRenderingContext::shouldCreateRenderer):
+
2012-01-19 Kinuko Yasuda <[email protected]>
Cleanup: make constant variable names in fileapi/ conform to WebKit's coding guideline
Modified: trunk/Source/WebCore/dom/Node.h (105483 => 105484)
--- trunk/Source/WebCore/dom/Node.h 2012-01-20 06:39:21 UTC (rev 105483)
+++ trunk/Source/WebCore/dom/Node.h 2012-01-20 07:18:58 UTC (rev 105484)
@@ -224,7 +224,6 @@
bool isDocumentNode() const;
bool isShadowRoot() const { return getFlag(IsShadowRootOrSVGShadowRootFlag) && !isSVGElement(); }
virtual bool isContentElement() const { return false; }
- virtual bool canHaveLightChildRendererWithShadow() const { return false; }
Node* shadowAncestorNode() const;
// Returns 0, a ShadowRoot, or a legacy shadow root.
Modified: trunk/Source/WebCore/dom/NodeRenderingContext.cpp (105483 => 105484)
--- trunk/Source/WebCore/dom/NodeRenderingContext.cpp 2012-01-20 06:39:21 UTC (rev 105483)
+++ trunk/Source/WebCore/dom/NodeRenderingContext.cpp 2012-01-20 07:18:58 UTC (rev 105484)
@@ -280,8 +280,8 @@
// See https://bugs.webkit.org/show_bug.cgi?id=52423
if (!parentRenderer->canHaveChildren())
return false;
-
- if (m_visualParentShadowRoot && !m_parentNodeForRenderingAndStyle->canHaveLightChildRendererWithShadow())
+
+ if (m_visualParentShadowRoot)
return false;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
