Title: [272686] trunk
- Revision
- 272686
- Author
- ryanhad...@apple.com
- Date
- 2021-02-10 14:35:59 -0800 (Wed, 10 Feb 2021)
Log Message
Unreviewed, reverting r272507.
Caused TestWebKitAPI.WebKit.OnDeviceChangeCrash to become a
flaky timeout
Reverted changeset:
"[MacOS] Enable Audio Capture in GPUProcess by default"
https://bugs.webkit.org/show_bug.cgi?id=221400
https://trac.webkit.org/changeset/272507
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (272685 => 272686)
--- trunk/Source/WebKit/ChangeLog 2021-02-10 22:00:54 UTC (rev 272685)
+++ trunk/Source/WebKit/ChangeLog 2021-02-10 22:35:59 UTC (rev 272686)
@@ -1,3 +1,16 @@
+2021-02-10 Ryan Haddad <ryanhad...@apple.com>
+
+ Unreviewed, reverting r272507.
+
+ Caused TestWebKitAPI.WebKit.OnDeviceChangeCrash to become a
+ flaky timeout
+
+ Reverted changeset:
+
+ "[MacOS] Enable Audio Capture in GPUProcess by default"
+ https://bugs.webkit.org/show_bug.cgi?id=221400
+ https://trac.webkit.org/changeset/272507
+
2021-02-10 BJ Burg <bb...@apple.com>
[Cocoa] Web Inspector: add support for evaluating script on the inspected page via _WKInspectorExtension
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (272685 => 272686)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2021-02-10 22:00:54 UTC (rev 272685)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2021-02-10 22:35:59 UTC (rev 272686)
@@ -183,13 +183,15 @@
bool defaultCaptureAudioInGPUProcessEnabled()
{
+#if HAVE(SYSTEM_FEATURE_FLAGS)
#if PLATFORM(MAC)
- return true;
-#elif HAVE(SYSTEM_FEATURE_FLAGS)
+ return isFeatureFlagEnabled("gpu_process_webrtc");
+#elif PLATFORM(IOS_FAMILY)
return isFeatureFlagEnabled("gpu_process_media");
-#else
+#endif
+#endif
+
return false;
-#endif
}
bool defaultCaptureAudioInUIProcessEnabled()
Modified: trunk/Tools/ChangeLog (272685 => 272686)
--- trunk/Tools/ChangeLog 2021-02-10 22:00:54 UTC (rev 272685)
+++ trunk/Tools/ChangeLog 2021-02-10 22:35:59 UTC (rev 272686)
@@ -1,3 +1,16 @@
+2021-02-10 Ryan Haddad <ryanhad...@apple.com>
+
+ Unreviewed, reverting r272507.
+
+ Caused TestWebKitAPI.WebKit.OnDeviceChangeCrash to become a
+ flaky timeout
+
+ Reverted changeset:
+
+ "[MacOS] Enable Audio Capture in GPUProcess by default"
+ https://bugs.webkit.org/show_bug.cgi?id=221400
+ https://trac.webkit.org/changeset/272507
+
2021-02-10 Aakash Jain <aakash_j...@apple.com>
[build.webkit.org] Remove code specific to old Buildbot
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm (272685 => 272686)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm 2021-02-10 22:00:54 UTC (rev 272685)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm 2021-02-10 22:35:59 UTC (rev 272686)
@@ -85,7 +85,7 @@
@implementation GetUserMediaRepromptTestView
- (BOOL)haveStream:(BOOL)expected
{
- int retryCount = 1000;
+ int retryCount = 10;
while (retryCount--) {
auto result = [self stringByEvaluatingJavaScript:@"haveStream()"];
if (result.boolValue == expected)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
