Title: [272698] trunk/Source/WebKit
- Revision
- 272698
- Author
- [email protected]
- Date
- 2021-02-10 17:26:14 -0800 (Wed, 10 Feb 2021)
Log Message
REGRESSION (r269824) IOSurface allocation failure causes crash in RemoteLayerBackingStore::display()
https://bugs.webkit.org/show_bug.cgi?id=221729
rdar://72651289
Reviewed by Tim Horton.
The refactoring in r269824 dropped a null check on the front buffer surface (IOSurface allocation
can fail when the process reaches a hardcoded limit). Restore the null check.
* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::display):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (272697 => 272698)
--- trunk/Source/WebKit/ChangeLog 2021-02-11 00:11:34 UTC (rev 272697)
+++ trunk/Source/WebKit/ChangeLog 2021-02-11 01:26:14 UTC (rev 272698)
@@ -1,3 +1,17 @@
+2021-02-10 Simon Fraser <[email protected]>
+
+ REGRESSION (r269824) IOSurface allocation failure causes crash in RemoteLayerBackingStore::display()
+ https://bugs.webkit.org/show_bug.cgi?id=221729
+ rdar://72651289
+
+ Reviewed by Tim Horton.
+
+ The refactoring in r269824 dropped a null check on the front buffer surface (IOSurface allocation
+ can fail when the process reaches a hardcoded limit). Restore the null check.
+
+ * Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
+ (WebKit::RemoteLayerBackingStore::display):
+
2021-02-10 Peng Liu <[email protected]>
Remove MediaSourcePrivateClient::monitorSourceBuffers()
Modified: trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm (272697 => 272698)
--- trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm 2021-02-11 00:11:34 UTC (rev 272697)
+++ trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm 2021-02-11 01:26:14 UTC (rev 272698)
@@ -220,6 +220,8 @@
WebCore::IntRect expandedScaledLayerBounds(WebCore::IntPoint(), expandedScaledSize);
swapToValidFrontBuffer();
+ if (!m_frontBuffer.imageBuffer)
+ return true;
WebCore::GraphicsContext& context = m_frontBuffer.imageBuffer->context();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
